Re: [PATCH v2 1/3] dt-bindings: i3c: dw: support up to two reset lines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: i3c: dw: maxItems mismatch with commit message
- [Low] dt-bindings: i3c: dw: missing items/reset-names for multiple resets
--

commit 6da78b08867272d83c36c1c30ce43bb39d9aaf6d
Author: Jisheng Zhang <jszhang@kernel.org>

dt-bindings: i3c: dw: support up to two reset lines

This commit updates the Synopsys DesignWare I3C master controller device tree
binding to support multiple reset lines. It increases the maxItems for the
resets property to 2 and adds a conditional block to maintain the previous
limit for the Agilex 5 variant.

> The Synopsys DesignWare I3C master controller can have multiple reset
> lines, such as core reset, apb reset, and dma reset.
> 
> Update the DT binding documentation to increase maxItems for the resets
> property to 2.

[Severity: Medium]
The commit message explicitly lists three distinct reset lines (core reset,
apb reset, and dma reset). Does limiting the property to 2 directly
contradict the hardware capabilities described?

A hardware configuration wired with all three resets would fail schema
validation, and the follow-up patches in the series do not appear to fix
this mismatch.

> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
[ ... ]
> @@ -39,7 +49,7 @@ properties:
>      maxItems: 1
>  
>    resets:
> -    maxItems: 1
> +    maxItems: 2

[Severity: Low]
When allowing multiple items in an array, does the schema need to document
the exact order (via an items list) or require reset-names?

Without a strict documented order or reset-names, the OS-independent ABI
remains ambiguous. Although a follow-up patch in this series (commit "i3c:
dw: switch to array-based exclusive reset control") updates the Linux driver
to use devm_reset_control_array_get_optional_exclusive to fetch all resets
regardless of order, the device tree binding itself remains incomplete.

Other OSes or future drivers that may need to toggle these distinct reset
lines sequentially currently have no ABI to rely on.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005152425.25319-1-jszhang@kernel.org?part=1