Re: [PATCH v2 7/7] leds: aw2013: move reset from probe_dt to chip_init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] leds: aw2013 hardware retains uncontrolled bootloader state
- [Low] leds: commit message capitalization violation
--

commit 62a3fe5d7c44e90d5a2b75159d01568ea923e7e2
Author: Paul Sajna <sajattack@postmarketos.org>

leds: aw2013: move reset from probe_dt to chip_init

This commit moves the chip reset logic from the Device Tree probing function
to the chip initialization routine. This is intended to simplify mutex
requirements during initialization.

> leds: aw2013: move reset from probe_dt to chip_init

[Severity: Low]
This isn't a bug, but does the commit message violate the subsystem's
capitalization guidelines?

The LED subsystem requires the description to be capitalized after the
subsystem prefix. Should "move" be capitalized to "Move" here?

> diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
> index 2a133657d9b64..7bc0415375c6f 100644
> --- a/drivers/leds/leds-aw2013.c
> +++ b/drivers/leds/leds-aw2013.c

[ ... ]

> @@ -369,8 +376,6 @@ static int aw20xx_probe_dt(struct aw20xx *chip)
>  	if (!count || count > AW20XX_MAX_LEDS)
>  		return -EINVAL;
>  
> -	regmap_write(chip->regmap, AW20XX_RSTR, AW20XX_RSTR_RESET);
> -
>  	for_each_available_child_of_node_scoped(np, child) {

[Severity: Medium]
Will removing this unconditional reset from aw20xx_probe_dt() allow the
hardware to retain uncontrolled bootloader state?

By moving the reset exclusively to aw20xx_chip_init(), the reset only occurs
when the kernel explicitly enables the LEDs. If the bootloader leaves the
LEDs enabled and the regulator is shared with another active device, the chip
won't be reset during probe and will remain powered.

Could this cause the LEDs to stay illuminated indefinitely without the
kernel's awareness until user space explicitly requests a state change?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-aw2013-aw20xx-rename-v2-0-108ecbdf2775@postmarketos.org?part=7