From: sashiko-bot@kernel.org
To: "Jeremy Dean" <deaner92@yahoo.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: pwm: Convert NXP PCA9685 PWM controller to DT schema
Date: Tue, 06 Oct 2026 04:05:00 +0000 [thread overview]
Message-ID: <20261006040501.87FD41F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261006033518.34332-1-deaner92@yahoo.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: pwm: missing #pwm-cells in required properties
- [Low] dt-bindings: pwm: hallucinated maintainer name in YAML schema
--
commit 2d85be96eb45879405596ef1a5131c2b3425b8ed
Author: Jeremy Dean <deaner92@yahoo.com>
dt-bindings: pwm: Convert NXP PCA9685 PWM controller to DT schema
Convert the NXP PCA9685 PWM controller binding to DT schema format. The
conversion documents the reg property and makes it required, updates the
example node, and describes the PWM specifier cells and properties.
> diff --git a/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.yaml
> new file mode 100644
> index 0000000000000..36b312ac0be95
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/nxp,pca9685-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PCA9685 16-channel 12-bit PWM LED controller
> +
> +maintainers:
> + - Jeremy Clifton <deaner92@yahoo.com>
[Severity: Low]
Is this the correct maintainer name? It looks like the name listed here
does not match the name of the patch submitter. Could this result in
incorrect attribution and metadata parsing by get_maintainer.pl?
[ ... ]
> +required:
> + - compatible
> + - reg
[Severity: Medium]
Should #pwm-cells be included in this required block?
The original text binding correctly mandated #pwm-cells since the PCA9685
acts as a PWM provider. Omitting it from the required list here reduces
schema validation coverage, allowing device trees that are missing the
property to silently pass.
> +
> +unevaluatedProperties: false
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006033518.34332-1-deaner92@yahoo.com?part=1
next prev parent reply other threads:[~2026-10-06 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261006033518.34332-1-deaner92.ref@yahoo.com>
2026-10-06 3:35 ` [PATCH] dt-bindings: pwm: Convert NXP PCA9685 PWM controller to DT schema Jeremy Dean
2026-10-06 4:05 ` sashiko-bot [this message]
2026-10-09 9:36 ` Krzysztof Kozlowski
2026-10-09 21:04 ` Jeremy Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006040501.87FD41F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=deaner92@yahoo.com \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox