From: sashiko-bot@kernel.org
To: "Kaipeng Zeng" <kaipeng94@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)
Date: Tue, 06 Oct 2026 09:07:38 +0000 [thread overview]
Message-ID: <20261006090739.71EFE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006085425.40450-3-kaipeng94@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: incorrect audio routing for Right Woofer to WSA_SPK2 OUT
--
commit 3b512df8c5cf84f3c49842cc54b1c1d65850a946
Author: Kaipeng Zeng <kaipeng94@gmail.com>
arm64: dts: qcom: Add support for Acer Swift Go Pro AI (SFA14-11)
Introduce device tree for the Acer Swift Go Pro AI (SFA14-11).
It is a laptop based on the Qualcomm Snapdragon X Elite (X1E78100) SoC.
This device tree implementation references nodes from the x1-crd.dtsi.
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts
> new file mode 100644
> index 0000000000000..dafe7f08fa958
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-acer-sfa14-11.dts
[ ... ]
> + sound {
> + compatible = "qcom,x1e80100-sndcard";
> + model = "X1E78100-ACER-Swift-Go-SFA14-11";
> + audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> + "TweeterLeft IN", "WSA WSA_SPK2 OUT",
> + "WooferRight IN", "WSA2 WSA_SPK2 OUT",
> + "TweeterRight IN", "WSA2 WSA_SPK2 OUT",
[Severity: Medium]
Does this code incorrectly map both the Right Woofer and Right Tweeter to the
same macro output (WSA2 WSA_SPK2 OUT)?
Since the Right Woofer expects audio data on SoundWire ports 1, 2, and 3
(corresponding to INT0/SPK1), routing it to INT1/SPK2 could mean it will be
starved of audio data and remain silent.
Should "WooferRight IN" be routed to "WSA2 WSA_SPK1 OUT" instead?
> + "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006085425.40450-1-kaipeng94@gmail.com?part=2
next prev parent reply other threads:[~2026-10-06 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 8:54 [PATCH v4 0/2] Add device tree for Acer Swift Go Pro AI (SFA14-11) Kaipeng Zeng
2026-10-06 8:54 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Add " Kaipeng Zeng
2026-10-06 8:54 ` [PATCH v4 2/2] arm64: dts: qcom: Add support for " Kaipeng Zeng
2026-10-06 9:07 ` sashiko-bot [this message]
2026-10-08 10:34 ` [PATCH v4 0/2] Add device tree " Jianfeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006090739.71EFE1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kaipeng94@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox