From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB4F3C1083 for ; Tue, 6 Oct 2026 11:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791286405; cv=none; b=L2Ah/a9PSBj3wLK01LFZMkR6DyvKscWpxUWQlU4d3MthFfzxy6ImD5umsDvHyLT3hAc3/5FBbo4S3/P0IR+24tUVBjhv9z8AQR36BY2/ViYEXofWFIucZV/vNWmEDTEFvWPOJPXGZPNRRuSz77LnIhjvCP0/5q3aaeooSBK7rhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791286405; c=relaxed/simple; bh=K+paxjzoi7IzgH+mfHtxQm46Je8LqMNkCno24z5At/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rduf/Bu+6BFwmBYvp9Ogn6OvUli7HxAuBHKoCSlYNn4mQDZXR6K2ynOJsCRxsBIci3hE0TIJXlYRT4Nk+coDKtRJqT8B0LchhEtRWhulXZxCL19Wq+ToYyVyTYgvCPu61xnbanKI0h6ePXry2JAUf1Bs0TM9HzxQ4Yw6sAL0TVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NgaHlvkD; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NgaHlvkD" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1419d3416ceso4545873c88.0 for ; Tue, 06 Oct 2026 04:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791286402; x=1791891202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K+paxjzoi7IzgH+mfHtxQm46Je8LqMNkCno24z5At/s=; b=NgaHlvkDNAkww7NGIAOc+OIqWnvDBKwZRrMILo3SuDyqe/P6pWzo+t/bevBC3FOIOp r04ToZrjLpOiHlPKEDIqGyem785r3fr/hVD1KF4hFIrjC7pyY9vjd5N6GX6+MGgK+yyD TglHiLSgbkv+29sNFrS/qG+KmO3LWlmmPs2neDzAu3AuGajFM7GJiWVTIOXdlxzMQt8I pMtWlSbuXwdoD8jZPM/yhnMJs4uqLRcbuISbDGUfcMeIqv4hSZbixuYKu93X+PYEZ7gj DxACO3WuXe8C/Imo58DZrpn/d5GQ9R5ArXvu6Al+SMgOtZJLnOrKr0pMA618DmYtmcdO JeTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791286402; x=1791891202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=K+paxjzoi7IzgH+mfHtxQm46Je8LqMNkCno24z5At/s=; b=aJKGQkfUs3+ZZAOK2kUYyhVcBaEpituGAFn8XGmnpme3ekEASrOLBsLrrd4969DVzb eDXdfLSL+hzuSKyn3OYjjiGYzmwZFNZHIWntpNvIUDwRSSAGJlv5fnqyFhZ/WrxIz6yG RYiAvIvjTIdpa3s5tmmicgPorY0iZEFpJ6ApGzhG+hvCINRieRanGeTGYPrpopthnJ64 ZDeeGFSbGbxsXpHTf7wUtbzRjhdENAcR0A1bqUkND+nIZNqnx97XZ/U2c99ybe3YFLbs sOnzzDpjijUNgRS7pG6wCkszaHy2UxF4YwUnt+pR1RUzh9Wf9pXugIMXPb2RmcPsBGXR pokw== X-Forwarded-Encrypted: i=1; AKwUvBxaQp7w7pBPfdqd9inSkR5z7xE8WtgcSWyFdD8/PoubqgLWbDlxxOPEItNpGR2tgoavqajYXcWGN6Ng@vger.kernel.org X-Gm-Message-State: AFuF++ljLvP4WzuhdDvpO5G7nEc6nEk1mkjjed/ph/6wc+7Z4oweWLRR OYPqaO+2/6j6w4IjOhPzYcGTXHj1bpri/lVA3VHwSUVBefZffm7xxZSW X-Gm-Gg: AYBFou3n7/54cQSn8foSF9aTUH2w+StX8iGhMSTkZNSGYN78TRe2hFP6LLAPa0ZkuvW TUeb/KSuV9Al42zArMS7g8PqUcRRKTM9/nbkvOXWkbI/XEgo1j37jJdUBQHd0byuti98kMP5+cZ Y5nmJVTb2RxMnSP0dpQuOIDXswE7zk2Fdno3d6PFzY0E+9zrFzcDqf3McZQCr/ptO9QiN928RCJ 5Z2GgdfQjp+kB7aOOqO0ti8dR1iPQw/8GMDeSQCDc+HAvYV42wsLGqYPI4NFFpwUvYheAGEVz0/ orIPpxxFznnByPNi4vK0y8QlKYLE9PjZyeYME0IW9IK6ZBErGexDqZyrs2kzbuqsVtZmzoqoTZP Qun4iyHqkGTecKJvtUdvPU8vGFQBIU8Dgge9vOezm+Z9vacxHRQ1TYXigoJ7rPOSHhNs68sEMaS +JT/5A/HXJ1t7ucTu0rUwmHsylqRmGOQAT1YltdS5ELbmcYNGTdMSSyLmggjR8DrtDAmxZ93RCs p54wQJgSEVU2LfEVv8XcZakSLjQho/NTR+d34HRwbiNhk9ZkJFooW2nTodgZEmM8dPHvs6gYK9B ddHhGA== X-Received: by 2002:a05:701b:458c:b0:148:bbae:ad2b with SMTP id a92af1059eb24-151c2b16e87mr13424090c88.11.1791286401479; Tue, 06 Oct 2026 04:33:21 -0700 (PDT) Received: from MaquinaLab.. ([179.179.237.181]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-15d7234c2a2sm10735006c88.0.2026.10.06.04.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 04:33:20 -0700 (PDT) From: Vinicius Pedrosa To: Andre Przywara , linux-serial@vger.kernel.org Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andriy.shevchenko@linux.intel.com, ilpo.jarvinen@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Enzo Adriano Subject: Re: [PATCH 3/3] serial: 8250_dw: Add Allwinner A733 UART Date: Tue, 6 Oct 2026 08:33:06 -0300 Message-ID: <20261006113307.86417-1-vinicius.eduardo.pedrosa@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20261005172538.398522-1-vinicius.eduardo.pedrosa@gmail.com> <20261005172538.398522-4-vinicius.eduardo.pedrosa@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Andre, On 10/6/26 11:46, Andre Przywara wrote: > So I was wondering if we should refine the DLF detection instead? Only > when the readback from 0xc0 returns some 2^n-1 value we assume DLF is > implemented? Thanks, that's better than a per-SoC quirk. On the A7Z, writing all ones to 0xc0 reads back 0x19f, so the same family as your 0x9f with bit 8 on top. A 2^n - 1 check rejects it. With the check on the board, dlf_size is 0 and 0xc0 is still 0 after the termios stress loop. Without it, 0xc0 reads 0xb after boot. I don't have a UART with a real DLF to try. v2 puts the check in its own patch and keeps the fallback, with the A733 compatible only selecting SKIP_SET_RATE. On the fallback alone the same loop leaves 28 garbage bytes in 3000 lines. The probe itself still writes all ones to 0xc0 before restoring it. Would you rather skip that with a DT property, or leave it? Thanks, Vinicius