Re: [PATCH v4 7/7] arm64: dts: qcom: generalmobile-shamrock: new device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: missing status okay for serial console
--

commit 4edd65c8f134e38dc5d335fdbe677afa8c5e9969
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>

arm64: dts: qcom: generalmobile-shamrock: new device

Add General Mobile Shamrock (GM 5 Plus). Shamrock is designed similar to
L9300.

> diff --git a/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts
> new file mode 100644
> index 0000000000000..9114b232cb1bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts
> @@ -0,0 +1,435 @@

[ ... ]

> +	aliases {
> +		mmc0 = &sdhc_1; /* SDC1 eMMC slot */
> +		mmc1 = &sdhc_2; /* SDC2 SD card slot */
> +		serial0 = &blsp1_uart2;
> +	};

[ ... ]

> +	chosen {
> +		stdout-path = "serial0:115200n8";

[Severity: Medium]
Since stdout-path and aliases map the serial console to blsp1_uart2, does
this board file also need to enable the underlying UART node?

The UART device is left disabled by default in msm8952.dtsi, and the status
is not overridden to "okay" here in msm8952-generalmobile-shamrock.dts. As a
result, the device driver will not probe and the system will lack serial
console output, which could break debugging and boot logs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-msm8952-initial-support-v4-0-ecdcc1ac620c@mainlining.org?part=7