From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A3F3C09ED; Fri, 9 Oct 2026 06:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791528935; cv=none; b=P4N5dh4jIbMpo+TG17FOs0aDj+4HyustH6RFTBdXzfxcAvwBInC2u8snWSDaqB7F7emd5vsXvAoYCCDhshFweLq6ILsRrhzvYkvd2dVinOFXoPHeDflV6V0GAy6XCXhrUidZIvrVrlx2mPotygT4t9+158oNTkmLAZ8o/++RpEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791528935; c=relaxed/simple; bh=wrScaiao8aM1Apd+iV68JuZ4Yqy23EAz4nsNGL9lvAI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CiFmjRxqKRPaPgCyB8I5F/o/bWtrqzzeRSiDuCdX+Jaqynd5R9KdiR8k+p32dWTKqjFnNhKCR+5XG4uK36opHZn8ftahx1SoVt9q1kbGCC0TEBiOrmtjHiJYRB4KwAI8RvHPPrjBN3uo3P83bf+6Uj+kb4gB1IAepXSwS1VPtXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=egx6/31i; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="egx6/31i" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791528935; x=1823064935; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wrScaiao8aM1Apd+iV68JuZ4Yqy23EAz4nsNGL9lvAI=; b=egx6/31iuRhu9/hotoGS/u8bNVVDe4RMtawNkZcdHsPdtSgqdK/j4a4N 0B75L28LrsJs01MmsilTz8TYxHF1hbAnfrJTIR/WdB9oCEtjNGBSbT48R x2QjchYfA5zmtY7xW9jlZsAlwXJHGOQySVnsUi+PU71C1UFIAT65lNWBW a6zbhrCqaT4hMiqkbosd2vBPQaEVbWyEatdcZnXaTdQnF/VvkLeMMLm+v RCUY9NTsSikiVGEw+WcD7ynVziJ5Tzkuv+jRBciRthn0EjvBNb3+6S5K0 61AQgGHWshFmgFiSfUSquyHN6gbWv5YiDial3H+Tq+24Pa+eF8s4jQd6G w==; X-CSE-ConnectionGUID: MxmMVc6WTnOICGDd1+RJ4g== X-CSE-MsgGUID: TUxAMf87RH6Nng0nhy/8RQ== X-IronPort-AV: E=McAfee;i="6800,10657,11929"; a="221160" X-IronPort-AV: E=Sophos;i="6.27,147,1787036400"; d="scan'208";a="221160" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2026 23:52:46 -0700 X-CSE-ConnectionGUID: FAEFGBrfTCyKDWwun4N1GQ== X-CSE-MsgGUID: Ul4G+r1aS3qnZLOftFkeGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,147,1787036400"; d="scan'208";a="334648" Received: from lkp-server01.sh.intel.com (HELO 0caa9d2d175c) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 08 Oct 2026 23:52:41 -0700 Received: from kbuild by 0caa9d2d175c with local (Exim 4.98.2) (envelope-from ) id 1xF4T8-000000005QI-1e7X; Fri, 09 Oct 2026 06:52:38 +0000 Date: Fri, 9 Oct 2026 14:52:03 +0800 From: kernel test robot To: Jacky Chou , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Manivannan Sadhasivam , Ryan Chen , Billy Tsai Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jacky Chou Subject: Re: [PATCH 2/3] phy: aspeed: Add ASPEED PCIe PHY driver Message-ID: <202610091411.PPpH2lr3-lkp@intel.com> References: <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261008-aspeed_pcie_phy-v1-2-96764937aef0@aspeedtech.com> Hi Jacky, kernel test robot noticed the following build errors: [auto build test ERROR on ea01f446f0682a5e7bd7a275889a890b7e0c6e02] url: https://github.com/intel-lab-lkp/linux/commits/Jacky-Chou/dt-bindings-phy-aspeed-Add-ASPEED-PCIe-PHY/20261008-192819 base: ea01f446f0682a5e7bd7a275889a890b7e0c6e02 patch link: https://lore.kernel.org/r/20261008-aspeed_pcie_phy-v1-2-96764937aef0%40aspeedtech.com patch subject: [PATCH 2/3] phy: aspeed: Add ASPEED PCIe PHY driver config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261009/202610091411.PPpH2lr3-lkp@intel.com/config) compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 242243a5814307de825db3428662d67b064e2cbc) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261009/202610091411.PPpH2lr3-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202610091411.PPpH2lr3-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/phy/aspeed/phy-aspeed-pcie.c:73:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 73 | writel(PCIE_UNLOCK, pcie_phy->reg + PEHR_LOCK); | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:94:3: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 94 | writel(AST2600_PORT_TYPE(0x3), pcie_phy->reg + PEHR_GLOBAL); | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:94:10: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 94 | writel(AST2600_PORT_TYPE(0x3), pcie_phy->reg + PEHR_GLOBAL); | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:16:32: note: expanded from macro 'AST2600_PORT_TYPE' 16 | #define AST2600_PORT_TYPE(x) FIELD_PREP(AST2600_PORT_TYPE_MASK, x) | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:135:3: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 135 | writel(0, pcie_phy->reg + PEHR_MISC_278); | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:137:10: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 137 | writel(POSTED_DATA_CREDITS(0xc0) | POSTED_HEADER_CREDITS(0xa), | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:29:34: note: expanded from macro 'POSTED_DATA_CREDITS' 29 | #define POSTED_DATA_CREDITS(x) FIELD_PREP(GENMASK(15, 0), x) | ^ >> drivers/phy/aspeed/phy-aspeed-pcie.c:143:13: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 143 | cfg_val = readl(pcie_phy->reg + PEHR_MISC_60); | ^ drivers/phy/aspeed/phy-aspeed-pcie.c:144:3: error: call to undeclared function 'FIELD_MODIFY'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 144 | FIELD_MODIFY(AST2700_PORT_TYPE_MASK, &cfg_val, | ^ 7 errors generated. vim +/writel +73 drivers/phy/aspeed/phy-aspeed-pcie.c 63 64 static int ast2600_phy_init(struct phy *phy) 65 { 66 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 67 int ret; 68 69 ret = clk_prepare_enable(pcie_phy->clk); 70 if (ret) 71 return ret; 72 > 73 writel(PCIE_UNLOCK, pcie_phy->reg + PEHR_LOCK); 74 75 return 0; 76 } 77 78 static int ast2600_phy_exit(struct phy *phy) 79 { 80 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 81 82 clk_disable_unprepare(pcie_phy->clk); 83 84 return 0; 85 } 86 87 static int ast2600_phy_set_mode(struct phy *phy, enum phy_mode mode, 88 int submode) 89 { 90 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 91 92 switch (submode) { 93 case PHY_MODE_PCIE_RC: 94 writel(AST2600_PORT_TYPE(0x3), pcie_phy->reg + PEHR_GLOBAL); 95 break; 96 default: 97 dev_err(&phy->dev, "Unsupported submode %d\n", submode); 98 return -EINVAL; 99 } 100 101 return 0; 102 } 103 104 static const struct phy_ops ast2600_phy_ops = { 105 .init = ast2600_phy_init, 106 .exit = ast2600_phy_exit, 107 .set_mode = ast2600_phy_set_mode, 108 .owner = THIS_MODULE, 109 }; 110 111 static int ast2700_phy_init(struct phy *phy) 112 { 113 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 114 115 return clk_prepare_enable(pcie_phy->clk); 116 } 117 118 static int ast2700_phy_exit(struct phy *phy) 119 { 120 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 121 122 clk_disable_unprepare(pcie_phy->clk); 123 124 return 0; 125 } 126 127 static int ast2700_phy_set_mode(struct phy *phy, enum phy_mode mode, 128 int submode) 129 { 130 struct aspeed_pcie_phy *pcie_phy = phy_get_drvdata(phy); 131 u32 cfg_val; 132 133 switch (submode) { 134 case PHY_MODE_PCIE_RC: 135 writel(0, pcie_phy->reg + PEHR_MISC_278); 136 writel(SEL_INTERNAL_RESET, pcie_phy->reg + PEHR_MISC_280); 137 writel(POSTED_DATA_CREDITS(0xc0) | POSTED_HEADER_CREDITS(0xa), 138 pcie_phy->reg + PEHR_MISC_70); 139 writel(COMPLETION_DATA_CREDITS(0x30) | COMPLETION_HEADER_CREDITS(0x8), 140 pcie_phy->reg + PEHR_MISC_78); 141 writel(LOCAL_SCALE_SUP, pcie_phy->reg + PEHR_MISC_58); 142 writel(CONFIG_RC_DEVICE, pcie_phy->reg + PEHR_MISC_5C); > 143 cfg_val = readl(pcie_phy->reg + PEHR_MISC_60); 144 FIELD_MODIFY(AST2700_PORT_TYPE_MASK, &cfg_val, 145 PORT_TYPE_ROOT); 146 writel(cfg_val, pcie_phy->reg + PEHR_MISC_60); 147 writel(ASSERT_INTERNAL_RESET | SET_TO_DOWNSTREAM, 148 pcie_phy->reg + PEHR_MISC_278); 149 break; 150 default: 151 dev_err(&phy->dev, "Unsupported submode %d\n", submode); 152 return -EINVAL; 153 } 154 155 return 0; 156 } 157 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki