Re: [PATCH v3 1/4] ASoC: dt-bindings: Add Cadence I2S-SC controller

[Rob Herring <robh@kernel.org>]

On Fri, Oct 09, 2026 at 09:32:13AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: loose schema constraint on dma-names allows invalid configurations
> --
> 
> commit 41d6caf5f15433436b2c0289025efcf429404414
> Author: Joakim Zhang <joakim.zhang@cixtech.com>
> 
> ASoC: dt-bindings: Add Cadence I2S-SC controller
>     
> Add the DT binding for the Cadence I2S-SC controller integrated in
> the CIX SKY1 audio subsystem. I2S-SC is a full-duplex stereo
> controller supporting standard I2S, left/right-justified and DSP
> formats, plus TDM operation with up to 16 slots.
> 
> > diff --git a/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml b/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> > new file mode 100644
> > index 0000000000000..3fdf2334c4926
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/cix,sky1-i2s-sc.yaml
> 
> [ ... ]
> 
> > +  dmas:
> > +    minItems: 1
> > +    maxItems: 2
> > +    description:
> > +      One DMA channel for instances wired for a single direction, either
> > +      "tx" or "rx", or two channels for both transmit and receive.
> > +
> > +  dma-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      enum: [ tx, rx ]
> 
> [Severity: Low]
> Does this schema definition permit invalid DMA combinations? 
> 
> Because items is set to just an enum, this allows combinations like ["tx", "tx"],
> ["rx", "rx"], or out-of-order configurations like ["rx", "tx"] to silently pass
> validation.

Yes, normally that is prevented, but IIRC there's a binding that needed 
something like this.

minItems: 1
uniqueItems: true
items:
  - enum: [ tx, rx ]
  - const: tx

Then when both are there the order is enforced.

Rob