Re: [PATCH v3 2/2] ASoC: airoha: Add support for AN7581 PCM driver

[kernel test robot <lkp@intel.com>]

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on next-20261008]
[cannot apply to linus/master v7.3-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/ASoC-dt-bindings-airoha-Add-AN7581-PCM-controller/20261009-131331
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20261009111334.23522-3-ansuelsmth%40gmail.com
patch subject: [PATCH v3 2/2] ASoC: airoha: Add support for AN7581 PCM driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20261010/202610101205.hqe234SY-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261010/202610101205.hqe234SY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610101205.hqe234SY-lkp@intel.com/

All warnings (new ones prefixed by >>):

   sound/soc/airoha/an7581-pcm.c:618:10: error: 'const struct snd_soc_component_driver' has no member named 'pcm_construct'
     618 |         .pcm_construct = an7581_pcm_new,
         |          ^~~~~~~~~~~~~
   sound/soc/airoha/an7581-pcm.c:618:26: error: initialization of 'int (*)(struct snd_soc_component *, struct snd_pcm_substream *, struct timespec64 *, struct timespec64 *, struct snd_pcm_audio_tstamp_config *, struct snd_pcm_audio_tstamp_report *)' from incompatible pointer type 'int (*)(struct snd_soc_component *, struct snd_soc_pcm_runtime *)' [-Wincompatible-pointer-types]
     618 |         .pcm_construct = an7581_pcm_new,
         |                          ^~~~~~~~~~~~~~
   sound/soc/airoha/an7581-pcm.c:618:26: note: (near initialization for 'an7581_pcm_platform.get_time_info')
   sound/soc/airoha/an7581-pcm.c:603:12: note: 'an7581_pcm_new' declared here
     603 | static int an7581_pcm_new(struct snd_soc_component *component,
         |            ^~~~~~~~~~~~~~
   sound/soc/airoha/an7581-pcm.c: In function 'an7581_pcm_probe':
>> sound/soc/airoha/an7581-pcm.c:778:21: warning: unused variable 'connection_type' [-Wunused-variable]
     778 |         const char *connection_type;
         |                     ^~~~~~~~~~~~~~~


vim +/connection_type +778 sound/soc/airoha/an7581-pcm.c

   771	
   772	static int an7581_pcm_probe(struct platform_device *pdev)
   773	{
   774		struct snd_soc_card *card = &an7581_pcm_card;
   775		struct snd_soc_dai_link *dai_link;
   776		struct device *dev = &pdev->dev;
   777		struct an7581_pcm_priv *priv;
 > 778		const char *connection_type;
   779		int irq;
   780		int ret;
   781		int i;
   782	
   783		card->dev = dev;
   784	
   785		priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
   786		if (!priv)
   787			return -ENOMEM;
   788		snd_soc_card_set_drvdata(card, priv);
   789	
   790		priv->map = device_node_to_regmap(dev->of_node);
   791		if (IS_ERR(priv->map))
   792			return PTR_ERR(priv->map);
   793	
   794		priv->reset = devm_reset_control_get_exclusive(dev, "pcm1");
   795		if (IS_ERR(priv->reset))
   796			return PTR_ERR(priv->reset);
   797	
   798		irq = of_irq_get(dev_of_node(dev), 0);
   799		if (irq < 0)
   800			return irq;
   801	
   802		ret = devm_request_threaded_irq(dev, irq, an7581_pcm_irq_handler,
   803						NULL, IRQF_ONESHOT, dev_name(dev), priv);
   804		if (ret)
   805			return ret;
   806	
   807		spin_lock_init(&priv->desc_lock);
   808		mutex_init(&priv->user_lock);
   809	
   810		/* Reset the PCM interface */
   811		reset_control_assert(priv->reset);
   812		usleep_range(5000, 10000);
   813		reset_control_deassert(priv->reset);
   814		usleep_range(5000, 10000);
   815	
   816		ret = dma_set_mask(dev, DMA_BIT_MASK(32));
   817		if (ret)
   818			return ret;
   819	
   820		priv->tx_descs = dma_alloc_coherent(dev, sizeof(struct an7581_pcm_desc) *
   821						    AN7581_PCM_TX_DESCRIPTORS, &priv->tx_dma,
   822						    GFP_KERNEL);
   823		if (!priv->tx_descs)
   824			return -ENOMEM;
   825	
   826		priv->rx_descs = dma_alloc_coherent(dev, sizeof(struct an7581_pcm_desc) *
   827						    AN7581_PCM_RX_DESCRIPTORS, &priv->rx_dma,
   828						    GFP_KERNEL);
   829		if (!priv->rx_descs) {
   830			ret = -ENOMEM;
   831			goto err_free_tx;
   832		}
   833	
   834		for_each_card_prelinks(card, i, dai_link)
   835			dai_link->platforms->of_node = dev->of_node;
   836	
   837		ret = devm_snd_soc_register_component(dev,
   838						      &an7581_pcm_platform,
   839						      NULL, 0);
   840		if (ret) {
   841			dev_err_probe(dev, ret, "Cannot register PCM component\n");
   842			goto err_free_rx;
   843		}
   844	
   845		ret = devm_snd_soc_register_component(dev,
   846						      &an7581_pcm_dai_component,
   847						      an7581_pcm_dai_driver,
   848						      ARRAY_SIZE(an7581_pcm_dai_driver));
   849		if (ret) {
   850			dev_err_probe(dev, ret, "Cannot register PCM DAI component\n");
   851			goto err_free_rx;
   852		}
   853	
   854		ret = devm_snd_soc_register_card(dev, card);
   855		if (ret) {
   856			dev_err_probe(dev, ret, "%s snd_soc_register_card fail\n", __func__);
   857			goto err_free_rx;
   858		}
   859	
   860		return 0;
   861	
   862	err_free_rx:
   863		dma_free_coherent(dev, sizeof(struct an7581_pcm_desc) *
   864				  AN7581_PCM_RX_DESCRIPTORS, priv->rx_descs, priv->rx_dma);
   865	err_free_tx:
   866		dma_free_coherent(dev, sizeof(struct an7581_pcm_desc) *
   867				  AN7581_PCM_TX_DESCRIPTORS, priv->tx_descs, priv->tx_dma);
   868	
   869		return ret;
   870	}
   871	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki