Re: [PATCH v2 4/6] dt-bindings: dma: arm,dma-350: Document the CIX Sky1 integration

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]

On Sat, Oct 10, 2026 at 06:23:27PM +0800, Jelly Jia wrote:
> On Fri, Oct 09, 2026 at 04:31:26PM +0100, Conor Dooley wrote:
> > > +  cix,irq-router:
> > > +    $ref: /schemas/types.yaml#/definitions/phandle
> > > +    description:
> > > +      Syscon phandle for the CIX Sky1 subsystem register block that routes
> > > +      DMA-350 channel interrupts to the AP interrupt controller.
> >
> > See comments on the driver for more on this, but I'm not convinced that
> > this should be in this node - especially if this thing controls other
> > device's routing too.
> >
> > Thanks,
> > Conor.
> 
> Agreed - v3 drops cix,irq-router from the binding completely. We plan
> to handle the interrupt gate as firmware/pre-Linux platform setup for
> v3, so the DMA node should not describe it. With the property gone, the
> CIX-specific conditional in allOf goes away as well, and the binding is
> back to the generic controller properties plus the CIX compatible. The
> corresponding driver changes are in my reply on the driver patch.

For correctness, I think you still need to model this by using interrupt-map
in the syscon node, with the syscon as the interrupt parent. If firmware
will program it, you don't need to actually implement anything in a
linux driver (unlike the Microchip and Renesas devices that I linked),
you just need to put the interrupt-map property in the syscon and common
code will do the rest.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]