From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: crypto: Adjust Shikra compatible hierarchy
Date: Tue, 13 Oct 2026 08:44:49 +0200 [thread overview]
Message-ID: <20261013-pastoral-magic-perch-1a2e5a@quoll> (raw)
In-Reply-To: <20261006-shikra_qce_fix-v1-1-8ac54d81edb4@oss.qualcomm.com>
On Tue, Oct 06, 2026 at 04:44:03PM +0530, Kuldeep Singh wrote:
> Shikra reuses the same QCE integration as Agatti and should follow the
`git grep Agatti` gives zero.
> corresponding binding requirements too.
>
> Move the Shikra compatible to the appropriate binding hierarchy
> (matching qcom,qcm2290-qce) to reflect the underlying hardware
> description.
You do not change any binding hierarchy. You are changing fallback
compatible which is ABI break without any reason.
>
> Fixes: 45834ff95a6f ("dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Drop, that's v1, so this likely did not happen. Anyway, your SoB is
supposed to be last.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-13 6:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 11:14 [PATCH 0/2] Shikra: Fix qce configuration Kuldeep Singh
2026-10-06 11:14 ` [PATCH 1/2] dt-bindings: crypto: Adjust Shikra compatible hierarchy Kuldeep Singh
2026-10-13 6:44 ` Krzysztof Kozlowski [this message]
2026-10-16 12:10 ` Kuldeep Singh
2026-10-06 11:14 ` [PATCH 2/2] arm64: dts: qcom: shikra: Correct QCE node configuration Kuldeep Singh
2026-10-16 12:31 ` Konrad Dybcio
2026-10-16 12:52 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013-pastoral-magic-perch-1a2e5a@quoll \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox