From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466C451E432 for ; Wed, 14 Oct 2026 13:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984213; cv=none; b=H/WWIH2L4CruUVQRhEh/jUQ/P7z2mKSeaD+wwZVkEUFW+1cUCpGE5uwAKs8Q7pJGbCXkDSDlTJbP0D8iq+NhSFlw3VUvlp8YQgPKrgAodc12sSILGdL8quGsV20pZVaPAJCOpgkVUJGenRWgoZyO0nTc57LP4SzkUwlVH5CVmLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984213; c=relaxed/simple; bh=vHlNApf1n0eU2OktVinpI4zv/MZunnjQ95s6jli1xzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GFx5WWW2BTwJ4WDXKJla/wij2M3Mm1fAdBrNSvYeGw+Udxk3qub12vk6r61PKCGwz6JVzFOcegC7jQw88aa8qmlaJ51ZN+IwU1AffCqzchB6xbr5b3WaDqiqgIKQl2p9nQY9E4FkjFpty27D/Gwn16inyachEezD2IkIQda25u4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSAuN/BQ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSAuN/BQ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so12477065e9.0 for ; Wed, 14 Oct 2026 06:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791984206; x=1792589006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=eSAuN/BQJo2nCqQLjw+pMDp7TroyRIUh+tG2RNt+y5srWj/0zFtSD++KkSyhc02vvc mCKQjPKqgWZk0vdxuoncN3EZU6PNpLHRUfXKwQ9Y2DBSqiqnaw8wVgyStiEWcmOcM3NN hh08pFqprCRzonKlZ7QEuIcU8C0opY7TWJlBU1dgCTA54/A7KXRLPEQSwKIpNnTCNSi1 NFw6wNNBHkwipQdDOWbgMd0qH93Q0tjg/9drwaY6u48xOTYlB/mgfxrSuksz6KzAbwal vsANlIkHCUO5p7SdGQ3MagGK2VyzuUBNcrVpf9amwnD6OjLxaguOfGKEfmsS7yuSIYVb 8hyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791984206; x=1792589006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=K6bS10zR28v8k46xYarJhVFSl/qil7iS/LBIu2/+ne1lCg+qRXGQcn2gmRRBDUN1Zn 2uBJSsEC5PTMN1rivXIL14CiZ8RupgR62HFxtgKiedgoalecGmCFW8wTMJmh1TEgEyqA 2J8RM7dHoPGx58zoldRN+cKpDKGPQkp6QiPLFy5turBErHBr+lhzeHJMI2jGPzzg/p14 lKZg2xWSh4Ag7x9oKaxV53XFtg+WEFYrE88f1VKuRKfu7w0e0yRUdNPCCGFaRZ3hfs5g guH5ngSRsCZVNcsFT+OVvvVsMttjQTXcP6b1CK89DgH3YnXiZ2LC1UrE3BTvcDWiAmK8 fe/g== X-Forwarded-Encrypted: i=1; AKwUvBwegrZh3T90r5uwr9z62hbOIyQXbkc2Edv8nt9s3AyN0XKKlYKFKfzL8xX4DnRLnToBMm7kvgWxt9sU@vger.kernel.org X-Gm-Message-State: AFq9FYIg13cqWuetsYGOQK1DSsR2vtEBzzPStW2RsKD/P4Ih7S2KZpjE y07vLaoFEgk1rtTs2O9ltiMQGRnkvKzOPgp0YIuEwXvJo5xPWXOAki85 X-Gm-Gg: AYBFou0y8eJGqDgaXIaiqpWOA08q+ETGEKzoX1ui/AzpFIxGrFmr3TXl5XxBPAW1KQg uOf1sMMKd5GczKHGgBoLHWwIz/7IDXKQQrusRu5nKVJ64fq7bxRw+Mqif20Y2sqLpQM3PMOCiXl n7EG4DscVFaIK95hDpEZVWrvX9rXWkiMumrNpYtgnhEqbLiiaTLIF7Ual/WwPx4fTjAF6pj3dGI 6evWDHvD3TBWFF6zy1XvSEIPuSG1nUHUwi9ytsEqMDGXOurY4aXV1Gk0mjU4bIg72fjxeaSbg2I u8j1RXLQMIACBFyurNdcyb0cYOTezjawZruxJpqznXpX3Ozob9wCQmDlRdLm4kGTA2agMYXOtZk mmmX0z9tBcoV4eGKmS9WGHmzYuhX7MODfqGbLKFX6CizfoLezKLwgLX55rW/3JfNl4o6/4NNw0n 00eWHkpt+PsBHuU7h/zkC3zCC5Sm5taifbVbodGt5cX49BJmKkydS+VGmsk0EJh7p7DpNaadKqJ yDLjBeB6B/KqA== X-Received: by 2002:a05:600c:5489:b0:4a0:1c94:7042 with SMTP id 5b1f17b1804b1-4a18e4a5244mr306911845e9.8.1791984206139; Wed, 14 Oct 2026 06:23:26 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1bcf69402sm782515e9.14.2026.10.14.06.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 06:23:25 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bryan O'Donoghue , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, Konrad Dybcio , Abel Vesa Subject: [PATCH v6 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Wed, 14 Oct 2026 15:23:15 +0200 Message-ID: <20261014132315.4659-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261014132315.4659-1-okerixx@gmail.com> References: <20261014132315.4659-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri Reviewed-by: Konrad Dybcio Reviewed-by: Abel Vesa --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { status = "okay"; - /* EC @ 0x70, irq = TLMM 66 */ + embedded-controller@70 { + compatible = "lenovo,yoga-slim7x-gen11-ec"; + reg = <0x70>; + + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 = <&ec_int_n_default>; + pinctrl-names = "default"; + }; }; &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins = "gpio66"; function = "gpio"; - bias-disable; + bias-pull-up; }; kybd_default: kybd-default-state { -- 2.55.0