Re: [PATCH 1/2] ASoC: dt-bindings: Add Iron Device MA5311

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Oct 15, 2026 at 03:04:06PM +0900, Hyunuk Son wrote:
> Add a Device Tree binding for the Iron Device MA5311
> audio codec.
> 
> The binding describes the properties required to identify
> the codec and configure its connections to the host audio
> controller.

Drpo, obvious. Explain the hardware.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Hyunuk Son <hyunuk.son@irondevice.com>
> ---
>  .../bindings/sound/irondevice,ma5311.yaml     | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml b/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml
> new file mode 100644
> index 000000000..ae4a13c29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/irondevice,ma5311.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/irondevice,ma5311.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Iron Device MA5311 Audio Codec
> +
> +maintainers:
> +  - Hyunuk Son <hyunuk.son@irondevice.com>
> +
> +description:
> +  The MA5311 is an audio device providing digital speaker amplification,
> +  analog input conversion, and audio DSP functionality.
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - irondevice,ma5311
> +    description:
> +      Requires two I2C Channel.

Not sure what is I2C channel... like two SDA/SCL lines? Anyway, this
goes to description.

> +
> +  reg:
> +    items:
> +      - description: I2C address for control registers
> +      - description: I2C address for ADC registers
> +
> +  reg-names:
> +    items:
> +      - const: control
> +      - const: adc
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO connected to the active-low RSTN pin.
> +
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Interrupt from the active-low INTN fault and thermal warning output.
> +
> +  '#sound-dai-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - '#sound-dai-cells'
> +
> +additionalProperties: false

unevaluatedProperties instead


> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        audio-codec@3e {
> +            compatible = "irondevice,ma5311";
> +            reg = <0x3e>, <0x3f>;
> +            #sound-dai-cells = <1>;
> +            reg-names = "control", "adc";

Make the example complete.


Best regards,
Krzysztof