Re: [PATCH net-next v2 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link node

[kernel test robot <lkp@intel.com>]

Hi Claudiu,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Claudiu-Manoil/net-enetc-Add-pseudo-MAC-support-for-ENETCv4-Ports-via-a-fixed-link-node/20261013-201245
base:   net-next/main
patch link:    https://lore.kernel.org/r/d7b51cb29758538a4c68a700dd8cd41b6e7e08b6.1791908694.git.claudiu.manoil%40nxp.com
patch subject: [PATCH net-next v2 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link node
config: x86_64-buildonly-randconfig-1004-20261015 (https://download.01.org/0day-ci/archive/20261015/202610151650.UHqL0Sb7-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261015/202610151650.UHqL0Sb7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610151650.UHqL0Sb7-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:963:2: error: call to undeclared function 'of_changeset_revert'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     963 |         of_changeset_revert(priv->ppm_ocs);
         |         ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:964:2: error: call to undeclared function 'of_changeset_destroy'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     964 |         of_changeset_destroy(priv->ppm_ocs);
         |         ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:992:2: error: call to undeclared function 'of_changeset_init'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     992 |         of_changeset_init(ocs);
         |         ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:994:15: error: call to undeclared function 'of_changeset_create_node'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     994 |         fixed_link = of_changeset_create_node(ocs, np, "fixed-link");
         |                      ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:994:13: error: incompatible integer to pointer conversion assigning to 'struct device_node *' from 'int' [-Wint-conversion]
     994 |         fixed_link = of_changeset_create_node(ocs, np, "fixed-link");
         |                    ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:1000:8: error: call to undeclared function 'of_changeset_add_prop_u32'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1000 |         err = of_changeset_add_prop_u32(ocs, fixed_link, "speed", speed);
         |               ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:1004:8: error: call to undeclared function 'of_changeset_add_prop_bool'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1004 |         err = of_changeset_add_prop_bool(ocs, fixed_link, "full-duplex");
         |               ^
>> drivers/net/ethernet/freescale/enetc/enetc4_pf.c:1008:8: error: call to undeclared function 'of_changeset_apply'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1008 |         err = of_changeset_apply(ocs);
         |               ^
   drivers/net/ethernet/freescale/enetc/enetc4_pf.c:1020:2: error: call to undeclared function 'of_changeset_destroy'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1020 |         of_changeset_destroy(ocs);
         |         ^
   9 errors generated.


vim +/of_changeset_revert +963 drivers/net/ethernet/freescale/enetc/enetc4_pf.c

   957	
   958	static void enetc4_put_ppm_fixed_link(struct enetc_ndev_priv *priv)
   959	{
   960		if (!priv->ppm_ocs)
   961			return;
   962	
 > 963		of_changeset_revert(priv->ppm_ocs);
 > 964		of_changeset_destroy(priv->ppm_ocs);
   965		kfree(priv->ppm_ocs);
   966		priv->ppm_ocs = NULL;
   967	}
   968	
   969	/* Pseudo-MAC ports have no real PHY; the link is fixed, with the operating
   970	 * speed set at probe time from PCR[PSPEED]. Describe this with a fixed-link
   971	 * subnode synthesized at runtime onto the port's own OF node, so phylink
   972	 * picks it up through dev_fwnode() exactly as if it came from static DT.
   973	 */
   974	static int enetc4_add_ppm_fixed_link(struct enetc_ndev_priv *priv)
   975	{
   976		struct device_node *np = dev_of_node(priv->dev);
   977		struct device_node *fixed_link;
   978		struct of_changeset *ocs;
   979		int speed, err;
   980	
   981		if (!np)
   982			return dev_err_probe(priv->dev, -ENODEV,
   983					     "Missing of_node for Pseudo-MAC port\n");
   984	
   985		enetc4_get_pcr_speed(&priv->si->hw, &speed);
   986		speed = enetc_phylink_match_pseudo_mac_speed(speed);
   987	
   988		ocs = kzalloc_obj(*ocs);
   989		if (!ocs)
   990			return -ENOMEM;
   991	
 > 992		of_changeset_init(ocs);
   993	
 > 994		fixed_link = of_changeset_create_node(ocs, np, "fixed-link");
   995		if (!fixed_link) {
   996			err = -ENOMEM;
   997			goto err_destroy;
   998		}
   999	
> 1000		err = of_changeset_add_prop_u32(ocs, fixed_link, "speed", speed);
  1001		if (err)
  1002			goto err_put_node;
  1003	
> 1004		err = of_changeset_add_prop_bool(ocs, fixed_link, "full-duplex");
  1005		if (err)
  1006			goto err_put_node;
  1007	
> 1008		err = of_changeset_apply(ocs);
  1009		if (err)
  1010			goto err_put_node;
  1011	
  1012		of_node_put(fixed_link);
  1013		priv->ppm_ocs = ocs;
  1014	
  1015		return 0;
  1016	
  1017	err_put_node:
  1018		of_node_put(fixed_link);
  1019	err_destroy:
  1020		of_changeset_destroy(ocs);
  1021		kfree(ocs);
  1022	
  1023		return dev_err_probe(priv->dev, err,
  1024				     "Failed to add fixed-link node\n");
  1025	}
  1026	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki