Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies

[Rob Herring <robh@kernel.org>]

On Mon, Sep 21, 2026 at 11:34:22PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dt-bindings: unintended schema relaxation for qcom,ipq5210-qusb2-phy
> --
> 
> commit 69ee638f4004f6e325a963f3b804b3c1cac5c6fb
> Author: Rob Herring (Arm) <robh@kernel.org>
> 
> dt-bindings: phy: qcom: Relax required supplies
> 
> This commit relaxes the requirement for three regulator supplies in the QUSB2
> PHY binding for legacy IPQ6018 nodes that do not describe board rails.
> 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> > index 001fd0ccc9852..2516eab7f6d32 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> [ ... ]
> >  allOf:
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum: 
> > +                - qcom,ipq6018-qusb2-phy
> > +                - qcom,ipq8074-qusb2-phy
> 
> [Severity: Medium]
> Does this unintentionally relax the schema requirements for IPQ5210?

Yes.

> Since qcom,ipq5210-qusb2-phy falls back to qcom,ipq6018-qusb2-phy, an IPQ5210
> device tree node's compatible array will contain qcom,ipq6018-qusb2-phy.
> 
> The 'contains: enum' logic matches this fallback, which seems like it might
> incorrectly apply this legacy IPQ6018 exemption to IPQ5210 nodes, allowing
> them to silently pass schema validation without the required regulator
> supplies.
> 
> > +    then:
> > +      required:
> > +        - vdd-supply
> > +        - vdda-pll-supply
> > +        - vdda-phy-dpdm-supply

If these are compatible with ipq5210, they can't really have more 
constraints than it.

Rob