Devicetree
 help / color / mirror / Atom feed
From: Frank.Li@oss.nxp.com
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christoph Niedermaier <cniedermaier@dh-electronics.com>,
	Marek Vasut <marex@nabladev.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>,
	Frank Li <Frank.Li@nxp.com>,
	Ashish Yadav <ashish.yadav@infineon.com>,
	Colin Huang <u8813345@gmail.com>,
	Sanman Pradhan <psanman@juniper.net>,
	Thorsten Blum <blum@kernel.org>,
	Troy Mitchell <troy.mitchell@linux.dev>,
	Eddie James <eajames@linux.ibm.com>,
	Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
	linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM),
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	kernel@dh-electronics.com (open list:DH ELECTRONICS DHSOM SOM
	AND BOARD SUPPORT), linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev
Subject: [PATCH 1/1] dt-bindings: spi: Add separate binding for dh,dhcom-board
Date: Fri, 16 Oct 2026 16:57:14 -0400	[thread overview]
Message-ID: <20261016205718.877668-1-Frank.Li@oss.nxp.com> (raw)

From: Frank Li <Frank.Li@nxp.com>

The dh,dhcom-board SPI device uses spi-cpha and spi-cpol properties,
which are not permitted by the trivial-devices schema. Move it to a
dedicated binding file that references spi-peripheral-props.yaml and
explicitly allows those SPI mode properties.

Fixes below CHECK_DTBS warnings:
  arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dtb: spidev@0 (dh,dhcom-board): 'spi-cpha', 'spi-cpol' do not match any of the regexes: '^pinctrl-[0-9]+$'
        from schema $id: http://devicetree.org/schemas/trivial-devices.yaml

Assisted-by: LLM
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/spi/dh,dhcom-board.yaml          | 46 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  2 -
 2 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml

diff --git a/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
new file mode 100644
index 0000000000000..ed213cbe9b04c
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/dh,dhcom-board.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/dh,dhcom-board.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DH electronics GmbH on-board CPLD trivial SPI device
+
+maintainers:
+  - Marek Vasut <marex@denx.de>
+  - Frank Li <Frank.Li@nxp.com>
+
+allOf:
+  - $ref: spi-peripheral-props.yaml
+
+properties:
+  compatible:
+    const: dh,dhcom-board
+
+  reg:
+    maxItems: 1
+
+  spi-cpha: true
+
+  spi-cpol: true
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        cpld@0 {
+            compatible = "dh,dhcom-board";
+            reg = <0>;
+            spi-max-frequency = <1000000>;
+            spi-cpol;
+            spi-cpha;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index a8b2b9deade4c..f3099e55b6f5a 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -119,8 +119,6 @@ properties:
           - devantech,srf10
             # DFRobot SEN0322 oxygen sensor
           - dfrobot,sen0322
-            # DH electronics GmbH on-board CPLD trivial SPI device
-          - dh,dhcom-board
             # DA9053: flexible system level PMIC with multicore support
           - dlg,da9053
             # DMARD05: 3-axis I2C Accelerometer
-- 
2.43.0


             reply	other threads:[~2026-10-16 20:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 20:57 Frank.Li [this message]
2026-10-16 22:01 ` [PATCH 1/1] dt-bindings: spi: Add separate binding for dh,dhcom-board Marek Vasut
2026-10-18 19:37   ` Conor Dooley
2026-10-18 21:38     ` Marek Vasut
2026-10-19 18:23       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016205718.877668-1-Frank.Li@oss.nxp.com \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=ashish.yadav@infineon.com \
    --cc=blum@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cniedermaier@dh-electronics.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.ibm.com \
    --cc=imx@lists.linux.dev \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kernel@dh-electronics.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@nabladev.com \
    --cc=psanman@juniper.net \
    --cc=robh@kernel.org \
    --cc=rodrigo.gobbi.7@gmail.com \
    --cc=troy.mitchell@linux.dev \
    --cc=u8813345@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox