Devicetree
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Bryan O'Donoghue <bod@kernel.org>, George Neacsu <geocausa@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	German Pablo Lindo <germanpapulindez@gmail.com>,
	Simon Kruse <simon0x+git@proton.me>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] media: i2c: ov13858: Add device tree support
Date: Fri, 16 Oct 2026 21:08:13 +0000	[thread overview]
Message-ID: <20261016210802.60605-1-lsa.uz@pm.me> (raw)
In-Reply-To: <711e8518-5054-49ab-8432-346049a86cd1@kernel.org>

Hi Bryan, George,

On 16/10/2026 21:43, Bryan O'Donoghue wrote:
> b4 prep --edit-deps   # add: message-id:
> <20260831130312.26296-1-lsa.uz@pm.me>

Please make that v4:
https://lore.kernel.org/all/20261016210246.58562-1-lsa.uz@pm.me/

The suspend test George asked for found one thing in v3. On the Intel
model a system suspend during a stream is refused by the ISYS (intel-ipu6
driver), as isys_suspend() returns -EBUSY while a stream is open. But
DEFINE_RUNTIME_DEV_PM_OPS() gives the driver system sleep handlers, so
pm_runtime_force_suspend() powered the sensor off before that refusal
(ftrace), pm_runtime_force_resume() powered it back without the stream,
and the stream stalled until restarted. v4 has runtime PM ops only, as
camera-sensor.rst asks of sensor drivers: the same refused suspend
reaches no ov13858 callback, and the stream completes all 900 frames.

Otherwise both behave the same here: 20 runtime PM cycles each, and two
s2idle suspends with the camera idle, after which the sensor streams
4224x3136 at 29.95 fps and v4l2-compliance passes 46 of 46. A suspend
that completes during a stream, as it may with CAMSS, cannot happen here.
v4 keeps v3's Tested-by from German and Simon.

Sergey


  reply	other threads:[~2026-10-16 21:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 21:48 [PATCH 0/2] media: ov13858: device tree support for the Surface Pro 11 (Snapdragon) George Neacsu via B4 Relay
2026-10-15 21:48 ` [PATCH 1/2] dt-bindings: media: i2c: Add OmniVision OV13858 George Neacsu via B4 Relay
2026-10-16 20:49   ` Bryan O'Donoghue
2026-10-15 21:48 ` [PATCH 2/2] media: i2c: ov13858: Add device tree support George Neacsu via B4 Relay
2026-10-16 16:06   ` Bryan O'Donoghue
2026-10-16 16:16     ` George Neacsu
2026-10-16 20:43       ` Bryan O'Donoghue
2026-10-16 21:08         ` Sergey Lebedev [this message]
2026-10-16 21:48           ` George Neacsu
2026-10-16 22:25           ` George Neacsu
2026-10-16  7:01 ` [PATCH 0/2] media: ov13858: device tree support for the Surface Pro 11 (Snapdragon) Sergey Lebedev
2026-10-16 14:55   ` George Neacsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016210802.60605-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=bod@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geocausa@gmail.com \
    --cc=germanpapulindez@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=simon0x+git@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox