From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-mips@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Eric Biggers <ebiggers@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mingyu Wang <25181214217@stu.xidian.edu.cn>,
Robert Marko <robert.marko@sartura.hr>,
linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE
DRIVERS),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
manuel.lauss@gmail.com
Subject: [PATCH 3/5] watchdog: gpio: Support watchdogs with a minimum heartbeat interval
Date: Fri, 16 Oct 2026 15:16:15 -0700 [thread overview]
Message-ID: <20261016221617.2223004-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20261016221617.2223004-1-f.fainelli@gmail.com>
Read the optional hw-min-interval-ms property into min_hw_heartbeat_ms so
the watchdog core defers keepalives that would toggle the GPIO too soon.
Reject zero intervals and intervals at or above the hardware margin.
Devices without the property retain their existing behavior.
Remove the arbitrary 65535 ms upper bound on hw_margin_ms as well. There
is no register width to constrain this software interval, and the MTX-1
watchdog needs a larger margin with a 1600 ms minimum ping interval.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/watchdog/gpio_wdt.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c
index ff323d6e692e..a431c77fa179 100644
--- a/drivers/watchdog/gpio_wdt.c
+++ b/drivers/watchdog/gpio_wdt.c
@@ -138,10 +138,20 @@ static int gpio_wdt_probe(struct platform_device *pdev)
ret = device_property_read_u32(dev, "hw_margin_ms", &hw_margin);
if (ret)
return ret;
- /* Disallow values lower than 2 and higher than 65535 ms */
- if (hw_margin < 2 || hw_margin > 65535)
+ /* The core feeds the watchdog at half the hardware margin. */
+ if (hw_margin < 2)
return -EINVAL;
+ if (device_property_present(dev, "hw-min-interval-ms")) {
+ ret = device_property_read_u32(dev, "hw-min-interval-ms",
+ &priv->wdd.min_hw_heartbeat_ms);
+ if (ret)
+ return ret;
+ if (!priv->wdd.min_hw_heartbeat_ms ||
+ priv->wdd.min_hw_heartbeat_ms >= hw_margin)
+ return -EINVAL;
+ }
+
priv->always_running = device_property_read_bool(dev, "always-running");
watchdog_set_drvdata(&priv->wdd, priv);
--
2.53.0
next prev parent reply other threads:[~2026-10-16 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 22:16 [PATCH 0/5] MTX-1 watchdog driver removal Florian Fainelli
2026-10-16 22:16 ` [PATCH 1/5] watchdog: gpio: Allow devices described by software nodes Florian Fainelli
2026-10-16 22:16 ` [PATCH 2/5] dt-bindings: watchdog: gpio: Describe minimum heartbeat intervals Florian Fainelli
2026-10-16 22:16 ` Florian Fainelli [this message]
2026-10-16 22:16 ` [PATCH 4/5] MIPS: Alchemy: Use the GPIO watchdog driver on MTX-1 Florian Fainelli
2026-10-16 22:16 ` [PATCH 5/5] watchdog: Remove the MTX-1 watchdog driver Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016221617.2223004-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=25181214217@stu.xidian.edu.cn \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiggers@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manuel.lauss@gmail.com \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox