From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327BB33ADA0 for ; Sat, 17 Oct 2026 10:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792231952; cv=none; b=jl5kG35kF5beyHFG1lUAYpwKHarHJF6d9jXiVXVMyBpuTDZe23YwrbD4Szo08uoR4dtbk5Dt8FN/++2Jb/GoGCyxoLYn8LJ0sWZ4VPR6v3X21rBOMO30Qz3WtMbreHA3kj/bmV1N+Pj7gMtOyxa9ILpaIsgbwG0KpPL7gx924y8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792231952; c=relaxed/simple; bh=qzvrrLy2qj+cZQoZi4u9ExBicE4rIpxnRBO9CfMg51g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WNHzGxKbDqwmL2hQV12EUMWdeRu8Xj/kEfnGfvTE9e44lkOjTP9jo52fqbXwUhhcMFGHOl/G7aAamNhe6pIsxkAxnbnxN3HQR9krgEmDxgGCePnF6mt7rfdATq//v9PHLQPPGL0bCoSHlbqSeSQequVOKOtA7MT/j6p74JBfdts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NC4AEspa; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NC4AEspa" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-48e0d885929so95770f8f.3 for ; Sat, 17 Oct 2026 03:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792231949; x=1792836749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dKoUY67/0brH9PfrEtDz8lEuDjVGpCp9GkyhQChz7oI=; b=NC4AEspaLZ0jkCIpN6Uk3ZRdt+4i7DlqAmAQ1r0JyKUZlNTH/uOHj8hWMewDJt57s+ xwrGpxlFXIc5l+wn7Wf8AvsKPKzg/qvKGzAQ4jXGV3FWAT2RxJTdSBtjYTjTcoCBW+FC eESeNMxGDzKm7iMAs6FlcbrHNQWJKcAfX8Vu1IGwG9JDgCiBbI576vCnt8RLjp3t2bXu xJfvGBrm+VMUozelVlQHpHoQJl0KayFgD3PdozYphwRjGjQd6o4SszLT62/FphvkN4wX Z7/I8m2pmvDlrAsjzcbVJl1XH8jcUad7XuappsZG6R6okSZFYyvj9CVfpQnHYtY3HTaj XIvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792231949; x=1792836749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dKoUY67/0brH9PfrEtDz8lEuDjVGpCp9GkyhQChz7oI=; b=2qgHT9FcLvtkrDtADQzws2tvgFNFEIzG90R1VUMA3DYl4cv2Uawh9C5eFpxwdn5Oxz YStdu+NWWj/dHDYC16ni7p6S8rNsf72UwYnFldyULG22ZAqg8dESbrkk8ss8esk7IHKB w7bu0c246M9pRYMmeqoOnezyXwFylsxEM1e0RrpQlHvK3Q1YdUVuZ4YTpsr/u7poDMUt 2JJBhxeKPVgAH/G48tk/cewTUSIBuWY/5bfU3e6n4l7OwS1KStdn00IkUdMEfYFvoe31 h9QAHnhf6HtKE58Mho8X3dUJwtDussgd7TjAXLqMBnjm6hsPMytTeP1JpJiEuS1PW/C7 WJtg== X-Forwarded-Encrypted: i=1; AKwUvBz9zQkH+m/p6uGSDJIpeieW5YTpvV5OkaLMMPtJloG2nfhGls+0+qo5DBusMYuK2hg0J1MRZMkkSrPQ@vger.kernel.org X-Gm-Message-State: AFq9FYJq5yBAjPBeZBQ5/F/1WPA9XKMh6iZj9Ur6Sz1/ocHouUG0h54M oj8oDigh1+onYhB9Gi/LO/Vqr9h9Og3cNAFYwXoxidOugvM20zz9gjNu X-Gm-Gg: AYBFou3Q6oNs26+9TVY2BRYeVkO/ztyMrtj5BfEq36uBoglTJHQujfwD6pc93tlG50k kNsvEHz9FNJcQxp6MTGrLpFvQC/12dpyltcTwf4AvqK/14p1XZQi4hlu2NC0T74HlPgkCwEoJV+ tPcMzqSa2dll7yrcDoYmiL9GA9uQ9CICJ53YBfuoqOeN8Vhv5jAGZDyQrmbEYgqMhXJ0wzCB/ep 63Jvipmnzr/3thZXGhCEgS6EJ0OIzC6iV7mITLbJr2hMNWOpXMxNQvPDqiUVn5nB3ESgwRMChK4 Iujzv5G8i2PsAvW9nIOSB4+K33ycEm6DdgN+SxHXWJfS8LJx+yauyn4HTHeurQndzx5BE4En4Cv CGL8N9kFjaErjLvxaqk9zKHPA+0vTmUCkQLfJDdH3BvslohjSOcHVr62V2EX5mqfuDQXh/hfEL/ AH69JCdeEXs8ZlejV7GzxpYXZq4CL4+FReCFJ/t4qKO8GPmIoHnoiHPtRPIsTE69w4kjGWVbXus RWjnzM4gCsDG8JgOfBhTwJJ6L3QqU6/lPnCYzYq62xJh8/L5rOJWOaexJ0q3yD9PpKuBq2s X-Received: by 2002:a05:6000:14b:b0:488:8525:4979 with SMTP id ffacd0b85a97d-48e07fb5261mr2934328f8f.45.1792231949280; Sat, 17 Oct 2026 03:12:29 -0700 (PDT) Received: from SP11X1e.cable.virginm.net (cpc99340-croy26-2-0-cust244.19-2.cable.virginm.net. [80.193.62.245]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4c5957sm10183948f8f.9.2026.10.17.03.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 03:12:28 -0700 (PDT) From: George Neacsu To: Anusha Arun Nandi Cc: David Heidelberg , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gjorgji.rosikopulos@oss.qualcomm.com, jigarkumar.zala@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, Bryan O'Donoghue , linux-media@vger.kernel.org, krzysztof.kozlowski@oss.qualcomm.com, daniel@quora.org, konrad.dybcio@oss.qualcomm.com, christopher.obbard@linaro.org, alex.vinarskis@gmail.com Subject: Re: [PATCH 2/2] media: qcom: camss: account for C-PHY when calculating link frequency Date: Sat, 17 Oct 2026 11:12:27 +0100 Message-ID: <20261017101227.61271-1-geocausa@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261017035221.3816464-3-anusha.nandi@oss.qualcomm.com> References: <20261017035221.3816464-1-anusha.nandi@oss.qualcomm.com> <20261017035221.3816464-3-anusha.nandi@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Anusha, I tested the CAMSS pieces on X1E80100 and found one extra receiver path that needs the C-PHY select. X1E80100 uses csid_ops_680, not the gen3 CSID path changed here. The C-PHY flag reaches struct csid_phy_config correctly, but camss-csid-680.c leaves CSI2_RX_CFG0.PHY_TYPE_SEL clear, so the front IMX681 stream is decoded as D-PHY and capture times out with a zero-byte buffer. The equivalent change for CSID 680 is just: val |= phy->cphy << CSI2_RX_CFG0_PHY_TYPE_SEL; before writing CSID_CSI2_RX_CFG0. With that line, the register reads back 0x01300000 on CSID1 and 3844x2640 RAW10 capture succeeds from the IMX681 over one C-PHY trio. The rear OV13858 still captures over four D-PHY lanes. I also ran a control with your posted CAMSS/qcom-mipi-csi2 module code, plus only the X1E PHY table and this CSID-680 select: both front and rear capture successfully. Would you prefer to fold the CSID-680 line into this patch? I have a clean follow-up commit ready if you would rather I send it separately. Thanks, George