Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Liu Yufei <lyf98405@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: proximity: Add Vishay VCNL36829
Date: Sat, 17 Oct 2026 21:05:02 +0100	[thread overview]
Message-ID: <20261017210502.129d1709@jic23-hlaptop> (raw)
In-Reply-To: <20261003050453.413700-2-lyf98405@gmail.com>

On Sat,  3 Oct 2026 13:04:52 +0800
Liu Yufei <lyf98405@gmail.com> wrote:

> From: Liu Yufei <lyf98405@gmail.com>
> 
> Add devicetree binding for the Vishay VCNL36829 proximity sensor.
> 
> The VCNL36829 is a proximity sensor with an integrated VCSEL emitter
> in a small package. It is controlled over I2C and has an interrupt
> output. It is powered by two supplies, vdd and vddio.

I wondered if we should just combine this with the vcml3020 binding
which is fairly similar but with the integrated vcsel rather than
an led, it would get just complicated enough that I guess for two such
short bindings keeping them separate is easier.
> 
> Signed-off-by: Liu Yufei <lyf98405@gmail.com>

What changed enough to justify not picking up Krzysztof's tag?
https://lore.kernel.org/all/20261004-outgoing-outrageous-fulmar-2ba7f4@quoll/
Looks like nothing.  Please be careful around that in future.  If everything
else is fine I might just assume it is fine to put that tag back

Thanks,

Jonathan




  parent reply	other threads:[~2026-10-17 20:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03  5:04 [PATCH 0/2] iio: proximity: Add Vishay VCNL36829 driver Liu Yufei
2026-10-03  5:04 ` [PATCH 1/2] dt-bindings: iio: proximity: Add Vishay VCNL36829 Liu Yufei
2026-10-04  7:39   ` Krzysztof Kozlowski
2026-10-17 20:05   ` Jonathan Cameron [this message]
2026-10-17 20:18     ` Jonathan Cameron
2026-10-03  5:04 ` [PATCH 2/2] iio: proximity: Add driver for " Liu Yufei
2026-10-03  5:12   ` sashiko-bot
2026-10-03 19:03   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261017210502.129d1709@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyf98405@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox