From: Ross Cawston <ross@r-sc.ca>
To: andrew@lunn.ch
Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
chris.packham@alliedtelesis.co.nz, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Ross Cawston <ross@r-sc.ca>
Subject: Re: [PATCH 0/3] leds: add Realtek RTL9300 port LEDs under software control
Date: Sun, 18 Oct 2026 16:20:14 -0700 [thread overview]
Message-ID: <20261018232015.527-1-ross@r-sc.ca> (raw)
In-Reply-To: <59f75e7d-9b56-441d-a4b5-58ad3862267e@lunn.ch>
On Sun, Oct 18, 2026 at 10:36 PM UTC, Andrew Lunn wrote:
> Port LEDs should be within the port node of the switch in DT. Ideally
> you want all LEDs for a port to start the with basics, on/off control.
[...]
> So please don't make these LEDs special.
That makes sense. The catch is that RTL9300 has no switch driver
upstream yet, so there is no port node with a driver behind it to put
them in: mainline only has drivers for the switch's I2C and MDIO
controllers.
Unless you see a place they could go in the meantime, I'll withdraw
this series until there is one.
Chris, do you know of anyone working on an RTL9300 switch driver? If
so, I'd be glad to help with the port LEDs there.
Ross
next prev parent reply other threads:[~2026-10-18 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 19:43 [PATCH 0/3] leds: add Realtek RTL9300 port LEDs under software control Ross Cawston
2026-10-18 19:43 ` [PATCH 1/3] dt-bindings: leds: add Realtek RTL9301 port LEDs Ross Cawston
2026-10-18 19:43 ` [PATCH 2/3] dt-bindings: net: realtek,rtl9301-switch: add port LED controller Ross Cawston
2026-10-18 19:43 ` [PATCH 3/3] leds: add Realtek RTL9300 port LED driver Ross Cawston
2026-10-18 22:36 ` [PATCH 0/3] leds: add Realtek RTL9300 port LEDs under software control Andrew Lunn
2026-10-18 23:20 ` Ross Cawston [this message]
2026-10-19 0:02 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018232015.527-1-ross@r-sc.ca \
--to=ross@r-sc.ca \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox