Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Til Kaiser <mail@tk154.de>
Cc: netdev@vger.kernel.org, jie.luo@oss.qualcomm.com,
	 andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org,  pabeni@redhat.com,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	 krzk+dt@kernel.org, conor+dt@kernel.org,
	quic_leiwei@quicinc.com,  quic_suruchia@quicinc.com,
	quic_pavir@quicinc.com, linux-arm-msm@vger.kernel.org,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH net 2/2] dt-bindings: net: qcom,ipq9574-ppe: Apply PPE constraints to all switch ports
Date: Mon, 19 Oct 2026 08:55:44 +0200	[thread overview]
Message-ID: <20261019-pristine-brainy-guppy-eb2af2@quoll> (raw)
In-Reply-To: <20261016150140.929729-3-mail@tk154.de>

On Fri, Oct 16, 2026 at 05:01:40PM +0200, Til Kaiser wrote:
> The generic ethernet-switch schema accepts both ports and ethernet-ports
> containers and both port and ethernet-port child nodes. The PPE binding
> only applies its port constraints to ethernet-port nodes with addresses
> matching [1-6]+ inside ethernet-ports.
> 
> As a result, ethernet-port@7 with reg = <7> is accepted without the PPE
> port ID limit. The alternative container and child naming forms also
> bypass the required PPE clocks and resets.
> 
> Match the same container and child node patterns as ethernet-switch.yaml
> so that every accepted switch port receives the PPE constraints. Keep
> the valid port IDs constrained by reg.
> 
> Fixes: 1898fc572118 ("dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC")

Nothing to be fixed here, really, drop.

> Signed-off-by: Til Kaiser <mail@tk154.de>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> index 6d0b21a10732..a5e8aab500ed 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq9574-ppe.yaml
> @@ -173,9 +173,10 @@ properties:
>        - interrupts
>        - interrupt-names
>  
> -  ethernet-ports:
> +patternProperties:
> +  "^(ethernet-)?ports$":

Why are you reverting the review? The name is ethernet-ports.

>      patternProperties:
> -      "^ethernet-port@[1-6]+$":
> +      "^(ethernet-)?port@[0-9a-f]+$":

Same here.

Best regards,
Krzysztof


  reply	other threads:[~2026-10-19  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 15:01 [PATCH net 0/2] net: ethernet: qualcomm: ppe: Fix queue access and port validation Til Kaiser
2026-10-16 15:01 ` [PATCH net 1/2] net: ethernet: qualcomm: ppe: Fix multicast queue admission control access Til Kaiser
2026-10-16 15:01 ` [PATCH net 2/2] dt-bindings: net: qcom,ipq9574-ppe: Apply PPE constraints to all switch ports Til Kaiser
2026-10-19  6:55   ` Krzysztof Kozlowski [this message]
2026-10-16 15:09 ` [PATCH net 0/2] net: ethernet: qualcomm: ppe: Fix queue access and port validation netdev-bot+sinfo
2026-10-16 15:50   ` Til Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019-pristine-brainy-guppy-eb2af2@quoll \
    --to=krzk@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=jie.luo@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@tk154.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_leiwei@quicinc.com \
    --cc=quic_pavir@quicinc.com \
    --cc=quic_suruchia@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox