From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F4B4D6C2A for ; Mon, 19 Oct 2026 10:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792405090; cv=none; b=hecuxoDTbRW+I7lUhxpML3w25kXIlaSmvr7Wzo419RDrwHj7XHgOIPJZtTlkTpjPhJG3BEPygv692suu2RLaKMVV7Ck+GWzxXvTZijvCzJkBgVthChpPTxT4SaEmg7+Qs4ZfsJxwm12Gv0iML5AZVD/dnF4ZEUijNHutZniLrRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792405090; c=relaxed/simple; bh=V+0aAcFUCH1cc6EO5h875PHuWNEBDxi02UU0k+Kbco8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sC7FDb6VNJ6miqYJQTMigCxEHboxSIlUs1kXR/ROCBhb2FiNLSER8XpcYyX7wWKYzH7hVdtW0v9s5oWlYRfVGGrLMWmg26sGUcec6KcPfzEr0EPN0pPqlZK/t05LNx5VgXfNYM20kWYrYM8Nga8wXyTROhF0dpboHPpZAL1zfBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J1MFnrQm; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J1MFnrQm" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-48dfdd0678dso1259667f8f.0 for ; Mon, 19 Oct 2026 03:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792405087; x=1793009887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sPA0grO6lR0vtnEVLynRjMdDas+begIgQ2sOW1izRNU=; b=J1MFnrQmGQuShX6qYHkCwq5tZzZ9oVaK0RmibBQuSMy3UF8ATneQKL+IJCShNdqKwU 1d47fvoZM8PGEDbBai6IWWGqnDcBiPkeaY6SaxxpelWbxCP2IYYLCAUVe+dIUvxKD7jO X6f4BLaXgBlPljFblX/zu141ZsJ504iLp6vYZeXOB7HVZ2oN7QIPt+SzwIUzWT1FPG3C fN5LrW8lCE1MlbdYs4tW6HpR4GSjmf135E/0KItxTNNigK5BjhliCoWsfr6g9j6FLIat cyYRpLFp/DhhFnL9UhB9XQJV2IO7wNqe7PQjukSKkDMaZMvSNEv4tcIiAgk20t/hAQGe WSjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792405087; x=1793009887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sPA0grO6lR0vtnEVLynRjMdDas+begIgQ2sOW1izRNU=; b=miOTiES1QSSF+4/dbHLpiTBE1AJbTZFwigGWV54GhupoJza0tQzTqwuH0nlAtbJTmy nhSY4alMtSz7O5ThX/9y5D7UmHlsGDIw+960YAyhLRU7VhuedilQ2MIuhlLhlrGwSym1 QBXz0hzGNGvR3PEFs3/WYceLl1PaiNLZmAugr30M+aZwMbCGjQwRN2nJz3OWeHRsoAN4 pFp+WNEIjxno4PY4VDpBNlYlUhHUFc1QvQHaoidtfbEX7Lhr3SuLjpkz4Z9ySLLk3f7o 8TOAqGnmlAiq2Ux+MzmfEjthp/N7UvTdhInbtVZX7PmsRGSji0KsxcMwalkjyTmN0ub4 17yw== X-Forwarded-Encrypted: i=1; AKwUvBzrV8bGtNq7zdiX9IkTi7Rqjhv0RFEB+duycazG+UPF0NOOY9F1Ib3rpgzN2e0q91/X/5TsGDayuGWz@vger.kernel.org X-Gm-Message-State: AFq9FYLuM32+07qT2m/RYOsu6SEj5wOHLm+kct065JStCcGJIo0r7dqu bhyO2HZj0vMFdf1xOvCxstONB/GHA7WSdNXEXkXWpYuvu62odCKxiWtu X-Gm-Gg: AYBFou3LK3yMSaYSIwPYE0i4pw9/rK4PT4wfqt4KLwAO727gG8wheMMhqcr8b+lpxUi PUGd9/zJyMc/9YPnRaP8qDbI/WxAbp7oCdSk4SkERQzU+th/d802qEba2QbF4TJDQMWMQpwNevb a72PeqYx4zJVABh1V5ywzzkM0EAuwJRXGorRVsz0pH2x9pLhtAclRjG1iKi5A12igW2S92fKGUa 1vqTT8M0MA1ux7jD4b8LSMpEd4Gk1a0BVNBZX+kYArVUY20qpd9L3vioifRfFpSvYfv253RpSYp /YFsbeFZCDK5DISZgIrtWNSVKeJ/1DlHA7tuco8Er5rd9J37X6p7A6+WPlv/ITWZJk8b6fWXipZ MOAeBM/73OsisfYjJdawoWcQf41mzkP5utLHIre2cvEhX2+PrQZ98vzcFGtH93QRCANw+kwy7ku +68zrBYGTLqxHXOHhyYXLn79y+EC9REWwaqVHsep5NPZJGBtDKbXSMx3xMOrhZcvE5Q41iJ2CdO 7uo5CyC0pxrRQ7RYI20gtfAvs6iZw== X-Received: by 2002:a5d:4a8d:0:b0:48d:fd1f:9a9b with SMTP id ffacd0b85a97d-48e07f9e94bmr10227937f8f.34.1792405086586; Mon, 19 Oct 2026 03:18:06 -0700 (PDT) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4f576asm23913237f8f.32.2026.10.19.03.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 03:18:05 -0700 (PDT) From: Svyatoslav Ryhel To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Svyatoslav Ryhel Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev Subject: [PATCH v3 4/4] mfd: max8907: Convert to use device managed poweroff handler Date: Mon, 19 Oct 2026 13:17:50 +0300 Message-ID: <20261019101750.125439-5-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261019101750.125439-1-clamor95@gmail.com> References: <20261019101750.125439-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the legacy global 'pm_power_off' function pointer assignment with the devm_register_power_off_handler() helper. Signed-off-by: Svyatoslav Ryhel --- drivers/mfd/max8907.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c index fab44be7ced57..6d5e6a1556fd5 100644 --- a/drivers/mfd/max8907.c +++ b/drivers/mfd/max8907.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -173,11 +174,17 @@ static const struct regmap_irq_chip max8907_rtc_irq_chip = { .num_irqs = ARRAY_SIZE(max8907_rtc_irqs), }; -static struct max8907 *max8907_pm_off; -static void max8907_power_off(void) +static int max8907_power_off(struct sys_off_data *data) { - regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG, - MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF); + struct max8907 *max8907 = data->cb_data; + int ret; + + ret = regmap_update_bits(max8907->regmap_gen, MAX8907_REG_RESET_CNFG, + MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF); + if (ret) + dev_err(max8907->dev, "failed to power off the device!\n"); + + return NOTIFY_DONE; } static int max8907_i2c_probe(struct i2c_client *i2c) @@ -185,8 +192,6 @@ static int max8907_i2c_probe(struct i2c_client *i2c) struct device *dev = &i2c->dev; struct max8907 *max8907; int ret; - bool pm_off = of_property_read_bool(dev->of_node, - "maxim,system-power-controller"); max8907 = devm_kzalloc(dev, sizeof(*max8907), GFP_KERNEL); if (!max8907) @@ -238,9 +243,10 @@ static int max8907_i2c_probe(struct i2c_client *i2c) if (ret) return dev_err_probe(dev, ret, "Failed to add MFD devices\n"); - if (pm_off && !pm_power_off) { - max8907_pm_off = max8907; - pm_power_off = max8907_power_off; + if (of_device_is_system_power_controller(dev->of_node)) { + ret = devm_register_power_off_handler(dev, max8907_power_off, max8907); + if (ret) + return dev_err_probe(dev, ret, "failed to register power-off handler\n"); } return 0; -- 2.53.0