Devicetree
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: George Neacsu <geocausa@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Marshall <pm@petermarshall.ca>, Hao Yao <hao.yao@intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver
Date: Mon, 19 Oct 2026 19:34:10 +0000	[thread overview]
Message-ID: <20261019193402.52923-1-lsa.uz@pm.me> (raw)
In-Reply-To: <179243379000.31842.4735750009847702427@gmail.com>

Hi George,

Thank you for trying it on the Snapdragon model.

On 19/10/2026 19:24, George Neacsu wrote:
> As posted, patch 2/4 fails probe at the integer-multiple check because
> 840 MHz is not an integer multiple of 19.2 MHz.

That refusal is deliberate. The MIPI rate is an integer multiple of the
input clock, and the sensor rounds a request down (UM2829 13.6): asked
for 840 Mbps from 19.2 MHz, it runs at 825.6 while the receiver is set
up for 840. camera-sensor.rst asks a sensor driver to use only the link
frequencies the firmware gives, so the driver refuses one it cannot
produce. From 19.2 MHz, 403.2 MHz (806.4 Mbps, 42 times the clock) and
384 MHz (768 Mbps, 40 times) are exact, so the change is one value in
your board's DT, in the sensor endpoint:

	link-frequencies = /bits/ 64 <403200000>;

On the Intel model I ran it at 403.2 MHz with a 19.2 MHz clock, and every
mode ran at 60.22 fps, as the controls give.

> For a test only, I removed that rejection and left the rest of the driver
> unchanged. The sensor then probes, the CAMSS media graph completes, and
> capture delivers one complete 644x604 Y10 frame. A continuous five-frame
> capture then times out waiting for frame 2.

With the check removed, the sensor runs at 825.6 Mbps against a receiver
set up for 840, and the driver reports a pixel rate of 140 MHz where it
is 137.6. I do not know whether CAMSS minds, but a run at 403.2 MHz with
the driver as posted would take that out of the question. If it still
stops after one frame, I would be glad to compare what the two drivers
write at stream start.

Sergey


  reply	other threads:[~2026-10-19 19:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:27 [PATCH 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-10-19 16:27 ` [PATCH 1/4] dt-bindings: media: i2c: Add ST VD55G0 camera sensor Sergey Lebedev
2026-10-20  8:27   ` Krzysztof Kozlowski
2026-10-20  9:08     ` Sergey Lebedev
2026-10-19 16:27 ` [PATCH 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-10-19 18:24   ` George Neacsu
2026-10-19 19:34     ` Sergey Lebedev [this message]
2026-10-20  6:44       ` George Neacsu
2026-10-20  8:52         ` Sergey Lebedev
2026-10-20 12:25           ` Benjamin Mugnier
2026-10-20 14:26             ` Sergey Lebedev
2026-10-20 18:10               ` George Neacsu
2026-10-20 18:14                 ` Sergey Lebedev
2026-10-19 16:28 ` [PATCH 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-10-19 16:28 ` [PATCH 4/4] media: ipu-bridge: Add the Surface Pro 11 infrared illuminator Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019193402.52923-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geocausa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox