From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792484056; b=w26lnuBMWwqQLPqPhqySEHXwWCFiqBDsFdP/AKT0APSQO4YkvcXR+K8PFM2YQfK8Zduo iLnKNfqyr1yRF6Qf2t3m4pTDMFmLYRrv06fcdqOfBe3WyaWYEJOKvTHJk6leEw9IZWiAo IS75DRd7NDQg0Mo/bPrSdpc2oVWY8J2CjTMr0s91J7yCE24+mtXUePyRC4WGUS191ZYmc tLExkqBtuNCda8Ink9LBQgx1I99ZGJMC7XNBVIPI/c23AbEh71lZk3PWFv5wsriBB3ASa lG6jw/nqge2tpUhTX3rvxwbVYnBxrhNGUs6T/jPM3DfOyZ3az7Lnkumd6uRj7wvJRsw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792484056; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=qO3JqoryMuz3iGO1ugSkLq6Ey291hKQqWmHA9+oEZXs=; b=ZcUD314LXfo7JGTJwlRoyhgLS6T9j/GVkKXyRBTjXKBPdtx13akSJ2zbnjo6iv5zCxk+ AbfURBjBTzb0DmZ4vWYdmbAQiRH8z8HFjdPECtrJpC9iHe8hr4Htmy7Sye5Y+0bqawHgL mbXhmyAu5ppnFCkSMrB3Kuv6Qd2vuiQohozK1owJlfMExXmemZt0l9LFISP/HRsUb9OpO tS0d0taGQ+FNtoGki2izGd5lq1mi45Lqnm7rtzKkKrUo/40y9n2f7LCCUGo3xi0xZv+2f LvPVQxlZuEnyUQYZVU/iJg4UPFr+A/mIrymUIurkCHGXyR/0/9C2Ax4+YZrcf+Q+aWg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=SLcI4GpH; arc=none smtp.remote-ip=91.218.175.44 Received: from mta0.migadu.com (out-44.mta0.migadu.com [91.218.175.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E3E8606A325 for ; Tue, 20 Oct 2026 08:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3E3E8606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=SLcI4GpH X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=r7U2PL3f73XxI6tIOrwGXDDfc8aDPCW0xlVXmaXSGY8=; c=simple/simple; d=packett.cool; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792484054; v=1; x=1793088854; b=SLcI4GpHA/sN5zzdKjfUNQ61moYOuP4b5L1DgHmyxTp2GjiN6Co0mRbqu+3i2S74wT6WAYCn bma2sjPmDuV4/Re4d/Efk4AcAc3+M+Br7btL3kSLtqYkG0ZzMT06NCrHZUaJQ0Nj6hrzHz6Z1Mc 5KzHT1U570dLEUsi/MzeTdtwBTH0Kpx6kBv2HSgTS7yiyrYOIRzsP7WA1vvKoXQwhhrOAUmqdK3 x01qUQvqNFlGy9syApCwRfL7/Y4O1yUA0QZWcW1MerTwSOS0cx12tCsJuKg+e1LvKc58+BhYPEW 1VkeqF7OPrXLXZxPRIaA6l7PeNZImMbL3OEfF1hG5EG3w== X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 9afd8cc5e267956b; Tue, 20 Oct 2026 08:14:14 +0000 X-Mizu-Trace-ID: 9afd8cc5e267956b X-Migadu-Flow: FLOW_OUT From: Val Packett To: Heikki Krogerus , Greg Kroah-Hartman Cc: Luca Weiss , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Neil Armstrong , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Val Packett Subject: [PATCH v2 2/2] usb: typec: fsa4480: Report switch & mux events to codec Date: Tue, 20 Oct 2026 05:12:54 -0300 Message-ID: <20261020081343.1507986-3-val@packett.cool> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261020081343.1507986-1-val@packett.cool> References: <20261020081343.1507986-1-val@packett.cool> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Weiss In the Type-C graph, the FSA4480 switch is in between the USB-C connector and the audio codec, but the audio codec also needs to receive the switch and mux events from the FSA4480. Update the driver to get an Type-C mux on the next endpoint and broadcast the recevied mux & switch state to it. Signed-off-by: Luca Weiss [val: enable the SENSE/MIC bits; put the refs in fsa4480_remove] Signed-off-by: Val Packett --- drivers/usb/typec/mux/fsa4480.c | 57 +++++++++++++++++++++++++++++---- 1 file changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers/usb/typec/mux/fsa4480.c b/drivers/usb/typec/mux/fsa4480.c index bea0c1deec94..93faa81d0879 100644 --- a/drivers/usb/typec/mux/fsa4480.c +++ b/drivers/usb/typec/mux/fsa4480.c @@ -60,6 +60,9 @@ struct fsa4480 { struct regmap *regmap; + struct typec_mux *codec; + struct typec_switch *codec_switch; + enum typec_orientation orientation; unsigned long mode; unsigned int svid; @@ -115,7 +118,8 @@ static int fsa4480_set(struct fsa4480 *fsa) } } else if (fsa->mode == TYPEC_MODE_AUDIO) { /* Audio Accessory Mode, setup to auto Jack Detection */ - enable |= FSA4480_ENABLE_USB | FSA4480_ENABLE_AGND; + enable |= FSA4480_ENABLE_USB | FSA4480_ENABLE_AGND | + FSA4480_ENABLE_SENSE | FSA4480_ENABLE_MIC; } else return -EOPNOTSUPP; @@ -162,7 +166,11 @@ static int fsa4480_switch_set(struct typec_switch_dev *sw, mutex_unlock(&fsa->lock); - return ret; + if (ret) + return ret; + + /* Report orientation to codec after switch has been done */ + return typec_switch_set(fsa->codec_switch, orientation); } static int fsa4480_mux_set(struct typec_mux_dev *mux, struct typec_mux_state *state) @@ -185,7 +193,11 @@ static int fsa4480_mux_set(struct typec_mux_dev *mux, struct typec_mux_state *st mutex_unlock(&fsa->lock); - return ret; + if (ret) + return ret; + + /* Report event to codec after switch has been done */ + return typec_mux_set(fsa->codec, state); } enum { @@ -287,6 +299,19 @@ static int fsa4480_probe(struct i2c_client *client) FIELD_GET(FSA4480_DEVICE_ID_REV_ID, val), FIELD_GET(FSA4480_DEVICE_ID_VENDOR_ID, val)); + /* Get Codec's MUX & Switch devices */ + fsa->codec = fwnode_typec_mux_get(dev->fwnode); + if (IS_ERR(fsa->codec)) + return dev_err_probe(dev, PTR_ERR(fsa->codec), + "failed to acquire codec mode-switch\n"); + + fsa->codec_switch = fwnode_typec_switch_get(dev->fwnode); + if (IS_ERR(fsa->codec_switch)) { + ret = dev_err_probe(dev, PTR_ERR(fsa->codec_switch), + "failed to acquire codec orientation-switch\n"); + goto err_put_mux; + } + /* Safe mode */ fsa->cur_enable = FSA4480_ENABLE_DEVICE | FSA4480_ENABLE_USB; fsa->mode = TYPEC_STATE_SAFE; @@ -310,8 +335,11 @@ static int fsa4480_probe(struct i2c_client *client) sw_desc.set = fsa4480_switch_set; fsa->sw = typec_switch_register(dev, &sw_desc); - if (IS_ERR(fsa->sw)) - return dev_err_probe(dev, PTR_ERR(fsa->sw), "failed to register typec switch\n"); + if (IS_ERR(fsa->sw)) { + ret = dev_err_probe(dev, PTR_ERR(fsa->sw), + "failed to register typec switch\n"); + goto err_put_switch; + } mux_desc.drvdata = fsa; mux_desc.fwnode = dev_fwnode(dev); @@ -319,18 +347,33 @@ static int fsa4480_probe(struct i2c_client *client) fsa->mux = typec_mux_register(dev, &mux_desc); if (IS_ERR(fsa->mux)) { - typec_switch_unregister(fsa->sw); - return dev_err_probe(dev, PTR_ERR(fsa->mux), "failed to register typec mux\n"); + ret = dev_err_probe(dev, PTR_ERR(fsa->mux), + "failed to register typec mux\n"); + goto err_unregister_switch; } i2c_set_clientdata(client, fsa); return 0; + +err_unregister_switch: + typec_switch_unregister(fsa->sw); + +err_put_switch: + typec_switch_put(fsa->codec_switch); + +err_put_mux: + typec_mux_put(fsa->codec); + + return ret; } static void fsa4480_remove(struct i2c_client *client) { struct fsa4480 *fsa = i2c_get_clientdata(client); + typec_mux_put(fsa->codec); + typec_switch_put(fsa->codec_switch); + typec_mux_unregister(fsa->mux); typec_switch_unregister(fsa->sw); } -- 2.55.0