From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.170 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792505017; b=EglGAqgVJIiDxpbgy+Y2Hh/p9i9LtmmRVYCC1bUpFhOlJhoGw8uB7Uku7wihxZXagxnS AjtCCO7i/aKbhqLZ/iZTiEhKPRjOb/59K5YKpZLY57kV84xY3+mPhLJ+w3yA0I+3ymKeS DVANMzcoR7l/xwn8k58288ZJP33PaF72zFtaGM5HdMZHHIWH7F26NR2J+b0BPTudn9Igk JPeOc1CdpaX8oAKzCLawouJq1aQNX34NQedGrQCrc1rsrjShlWAQU7HbE0Y01iggM54+F Mf1xnkmfdkN4wr/F7PwW8nGrY6VvIVVnL7QqtG5gElnhFasxQquJD5Gf3iDGBMB0ffw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792505017; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=OvmhxSjVHj+d9pk6ymL8DlmUjvcSTE0G8stIvyswo2I=; b=mnHGbY/dAmpo6EnGGVHJrYRtBSuuX8jJsdSB86n3sWv/FFdZFP6yFv7FXdC/oSW1IS9F PtCFFVLo3qBc+78sONMRtGPFZWQX+WiBF1pugjdeZRLtwgurZbjNHCJM6+58oXf7dozd9 Z6djkQdQc+S7SNnq5Xrz3eaPvmjTxuewfGpjfHBs9DF9wEFYGNF5c+53aykI1FZpLA+Mh e2nHFHiP1m4DnSx2CVj5EkT+MN4ABW7y1hoT7QzSTqlf8h3h/XNWDqsVYn8QkVCWr9DX0 WZUet4iJxpPXabvrVeHurN43WduosvucgHNQiYuNh8vTJOy38nofIcW1NElKQyXJsGw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=GhzS4+T9; arc=none smtp.remote-ip=209.85.214.170 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66868606A31D for ; Tue, 20 Oct 2026 14:03:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 66868606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=GhzS4+T9 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2e7e742a2c7so4805585ad.0 for ; Tue, 20 Oct 2026 07:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792505016; x=1793109816; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OvmhxSjVHj+d9pk6ymL8DlmUjvcSTE0G8stIvyswo2I=; b=GhzS4+T9vwAqR4QfqU3Kp4iBUyHwDBw5GwRMigHK7xRm/oxggvpFMpShAmCnzY0iKB 6cN3KDDnkct5FTQ5D1yGV2muyyQormjciGrFFhEbJn22e6hOJrUyac6v5qsl4yv2EBJs 203icL2HpyLq6EwUcdVtYUeFXZa4Lgs5PTQczn2amjn51DyPh8L6mU9EQ2Fe4ggdHVYW 5J8bVohSziCjvNcjztupRM2A13aKfycwBkmhjKFWGrcRGiG6rzxlPrmYSi0loXiiNnO7 RuT4Dk8nMBpQovoLO+f/oCmvUSa6jNVEnD0/kX2LkjKMKtP3jL7rt0+N1OLy+lAUj2l+ E1Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792505016; x=1793109816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OvmhxSjVHj+d9pk6ymL8DlmUjvcSTE0G8stIvyswo2I=; b=NFr8OZkfUpaqOD1ldDmBnZISuhzH7vz9yvsGS6Isdd2l5MKe3nb955lGWFpqdJLM+R 2hzP/jUmtMd2oyjBZVP58flsizwvHbzHRym49P1RSh3HkvhfdizlO41fXY7IkF+6YHdG uA4zTUHFJ/OWG572T0LO/ux+PrXYx9h/Aiz8G2U/BdAfClgw7xpsNIC+bc/ZcXHrUCMS lzRk+DPapH0Hs547bT8Dh7D/h98Ocq4CizNy7HdkT1y3fF1nAJpmkStoNrQjZzKQPYZ6 0bxKQVEoCKaC4CWj9u/tkIHskHe5O37nc0YWEdN6c5Q7LUJAd0m/YlQAyY1pMIqCEHQR fI7g== X-Forwarded-Encrypted: i=1; AKwUvBx/s3fYdRglcmctw/JRXALPXH/JqGUAplKjn407kand537LqXcqhWXZGuzOjWt6syOK3u3TimdMm+At@vger.kernel.org X-Gm-Message-State: AFq9FYJLQiwILF9nhvEQ04um3sZrw4b2vzViqIZspF8kY9tfZG14/Ohd Ky6QzUA/MZ+KdZHvJoY8jnSxn63M+6yUaExmPJPqcHoayxxRkt1ALoAa X-Gm-Gg: AYBFou1VeTS4u8AdCRV+wHt6riLoTAZfN3lE1dS7Hvw1gch+l7YfZasnndOjJeq9Ebn Fj7Ns1G2PqdNXPI9qkkVioriy0YMfQ/Rg70MEA3zBhfHhtgNHSXcD6yxCtwZI/NXrcRz112ussi wd1o597CnbpzZdB1ReF50uzqJ124LXlgmLlbiNHYe7eeAEFI8JZZvtnNR/7KdUTrSrRrWSweDJh wWA0JQ9w4veBoNaC1GXf9nc+7/fUdJEVheBB0A00IlAi0kVe3yhMt4qRzwCe+wKYE/X8josObWW tN9AdqkcAc6ikhHXPCmXdPTbztXd4+2B+9z5ny2nlvhHHOyv973eAN3QrDwmql1AcqhALq5XymJ nkDUJczQcRrJd/roZFuEH8fgApwFJx5zjVOd9n7tqj4TzH1PAuTNi9SkaiMs74kirUbD+qUVNg1 cv8A2+tdO2teJxN5mqQqHjimrSjpPHr2FquXDpbTMiT+ZwNR/k3Gu8SzBujIkXTh1Lb7MyC2MtM Rp2REMleAU= X-Received: by 2002:a17:902:dacb:b0:2ea:1e40:624 with SMTP id d9443c01a7336-2ea1e400e03mr14007165ad.17.1792505015392; Tue, 20 Oct 2026 07:03:35 -0700 (PDT) Received: from Aaron-M6 ([188.253.120.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea1502971csm12434865ad.51.2026.10.20.07.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 07:03:35 -0700 (PDT) From: Yaozhong Li To: Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Zhong , Zhang Qing , Joseph Chen , Sebastian Reichel , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yaozhong Li Subject: [PATCH v4 2/3] mfd: rk8xx: Release the power hold GPIOs before powering off Date: Tue, 20 Oct 2026 22:01:13 +0800 Message-ID: <20261020140127.720-3-yaozhonguwl@gmail.com> X-Mailer: git-send-email 2.55.0.windows.3 In-Reply-To: <20261020140127.720-1-yaozhonguwl@gmail.com> References: <20261020140127.720-1-yaozhonguwl@gmail.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rk808_power_off() writes the PMIC's shutdown bit directly. On boards where lines driven by the SoC gate the PMIC's power-off path, a shutdown performed this way does not stick: the rails drop and immediately come back up, so the board restarts instead of staying off. U-Boot reports the result as a power-on reset. Take those lines as an optional GPIO array, hold them asserted while the system runs and release them - waiting power-hold-delay-ms - before writing the shutdown bit. Device trees without the property retain the existing behaviour. The array is claimed before any child device is registered, so that a -EPROBE_DEFER from the GPIO provider does not tear down the regulators, RTC and clocks that devm_mfd_add_devices() has already registered. On a Firefly-RK3399 the shutdown stuck when such a line went from high to low before the shutdown bit was written, and did not when the line was never driven. Assisted-by: LLM Signed-off-by: Yaozhong Li --- drivers/mfd/rk8xx-core.c | 49 +++++++++++++++++++++++++++++++++++++-- include/linux/mfd/rk808.h | 3 +++ 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c index 3dcf6ab..137ab20 100644 --- a/drivers/mfd/rk8xx-core.c +++ b/drivers/mfd/rk8xx-core.c @@ -11,6 +11,8 @@ */ #include +#include +#include #include #include #include @@ -703,6 +705,22 @@ static int rk808_power_off(struct sys_off_data *data) default: return NOTIFY_DONE; } + + /* + * Some boards route "power hold" lines from the SoC into the board's + * power circuitry. They have to be held asserted while the system is + * running and released before the PMIC shutdown request is written, + * otherwise the rails can drop and come back up instead of staying + * off. Releasing them here rather than from a separate handler keeps + * the ordering against the I2C write explicit. + */ + if (rk808->power_hold_gpios) { + for (unsigned int line = 0; line < rk808->power_hold_gpios->ndescs; line++) + gpiod_set_value_cansleep(rk808->power_hold_gpios->desc[line], 0); + + msleep(rk808->power_hold_delay_ms); + } + ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) dev_err(rk808->dev, "Failed to shutdown device!\n"); @@ -766,6 +784,7 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap struct rk808 *rk808; const struct rk808_reg_data *pre_init_reg; const struct mfd_cell *cells; + bool system_power_controller; int dual_support = 0; int nr_pre_init_regs; u32 rst_fun = 0; @@ -851,6 +870,33 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap if (!irq) return dev_err_probe(dev, -EINVAL, "No interrupt support, no core IRQ\n"); + system_power_controller = + device_property_read_bool(dev, "system-power-controller") || + device_property_read_bool(dev, "rockchip,system-power-controller"); + + /* + * Claim the optional power hold GPIOs before any child device is + * registered. A -EPROBE_DEFER from the GPIO provider at this point + * costs nothing, whereas deferring after devm_mfd_add_devices() + * would tear the freshly registered children down again on every + * retry. + */ + if (system_power_controller) { + rk808->power_hold_gpios = devm_gpiod_get_array_optional(dev, "power-hold", + GPIOD_OUT_HIGH); + if (IS_ERR(rk808->power_hold_gpios)) + return dev_err_probe(dev, PTR_ERR(rk808->power_hold_gpios), + "Failed to get power hold GPIOs\n"); + + /* + * The settle time is optional. rk808 is zero initialised and + * the binding documents 0 as the default, so an absent property + * means the shutdown request follows the release with no wait. + */ + device_property_read_u32(dev, "power-hold-delay-ms", + &rk808->power_hold_delay_ms); + } + ret = devm_regmap_add_irq_chip(dev, rk808->regmap, irq, IRQF_ONESHOT | dual_support, -1, rk808->regmap_irq_chip, &rk808->irq_data); @@ -872,8 +918,7 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap if (ret) return dev_err_probe(dev, ret, "failed to add MFD devices\n"); - if (device_property_read_bool(dev, "system-power-controller") || - device_property_read_bool(dev, "rockchip,system-power-controller")) { + if (system_power_controller) { ret = devm_register_sys_off_handler(dev, SYS_OFF_MODE_POWER_OFF_PREPARE, SYS_OFF_PRIO_HIGH, &rk808_power_off, rk808); diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index 7ffc904..e56d595 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h @@ -15,6 +15,7 @@ #ifndef __LINUX_REGULATOR_RK808_H #define __LINUX_REGULATOR_RK808_H +#include #include #include @@ -1466,6 +1467,8 @@ struct rk808 { long variant; const struct regmap_config *regmap_cfg; const struct regmap_irq_chip *regmap_irq_chip; + struct gpio_descs *power_hold_gpios; + u32 power_hold_delay_ms; }; void rk8xx_shutdown(struct device *dev); -- 2.55.0.windows.3