Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Olivier Louvignes <olivier@mgcrea.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Paul Cercueil <paul@crapouillou.net>,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: ingenic: Add the X1600
Date: Mon, 26 Oct 2026 12:03:36 +0100	[thread overview]
Message-ID: <20261026-ancient-elfish-beluga-ca42ad@quoll> (raw)
In-Reply-To: <20261024051515.55639-1-olivier@mgcrea.io>

On Sat, Oct 24, 2026 at 07:15:14AM +0200, Olivier Louvignes wrote:
> The X1600's UARTs have the X1000's registers as far as the 8250 core
> uses them, but the driver has to tell them apart to set their bit clock
> count. Add ingenic,x1600-uart, with the X1000's as fallback.
> 
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> ---
>  Documentation/devicetree/bindings/serial/ingenic,uart.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/ingenic,uart.yaml b/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
> index d5f153bdeb0d..635342d43ddb 100644
> --- a/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
> @@ -32,6 +32,9 @@ properties:
>        - items:
>            - const: ingenic,jz4725b-uart
>            - const: ingenic,jz4740-uart
> +      - items:
> +          - const: ingenic,x1600-uart
> +          - const: ingenic,x1000-uart

These should be sorted by fallback, so list using x1000 should be the
last (x > j).

With this fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


      parent reply	other threads:[~2026-10-26 11:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24  5:15 [PATCH 1/2] dt-bindings: serial: ingenic: Add the X1600 Olivier Louvignes
2026-10-24  5:15 ` [PATCH 2/2] serial: 8250_ingenic: Start the X1600 UART from 16 clocks a bit Olivier Louvignes
2026-10-24 17:23   ` H. Nikolaus Schaller
2026-10-26 11:03 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026-ancient-elfish-beluga-ca42ad@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=olivier@mgcrea.io \
    --cc=paul@crapouillou.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox