Re: [PATCH 1/2] dt-bindings: display: panel: Add Retroid Pocket IL97680A panels

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sun, Oct 25, 2026 at 11:37:40PM +1000, Jacob Pyke wrote:
> From: Teguh Sobirin <teguh@sobir.in>
> 
> Document the Ilitek IL97680A panels in the Retroid Pocket Nova and the
> bottom display of the Retroid Pocket Duo. Both are 1280x960 MIPI DSI
> command-mode panels, with different supply configurations.
> 
> Link: https://github.com/RetroidPocket/linux/commit/9bfe85be2179d03338d09b8900f3b1916999ef15

Please do not reference random 3rd party repositories for no reason.

> Signed-off-by: Teguh Sobirin <teguh@sobir.in>
> Assisted-by: LLM

Drop tag

> Signed-off-by: Jacob Pyke <jacob@pyk.ee>
> ---
>  .../display/panel/ilitek,il97680a.yaml        | 121 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 127 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,il97680a.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,il97680a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,il97680a.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..70a1bdccef75ea3ee6335304ede771ff711991de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,il97680a.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/ilitek,il97680a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ilitek IL97680A based DSI panels
> +
> +maintainers:
> +  - Teguh Sobirin <teguh@sobir.in>
> +  - Jacob Pyke <jacob@pyk.ee>
> +
> +description:
> +  The Ilitek IL97680A is a DSI display driver IC driving the 1280x960
> +  command mode panels of the RetroidPocket handhelds.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: retroidpocket,rpnova-panel
> +    then:
> +      required:
> +        - vdd18-supply
> +        - vdd28-supply
> +    else:
> +      properties:
> +        vdd18-supply: false
> +        vdd28-supply: false

Keep the entire allOf just before additionalProperties: block.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - retroidpocket,rpduo-panel-bottom
> +      - retroidpocket,rpnova-panel

I would expect IL97680A fallback compatible.

> +
> +  reg:
> +    maxItems: 1

Best regards,
Krzysztof