Re: [PATCH v2 1/4] dt-bindings: iio: light: opt4001: add opt4041

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2845 bytes --]

On Fri, Oct 23, 2026 at 09:54:09PM +0100, Jonathan Cameron wrote:
> On Fri, 23 Oct 2026 14:30:28 +0200
> Jesper X Nilsson <jesper.x.nilsson@axis.com> wrote:
> 
> > Add a new compatible for opt4041. The opt4041 is only available in the
> > SOT-5X3 package. The device is pin compatible with the opt4001-sot-5x3
> > and shares the same properties. The opt4041 has one additional channel
> > compared to opt4001, the extra channel has a wide spectral bandwidth
> > ranging from 380nm to 1000nm.
> > 
> > Datasheet: https://www.ti.com/lit/gpn/opt4041
> > Signed-off-by: Jesper X Nilsson <jesper.x.nilsson@axis.com>
> > ---
> >  Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> > index 12b0c7ed5d72..35e9b0deb944 100644
> > --- a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> > +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml
> > @@ -4,7 +4,7 @@
> >  $id: http://devicetree.org/schemas/iio/light/ti,opt4001.yaml#
> >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> > -title: Texas Instruments OPT4001 Ambient Light Sensor
> > +title: Texas Instruments OPT4001/OPT4041 Ambient Light Sensor
> >  
> >  maintainers:
> >    - Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
> > @@ -13,13 +13,16 @@ description:
> >    Ambient light sensor with an i2c interface.
> >    Last part of compatible is for the packaging used.
> >    Picostar is a 4 pinned SMT and sot-5x3 is a 8 pinned SOT.
> > +  OPT4041 is only available as sot-5x3 and adds a wide band channel.
> 
> I guess we keep the compatible naming because some crazy
> person might one day release it in a different package.

Ye it is a bit weird. I did notice it but passed it off cos the
existing device was like that and there was a behavioural difference in
the driver between the two packages for the 4001. Maybe this fancy
picostarTM package is no longer a thing? Would really need to get
someone from TI to tell us what the plans are.

> 
> J
> >    https://www.ti.com/lit/gpn/opt4001
> > +  https://www.ti.com/lit/gpn/opt4041
> >  
> >  properties:
> >    compatible:
> >      enum:
> >        - ti,opt4001-picostar
> >        - ti,opt4001-sot-5x3
> > +      - ti,opt4041-sot-5x3
> >  
> >    reg:
> >      maxItems: 1
> > @@ -39,7 +42,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: ti,opt4001-sot-5x3
> > +            enum:
> > +              - ti,opt4001-sot-5x3
> > +              - ti,opt4041-sot-5x3
> >      then:
> >        properties:
> >          interrupts:
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]