Re: [PATCH net-next v3 1/5] dt-bindings: net: maxlinear: add MxL86211C VDDP supply

[Rob Herring <robh@kernel.org>]

On Tue, Oct 20, 2026 at 11:35:34AM +0200, Robert Marko wrote:
> Describe the optional VDDP supply used by the MxL86211C PHY. Its
> voltage determines whether the MDIO, MDC, and MDINT pads use 1.8 V or
> 3.3 V.
> 
> Existing device trees do not describe the supply and rely on the hardware
> reset default. Keep the property optional to preserve their compatibility.
> 
> Select the MxL86211C PHY ID and nodes using the existing MaxLinear
> broken-interrupt property, so this binding is checked during normal DT
> validation. Restrict the new supply property to the MxL86211C with the
> compatible conditional.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v3:
> - Make VDDP optional for existing device trees.
> - Select MxL86211C nodes and nodes using the legacy MaxLinear property.
> - Replace the empty then branch with a negated compatible condition.
> 
> Changes in v2:
> - Model VDDP as a supply instead of a regulator provider.
> - Select the schema for the MxL86211C PHY ID.
> 
>  .../bindings/net/maxlinear,gpy2xx.yaml        | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> index 8a3713abd1ca9..53f430e121510 100644
> --- a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> @@ -10,10 +10,37 @@ maintainers:
>    - Andrew Lunn <andrew@lunn.ch>
>    - Michael Walle <michael@walle.cc>
>  
> +select:
> +  anyOf:
> +    - properties:
> +        compatible:
> +          contains:
> +            const: ethernet-phy-idc133.5400
> +      required:
> +        - compatible
> +    - required:
> +        - maxlinear,use-broken-interrupts
> +
>  allOf:
>    - $ref: ethernet-phy.yaml#
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              const: ethernet-phy-idc133.5400
> +        required:
> +          - compatible
> +    then:
> +      properties:
> +        vddp-supply: false
>  
>  properties:
> +  vddp-supply:
> +    description: |

Don't need '|'.

> +      Optional regulator supplying the VDDP pin. Its voltage configures the
> +      MDIO, MDC, and MDINT pad voltage and must be either 1.8 V or 3.3 V.
> +
>    maxlinear,use-broken-interrupts:
>      description: |
>        Interrupts are broken on some GPY2xx PHYs in that they keep the
> @@ -45,4 +72,25 @@ examples:
>          };
>      };
>  
> +  - |
> +    vddp: regulator-vddp {
> +        compatible = "regulator-fixed";
> +        regulator-name = "vddp";
> +        regulator-min-microvolt = <1800000>;
> +        regulator-max-microvolt = <1800000>;
> +    };

Drop. Examples don't show providers.

> +
> +    ethernet {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy@0 {
> +            compatible = "ethernet-phy-idc133.5400",
> +                         "ethernet-phy-ieee802.3-c45";
> +            reg = <0>;
> +            vddp-supply = <&vddp>;
> +
> +        };
> +    };
> +
>  ...
> -- 
> 2.56.0
>