Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: Convert snps,dwc-qos-ethernet to DT schema
Date: Tue, 3 Nov 2026 14:49:07 -0600	[thread overview]
Message-ID: <20261103204907.GA3951195-robh@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-195992@kernel.org>

On Tue, Nov 03, 2026 at 08:34:17PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: net: snps,dwc-qos-ethernet-4.10: redundant maxItems on clocks
> --
> 
> commit ccf9541bde2e61e4e9ad2f4d7325ff792d7181d2
> Author: Rob Herring (Arm) <robh@kernel.org>
> 
> dt-bindings: net: Convert snps,dwc-qos-ethernet to DT schema
> 
> This commit converts the snps,dwc-qos-ethernet-4.10 binding to DT schema
> format and moves shared properties to snps,dwmac-common.yaml. It also drops
> unused compatibles and updates the example to use Tegra186.
> 
> [Severity: Low]
> In Documentation/devicetree/bindings/net/snps,dwc-qos-ethernet-4.10.yaml at
> line 39 under properties:clocks, maxItems: 5 is specified alongside a
> 5-element items list without additionalItems: true.
> 
> In the devicetree meta-schema (meta-schemas/items.yaml), when items is a
> fixed-order list, maxItems is implicitly set to the length of the items list
> and explicitly specifying maxItems is disallowed.
> 
> Does this cause dt_binding_check / dt-doc-validate to fail on
> properties:clocks:maxItems, and should maxItems: 5 be removed here?

Yes, I left this fix in my tree uncommitted before sending this...

pw-bot: cr

      reply	other threads:[~2026-11-03 20:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 20:33 [PATCH net-next] dt-bindings: net: Convert snps,dwc-qos-ethernet to DT schema Rob Herring (Arm)
2026-11-03 10:46 ` Thierry Reding
2026-11-03 20:34 ` sashiko-bot
2026-11-03 20:49   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103204907.GA3951195-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox