From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794398992; b=VmWDJFQMEVUbXdr88krjAtgrbQg+nFceIx605Ylldm74QwrsW+Pj8/3r/niBi5rSOVoN wz090yQ+NAzPpPWBTBbQuWwI0r8e85TnFY0jvafC1DLI/BLDWUdGc4+bI002qCVXEew+0 PaCfrLDg/yDRr9BDnIC7Zeo3WSq7PxrnabEhaSNrSWiAIaDIJ5bHEoTN+t9ATVaefAA0W z58s9AdNkOMbtqQJHesdehU5ad0pxwJkcmmmi3n73AAiamZSDOX1DSHbJjB1gWSOceGao bP6Dbw8o10KkkXMsXAWADOo86DijQaxpkwnsgk5hwy/6tYq305bk0huTKsNLxkqI+Cw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794398992; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: Content-Type:MIME-Version:Content-Transfer-Encoding; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=Pql9PDWv49ZSqIm9F/7nKYRoowJmggXj21661tEhDUUDRGGmeP35cDuJ9HltWN25H/Nv ov2ZYZA4q5e9WKE78y25kIhX2bumTPrb469IEIpXByAWR0Jy3C+SPVPHzDPDNhH7nZFQD KwKMOEBSM0aY8Q7Fafc8BHQ+ozxm+1MWcy3bmwtxj8RYaYo5YD+0XYFX45tpnGd6i/K5U Ilrupbi2iztlqPohKzl5gZhtLAQTad1czX+4uJl+IIHBVtaAvD6jHGgAijP9a9bTMpOq9 xV88RzpmPx7dViIEZWOzvry8a1nMW1tXO0QCckzaAdAyK7t40p7pKoTMQZtaNCT3CIA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=k5TWTw6+; arc=none smtp.remote-ip=209.85.167.182 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038B060A2602 for ; Wed, 11 Nov 2026 12:09:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 038B060A2602 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=k5TWTw6+ Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-539a57a0b1fso1188620b6e.2 for ; Wed, 11 Nov 2026 04:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794398991; x=1795003791; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=k5TWTw6+QRchA1PQTS6oYaZ4PuODw3xmmgrU9JTcYXc6nGWjpHL8uSg68S7qe7XTz2 oeqEBJrUspxe+o629HHec6dg4bPIG+7wI9+glwyPUFF/iYZxZjTqTO9QxjbzGSOjSONZ FEjhF/qIMBX10Evv376qVg5lfidCBavTyDN0E5tbzevNXotJVr33CrDxQ5FNkACBc/Y1 YXS/V0hJ6xz/e7KW2Dh5fsxDh14z4P7rhUrBnYunE/EF2M3y3pNUwpbMvxh40VwgBsCH CoyQuMqM1hyxsDn9wzJFA0cbjJKL9dsJRW1fIKpN1mNhQvI9PpYTrdPdKe0qq2X+aJiX QzRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794398991; x=1795003791; h=content-transfer-encoding:mime-version:content-type:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8kDTQyiKQOfIkOGO/u8mg2T8m6Y6HEmmU0F0HKV40UE=; b=zh2WkO7Um+WGkNFyXnmNdYBhKYYfggxbcKuca0pqTmLz2YA/ShuB7OggKExcph0lUK Zeg+sbnP2x2zCzLfbf0EtAwPMRPijqmGds5Q7wKwZL2rxFcRPZXRoOYYzwYvPIIZp0kw OjZghp4VKh2+bUfwhqTRvLilUwHPMEHrK9wlmcMTIIS6Hs8tuuibl4Mg/SmBMrzJQ7TJ WezOxMx7xr2sX/9NX8rmd+duzF/AWGQauxdk/WDYRz8aOZ/vxrwx+bt4yR8+NeT4JYgM oR96s/uAtcsahW0xiMwn15ATOCkQANgiKhxd4j3usx0yrdNuLlJu9i3/oUC9CbCKb1L9 aF4g== X-Forwarded-Encrypted: i=1; AL+hErHzyH4nI+EP89a/kG7vvmLtlwvkt0K0TGhlqfy4hVl5JBGNoQCbMO/j4fDW5QpQ8Ui/PQEqxyngEhFX@vger.kernel.org X-Gm-Message-State: APuU4Z9M41Om5Zls+13GENEo815TFIk8OwFgUCYYYbQ7pKqzgVhBP8p8 RrNk29OmIA76gfaxtK4JjqcSeHs9MywlIx8jbK5QzIx/HuJZn9ConPSY X-Gm-Gg: AYBFou01vpiEq5lDBSWkT2LZ3Avf5ddNYNRGU6e/9oGr/q6bY3CtNi+RUbsdD6tl4pA ZXakL+w/6/YN31sVE4D+oHmHMrDt9TV83Pio3GkbJP9LyfvFG1MI2SzrBjQZaloJx73+g/OwlvZ JbOw4uec2CEuLotQ/1/zkRhVbiVu3vn3HHMfBAkISSczEFfAdw7YNGrSsxIzCrA0BNq+8fOn0zC JiXHs3uf0spcIbE9mhYR9cuwmaIRDMlgvgRs10AmS9A2SBfpa57aCo7yz8n0Z95m5J7O9r5Lx40 YbbE95bKeIZGnXh0Y2L+oZ05UPtSbxxmAmZh1ho5nSIyZyngZGuIS3a9/KaRy1STFa94/Sk6x1G tkhyBkx9YegD+D01kguiuJbDJpxhNasBdFXmN/+ekq+PrsVnurWAAXFFSOj6P2Uhz911IBWK7jU TkXRkKrFGJSMaxfjG3uvw9FOo7oXTVVoaU0suZGPiqZ5lo24ZN/AoX1uJFBY0uYil52v6+9H9xG YSCsx/ugFkJvZbolJvDGib5KXlfsHCBtTIiFH9MwDMfxi9WFD+nhbIXk0eF89+BiV3B50lrt9va 1uvHUDsH0Xus8Zz0ylL5vD6K8wJWHh3gPUbl3rd3wc0s0Le/tyHC/DTtIqPDx5FXzyXrYw9JOGS OZvoe X-Received: by 2002:a05:6808:244f:b0:53b:1d13:dffd with SMTP id 5614622812f47-56b92c464dcmr1457460b6e.7.1794398990670; Wed, 11 Nov 2026 04:09:50 -0800 (PST) Received: from AMD.home.internal (dhcp-9-244-8-156.gobrightspeed.net. [9.244.8.156]) by smtp.gmail.com with ESMTPSA id 5614622812f47-5690504fdb5sm4958534b6e.3.2026.11.11.04.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 04:09:50 -0800 (PST) From: Enzo Adriano To: junhui.liu@pigmoral.tech Cc: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Richard Cochran , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, Jerome Brunet , Andre Przywara , Norman Herms , Vinicius Pedrosa Subject: Re: [PATCH v6 3/8] clk: sunxi-ng: a733: Add PRCM CCU Date: Wed, 11 Nov 2026 07:09:48 -0500 Message-ID: <20261110-a733-fwclk-junhui-reply@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: <20261009-a733-clk-v6-0-ae8178fce7e8@pigmoral.tech> <20261009-a733-clk-v6-3-ae8178fce7e8@pigmoral.tech> <20261103-a733-ccu-v6-fw-clocks@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Junhui, > I'd prefer not to mark these clocks as critical just for the vendor > firmware. You can see my reply in v5: I agree that native PSCI and a future OR100 Crust port are separate from the vendor SCP on E902, and that future E902 remoteproc/mailbox drivers should own these clocks. Vinicius's native-PSCI reboot report used locally modified TF-A on A7Z [1]. Upstream TF-A still has no A733 target; its port is under review [2]. The immediate problem is that the new CCU's unused-clock cleanup breaks reboot with the firmware these boards ship. On one Cubie A7S, RAM-booting v7.4-rc1 + CCU v6 + DT v3 and its dependencies with vendor boot0/BL31/SCP/U-Boot and no clk_ignore_unused, the run without critical flags stalled at reboot -f. With only bus-r-riscv and bus-r-msgbox critical, two warm reboots returned to vendor Linux while r-timer0, bus-r-timer and bus-msgbox0 were 0/0 (enable/prepare); five flags also passed once. > Since you've already submitted a separate patch adding these critical > flags, I'll leave that to you. I will narrow my separate patch [3] to bus-r-riscv and bus-r-msgbox. Chen-Yu, Jernej, Samuel: would you take these two flags as a separate patch until E902/mailbox drivers can own the clocks? There is precedent in A523 bus-r-cpucfg (1dba74abf3e2) and Meson AXG fclk_div3, kept critical for SCPI firmware until the driver claims its clocks and a handoff exists (drivers/clk/meson/axg.c). I have not tested power-off, suspend, either flag alone on A7S, or other boards or firmware; Vinicius found either flag alone insufficient on A7Z with vendor BL31 [4]. [1] https://lore.kernel.org/r/20261011200153.575096-1-vinicius.eduardo.pedrosa@gmail.com [2] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/55200 [3] https://lore.kernel.org/r/20261031020640-263f7b05-a7s-clock@gmail.com [4] https://lore.kernel.org/r/20261005183038.417798-1-vinicius.eduardo.pedrosa@gmail.com Thanks, Enzo