Devicetree
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: p.zabel@pengutronix.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	Frank.Li@nxp.com, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v2] dt-bindings: display: imx: Document fsl,pcr
Date: Mon,  9 Nov 2026 23:33:59 -0300	[thread overview]
Message-ID: <20261110023400.319579-1-festevam@gmail.com> (raw)

Some i.MX25 and i.MX27 devicetree display nodes contain fsl,pcr, but
the property has no schema type. As a result, dt-core.yaml reports
its raw bytes as an invalid property:

  imx27-phytec-phycard-s-rdk.dtb: display: fsl,pcr:
  b'\xf0\xc8\x80\x80' is not of type
  'object', 'integer', 'array', 'boolean', 'null'

Document fsl,pcr as a uint32. The property belongs to the display node
referenced by the display phandle and is not valid on the LCD controller
node.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Explicitly forbid fsl,pcr on the controller through allOf, addressing
  the Sashiko review, while retaining its uint32 type for decoding the
  property in legacy display nodes.

 .../devicetree/bindings/display/imx/fsl,imx-lcdc.yaml  | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml
index 84610b5690c4..450f95098c99 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml
@@ -65,7 +65,17 @@ properties:
     description:
       LCDC Sharp Configuration Register value.
 
+  fsl,pcr:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      LCDC Panel Configuration Register value used in the display node
+      referenced by the display property.
+
 allOf:
+  # Define the type above for decoding, but forbid it on the controller.
+  - properties:
+      fsl,pcr: false
+
   - if:
       properties:
         compatible:

             reply	other threads:[~2026-11-10  2:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  2:33 Fabio Estevam [this message]
2026-11-10 20:28 ` [PATCH v2] dt-bindings: display: imx: Document fsl,pcr Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110023400.319579-1-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox