From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794309280; b=Mp4j59YwQOeb0/aOAaR0JBTvgHCF+2NatI/q9gNPXGTKAVsIAiZMOAUuuwPbqNY8Bm2Q r+KMyQ9ZSABKDvOb7b5Jiw+zA37mGA3/d2ZoL28e31PJBgBQvOladCEg1Y053huZ4DoAS KohPQab+XCxjowA4BKcgWP0Q7fte0vcBPWM/9H21KQt4mX8j1QsXDCQa5krrS78Kuieja 1i+u639IVitn6GrakKnjEUOvLVGqBWwty6sFii56Nyus/uVI3NBh7YUVVzUW4dozrB1M3 rzUiaT8h6+alqw6RSTAMXF6+fniacYZljd5eaNVFxyA9DxSuvwIMgzVx0D353gpt8gA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794309280; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=l3e6BJpcy4ENagc1gj2ABLtN+NMWCeauT8N9Tc3xxgQ=; b=WjqyI50hkrPBXYp8kygLnA9nVxSgxTi5lx0AFzp5gWfX9sXNDew7hE77rfe5+fTYAGPc kP+WVaE5J1SdDrsGud5Uvz2ILN6CTVuVkGsyUTOymTUVRyF0mGSIfYBEnSRbTLWa5nf77 pZtigJnsqBvMjkEtB/3Kg946sOa+NBPjBsyfEUGTK4Pa9VuUAZPBDgt9KQphDwf4efAsp agRzkSJ/kLszrkRCwlhC+0JoW3aH9VHl30SU7yp/HAFVJC37Wdqou34CL1keMDjT2RA+a 2wRrVqrnnyhNSLygtMTj4Y9AnbZ/4ALB/gvJkPlKoe85e9QzafSxdLxaSbD1f44af9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Ae2KvmBo; arc=none smtp.remote-ip=209.85.216.41 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA4160A2617 for ; Tue, 10 Nov 2026 11:14:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8BA4160A2617 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Ae2KvmBo Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3b0b3438540so1157456a91.0 for ; Tue, 10 Nov 2026 03:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794309279; x=1794914079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l3e6BJpcy4ENagc1gj2ABLtN+NMWCeauT8N9Tc3xxgQ=; b=Ae2KvmBoitqU5gyYWcAFFAL+k9B6+yTy7RsSiYaYdLMPfcZ4GSy1dpnxS3L9HDIcAx 8RIFEqrN96lL5i4JPPXaHIG/8fkgNu5U6OIa6kZn315YdUc1Vdhb0/ZZw/zJd5wgs+l7 ciMvsmzIDFKqNZKK0yRYG1cjA3BaL+Y5qUWw0NznvyW52HQGEvlPaZIIN9frFYH1Qek/ ktfEX609svd0niBP7QIAGM8fM2IosgAnewOZ6K532Kv6uVhzjDYIgkkPy6Z5hmMIgUMS p4Yn372HpWwwlqC23GXvJXEaxQ7peLbcSPc4/Ei20WnmIGK0rlUbjvHSfGmfNluReT/r 09Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794309279; x=1794914079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=l3e6BJpcy4ENagc1gj2ABLtN+NMWCeauT8N9Tc3xxgQ=; b=ZW9htVJzn6YBybPV+aZvL2zV4gtrLDxYBqWCdfBdJOVMrMDP5IAb+JXUOslC4y90Cj lwkfufLFr+J0ihD1AlsIdrBIK1guIrnSb90ZfAPbA3CNmAwdXBZjnJraGf9T9jQdo59+ aKOrm85zSmdGpPVR7G0P5T9NelVY159VR4f6LXQXbwpysUqR9TJON9t4MC6tBlATRxLO 6mjhPc4lXNeglTPxzMIIS0e385A52pvYNcpVJHcMKx4MMZ/IoQkce+zPE/hfxZlooTWr 1alh1wxBo8NWqzcG0J9Hh4IJ3H+D7xXeT3PgZbUgvRnwn8Ver+evQQIRk5E2Z334PUEC 9e3Q== X-Forwarded-Encrypted: i=1; AL+hErE8RW0kfdUlOM/Wd35kLLeV27AgUtNDaZjVRgQRXX75t5L5m+KaS9+Sj1xVCPtGP8D0PH0T76ODDQqF@vger.kernel.org X-Gm-Message-State: APuU4Z8ZJ7IbUgYwMrVFi+USKZcefEadABgxQBwyy1aoZ22LDqsRNIQe KmGGdvdjrn+3GEH8vrevD5fITkUoAgE86bxvvXQGGrM3lcegZgUWEcnN X-Gm-Gg: AYBFou2RDkAZh/l66Iv66dOyj8xi5A7IluQPZL8PGW/dEK63HNQ42Z6QTFui86cWD1Q e/bCctbn+R+Sn4GJcYL18hwhMH0CjTvZj9TQanjeceqYpbbsRiLEaHgawgEIoehqvLB/yjXpWSB 97nQKX3/rSZxdm85OnOLLvRQXp2Zs93LPWtaceTwsuT02aJJ48Bym0HIqzxcbOnLhgLmBuYFU8k 2OvrR28h28v/hXCywQmYrwlANL+oY0PaxoT/DddU+sHLenoidJTxwk7BHQ/zL8GWkZ4TdQtFqRy eQOubSB1w2na1JVDl1FFIb3tJ5bqc1+U+H6BdUitPmjC0h41SZeWNOJgZk2n4O0w45apwVaziAV bntzGSxDHG1E3HgdJ5Lrs3uH5bjtraBOXrvYpnru2SH8zNzmwlBOHbOyXmxu5X4AdKI1qGFyKrY NU2QXd9/uGEOzTp693BEGChpRdYW54/hhUjpnmeer1GmmZghZFyNqZk5Urw5HiilC+aVeFYgYed 4trMTCJ5PtonTiGs+MkDMTZ4hPprYQIxBwC+cxkZ+UdYPDMI7Yy9m+pdnyQwqA+RsCibFeaU8wD S9ppBiLdTkXtQau7/MyU0rTN2ojIxal5jETd77xU127Jc7zBkNBuQLm9Lls/ZhboZ9YdnnZn+WQ e+9CU X-Received: by 2002:a17:90b:578f:b0:3b0:9cc6:62c1 with SMTP id 98e67ed59e1d1-3b166e36e6fmr2378320a91.63.1794309278790; Tue, 10 Nov 2026 03:14:38 -0800 (PST) Received: from fyhsueh.. (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b1678ceda0sm3556684a91.5.2026.11.10.03.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 03:14:38 -0800 (PST) From: Feng-Yi Hsueh To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Jacky Huang , Shan-Chun Hung , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Feng-Yi Hsueh Subject: [PATCH v1 2/2] Input: keyboard: Add Nuvoton MA35D1 keypad driver Date: Tue, 10 Nov 2026 19:14:19 +0800 Message-ID: <20261110111419.89535-3-fyhsueh4linux@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261110111419.89535-1-fyhsueh4linux@gmail.com> References: <20261110111419.89535-1-fyhsueh4linux@gmail.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for the Nuvoton MA35D1 hardware matrix keypad controller. The driver handles key press and release interrupts, reports key events through the Linux input subsystem, and manages the peripheral clock during device open, close, and system suspend and resume. Signed-off-by: Feng-Yi Hsueh --- drivers/input/keyboard/Kconfig | 11 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/ma35d1_keypad.c | 405 +++++++++++++++++++++++++ 3 files changed, 417 insertions(+) create mode 100644 drivers/input/keyboard/ma35d1_keypad.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index d8c64f333462..9bbcbed3d494 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -358,6 +358,17 @@ config KEYBOARD_LPC32XX To compile this driver as a module, choose M here: the module will be called lpc32xx-keys. +config KEYBOARD_MA35D1 + tristate "Nuvoton MA35D1 keypad controller" + depends on ARCH_MA35 || COMPILE_TEST + select INPUT_MATRIXKMAP + help + Say Y here to enable support for the Nuvoton MA35D1 + hardware matrix keypad controller. + + To compile this driver as a module, choose M here. + The module will be called ma35d1_keypad. + config KEYBOARD_MAPLE tristate "Maple bus keyboard" depends on SH_DREAMCAST && MAPLE diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index 60bb7baf802f..fad34b7afff7 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -39,6 +39,7 @@ obj-$(CONFIG_KEYBOARD_LM8323) += lm8323.o obj-$(CONFIG_KEYBOARD_LM8333) += lm8333.o obj-$(CONFIG_KEYBOARD_LOCOMO) += locomokbd.o obj-$(CONFIG_KEYBOARD_LPC32XX) += lpc32xx-keys.o +obj-$(CONFIG_KEYBOARD_MA35D1) += ma35d1_keypad.o obj-$(CONFIG_KEYBOARD_MAPLE) += maple_keyb.o obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o diff --git a/drivers/input/keyboard/ma35d1_keypad.c b/drivers/input/keyboard/ma35d1_keypad.c new file mode 100644 index 000000000000..673ad8b9704b --- /dev/null +++ b/drivers/input/keyboard/ma35d1_keypad.c @@ -0,0 +1,405 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Nuvoton MA35D1 hardware matrix keypad controller + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MA35D1_KPI_CONF 0x00 +#define MA35D1_KPI_3KCONF 0x04 +#define MA35D1_KPI_STATUS 0x08 +#define MA35D1_KPI_KEST0 0x10 +#define MA35D1_KPI_KPE0 0x18 +#define MA35D1_KPI_KRE0 0x20 +#define MA35D1_KPI_PRESCALDIV 0x28 + +#define MA35D1_KPI_KROW GENMASK(30, 28) +#define MA35D1_KPI_KCOL GENMASK(26, 24) +#define MA35D1_KPI_DBCLKSEL GENMASK(19, 16) +#define MA35D1_KPI_PRESCALE GENMASK(15, 8) +#define MA35D1_KPI_INTEN BIT(3) +#define MA35D1_KPI_RKINTEN BIT(2) +#define MA35D1_KPI_PKINTEN BIT(1) +#define MA35D1_KPI_ENKP BIT(0) + +#define MA35D1_KPI_RST3KEY BIT(1) +#define MA35D1_KPI_PDWAKE BIT(0) +#define MA35D1_KPI_IRQ_MASK GENMASK(4, 0) + +#define MA35D1_KPI_MAX_ROWS 8 +#define MA35D1_KPI_MAX_COLS 8 +#define MA35D1_KPI_BANKS 2 +#define MA35D1_KPI_ROWS_PER_BANK (MA35D1_KPI_MAX_ROWS / MA35D1_KPI_BANKS) + +/* + * Scan timing, in KPI engine clock cycles. PRESCALE and PRESCALDIV are + * encoded as the count minus one: + * + * row scan cycles = (PRESCALE + 1) * (PRESCALDIV + 1) = 2080 + * debounce sample cycles = 2^DBCLKSEL = 1024 + * + * With SCANROWD at its reset value (4 cycles) the TRM requires + * row scan time > 4 + 2 * 1024 + 3 = 2055 cycles. These limits are expressed + * in cycles and therefore hold at different input rates. The actual scan + * and debounce intervals depend on the engine clock rate; boards should + * select a rate suitable for their switches (1 MHz has been validated). + */ +#define MA35D1_KPI_PRESCALE_VAL 0x40 +#define MA35D1_KPI_DIV_VAL 0x1f +#define MA35D1_KPI_DEBOUNCE_SEL 10 + +struct ma35d1_keypad { + void __iomem *base; + struct clk *clk; + struct input_dev *input; + unsigned short *keycodes; + unsigned int rows; + unsigned int cols; + unsigned int row_shift; + u32 conf; + int irq; + bool running; /* protected by input->mutex */ +}; + +static void ma35d1_keypad_clear_events(struct ma35d1_keypad *keypad) +{ + unsigned int bank; + u32 press, release; + + for (bank = 0; bank < MA35D1_KPI_BANKS; bank++) { + press = readl(keypad->base + MA35D1_KPI_KPE0 + bank * 4); + release = readl(keypad->base + MA35D1_KPI_KRE0 + bank * 4); + /* The event registers are write-one-to-clear. */ + if (press) + writel(press, keypad->base + MA35D1_KPI_KPE0 + bank * 4); + if (release) + writel(release, keypad->base + MA35D1_KPI_KRE0 + bank * 4); + } + + /* Only these two KPISTATUS flags have W1C semantics. */ + writel(MA35D1_KPI_RST3KEY | MA35D1_KPI_PDWAKE, + keypad->base + MA35D1_KPI_STATUS); +} + +/* Release software key states when hardware scanning is stopped. */ +static void ma35d1_keypad_release_keys(struct ma35d1_keypad *keypad) +{ + struct input_dev *input = keypad->input; + unsigned int row, col, scan, code; + bool reported = false; + + for (row = 0; row < keypad->rows; row++) { + for (col = 0; col < keypad->cols; col++) { + scan = MATRIX_SCAN_CODE(row, col, keypad->row_shift); + code = keypad->keycodes[scan]; + if (code == KEY_RESERVED || !test_bit(code, input->key)) + continue; + + input_event(input, EV_MSC, MSC_SCAN, scan); + input_report_key(input, code, 0); + reported = true; + } + } + + if (reported) + input_sync(input); +} + +/* Called with input->mutex held (open, PM resume). */ +static int ma35d1_keypad_enable(struct ma35d1_keypad *keypad) +{ + int ret; + + if (keypad->running) + return 0; + + ret = clk_prepare_enable(keypad->clk); + if (ret) + return ret; + + /* Keep hardware three-key reset disabled for a normal input device. */ + writel(0, keypad->base + MA35D1_KPI_CONF); + writel(0, keypad->base + MA35D1_KPI_3KCONF); + writel(MA35D1_KPI_DIV_VAL, keypad->base + MA35D1_KPI_PRESCALDIV); + ma35d1_keypad_clear_events(keypad); + writel(keypad->conf, keypad->base + MA35D1_KPI_CONF); + + keypad->running = true; + enable_irq(keypad->irq); + + return 0; +} + +/* Called with input->mutex held (close, PM suspend). */ +static void ma35d1_keypad_disable(struct ma35d1_keypad *keypad) +{ + if (!keypad->running) + return; + + /* Wait for the IRQ handler while register access is still clocked. */ + disable_irq(keypad->irq); + writel(0, keypad->base + MA35D1_KPI_CONF); + ma35d1_keypad_clear_events(keypad); + ma35d1_keypad_release_keys(keypad); + clk_disable_unprepare(keypad->clk); + + keypad->running = false; +} + +static int ma35d1_keypad_open(struct input_dev *input) +{ + struct ma35d1_keypad *keypad = input_get_drvdata(input); + + return ma35d1_keypad_enable(keypad); +} + +static void ma35d1_keypad_close(struct input_dev *input) +{ + struct ma35d1_keypad *keypad = input_get_drvdata(input); + + ma35d1_keypad_disable(keypad); +} + +static void ma35d1_keypad_report(struct ma35d1_keypad *keypad, + unsigned int scan, unsigned short keycode, + bool pressed) +{ + input_event(keypad->input, EV_MSC, MSC_SCAN, scan); + input_report_key(keypad->input, keycode, pressed); +} + +static irqreturn_t ma35d1_keypad_irq(int irq, void *data) +{ + struct ma35d1_keypad *keypad = data; + struct input_dev *input = keypad->input; + bool reported = false; + u32 status, pressed, released, events, state; + unsigned int bank, bit, row, col, scan; + unsigned short keycode; + bool key_is_up; + + status = readl(keypad->base + MA35D1_KPI_STATUS); + if (!(status & MA35D1_KPI_IRQ_MASK)) + return IRQ_NONE; + + for (bank = 0; bank < MA35D1_KPI_BANKS; bank++) { + pressed = readl(keypad->base + MA35D1_KPI_KPE0 + bank * 4); + released = readl(keypad->base + MA35D1_KPI_KRE0 + bank * 4); + + /* Acknowledge the exact snapshots, not KPISTATUS[4:2]. */ + if (pressed) + writel(pressed, keypad->base + MA35D1_KPI_KPE0 + bank * 4); + if (released) + writel(released, keypad->base + MA35D1_KPI_KRE0 + bank * 4); + + events = pressed | released; + if (!events) + continue; + + /* The live state is only needed to order a press/release pair. */ + state = 0; + if (pressed & released) + state = readl(keypad->base + MA35D1_KPI_KEST0 + bank * 4); + + while (events) { + bit = __ffs(events); + events &= ~BIT(bit); + row = bank * MA35D1_KPI_ROWS_PER_BANK + + bit / MA35D1_KPI_MAX_COLS; + col = bit % MA35D1_KPI_MAX_COLS; + + if (row >= keypad->rows || col >= keypad->cols) + continue; + + scan = MATRIX_SCAN_CODE(row, col, keypad->row_shift); + keycode = keypad->keycodes[scan]; + if (keycode == KEY_RESERVED) + continue; + + if ((pressed & released) & BIT(bit)) { + /* + * Both edges were latched before this interrupt + * was serviced. KEST is active-low (1 means + * released), so use the final state to order + * them: up -> press then release, down -> + * release then press. Sync in between so user + * space sees two separate frames. + */ + key_is_up = !!(state & BIT(bit)); + + ma35d1_keypad_report(keypad, scan, keycode, + key_is_up); + input_sync(input); + ma35d1_keypad_report(keypad, scan, keycode, + !key_is_up); + } else { + ma35d1_keypad_report(keypad, scan, keycode, + !!(pressed & BIT(bit))); + } + reported = true; + } + } + + if (status & (MA35D1_KPI_RST3KEY | MA35D1_KPI_PDWAKE)) + writel(status & (MA35D1_KPI_RST3KEY | MA35D1_KPI_PDWAKE), + keypad->base + MA35D1_KPI_STATUS); + + if (reported) + input_sync(input); + + return IRQ_HANDLED; +} + +static int ma35d1_keypad_suspend(struct device *dev) +{ + struct ma35d1_keypad *keypad = dev_get_drvdata(dev); + struct input_dev *input = keypad->input; + + mutex_lock(&input->mutex); + if (input_device_enabled(input)) + ma35d1_keypad_disable(keypad); + mutex_unlock(&input->mutex); + + return 0; +} + +static int ma35d1_keypad_resume(struct device *dev) +{ + struct ma35d1_keypad *keypad = dev_get_drvdata(dev); + struct input_dev *input = keypad->input; + int ret = 0; + + mutex_lock(&input->mutex); + if (input_device_enabled(input)) + ret = ma35d1_keypad_enable(keypad); + mutex_unlock(&input->mutex); + + return ret; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(ma35d1_keypad_pm_ops, + ma35d1_keypad_suspend, ma35d1_keypad_resume); + +static int ma35d1_keypad_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct ma35d1_keypad *keypad; + struct input_dev *input; + int ret; + + keypad = devm_kzalloc(dev, sizeof(*keypad), GFP_KERNEL); + if (!keypad) + return -ENOMEM; + + ret = matrix_keypad_parse_properties(dev, &keypad->rows, &keypad->cols); + if (ret) + return ret; + + /* The controller supports 2x1 up to 8x8 keys (KROW = 0 is reserved). */ + if (keypad->rows < 2 || keypad->rows > MA35D1_KPI_MAX_ROWS || + !keypad->cols || keypad->cols > MA35D1_KPI_MAX_COLS) + return dev_err_probe(dev, -EINVAL, "invalid keypad geometry\n"); + + keypad->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(keypad->base)) + return PTR_ERR(keypad->base); + + keypad->clk = devm_clk_get(dev, NULL); + if (IS_ERR(keypad->clk)) + return dev_err_probe(dev, PTR_ERR(keypad->clk), + "failed to get KPI clock\n"); + + keypad->irq = platform_get_irq(pdev, 0); + if (keypad->irq < 0) + return keypad->irq; + + input = devm_input_allocate_device(dev); + if (!input) + return -ENOMEM; + + keypad->input = input; + keypad->row_shift = get_count_order(keypad->cols); + keypad->conf = FIELD_PREP(MA35D1_KPI_KROW, keypad->rows - 1) | + FIELD_PREP(MA35D1_KPI_KCOL, keypad->cols - 1) | + FIELD_PREP(MA35D1_KPI_DBCLKSEL, MA35D1_KPI_DEBOUNCE_SEL) | + FIELD_PREP(MA35D1_KPI_PRESCALE, MA35D1_KPI_PRESCALE_VAL) | + MA35D1_KPI_INTEN | MA35D1_KPI_RKINTEN | + MA35D1_KPI_PKINTEN | MA35D1_KPI_ENKP; + + input->name = "Nuvoton MA35D1 Keypad"; + input->id.bustype = BUS_HOST; + input->open = ma35d1_keypad_open; + input->close = ma35d1_keypad_close; + + ret = matrix_keypad_build_keymap(NULL, NULL, keypad->rows, + keypad->cols, NULL, input); + if (ret) + return dev_err_probe(dev, ret, "failed to build keymap\n"); + + keypad->keycodes = input->keycode; + input_set_capability(input, EV_MSC, MSC_SCAN); + if (device_property_read_bool(dev, "autorepeat")) + __set_bit(EV_REP, input->evbit); + + input_set_drvdata(input, keypad); + platform_set_drvdata(pdev, keypad); + + /* + * Clear whatever the bootloader left behind before the IRQ can be + * requested. The clock must run for the registers to be accessible. + */ + ret = clk_prepare_enable(keypad->clk); + if (ret) + return dev_err_probe(dev, ret, "failed to enable KPI clock\n"); + + writel(0, keypad->base + MA35D1_KPI_CONF); + ma35d1_keypad_clear_events(keypad); + + clk_disable_unprepare(keypad->clk); + + /* The IRQ stays disabled while the peripheral clock is gated. */ + ret = devm_request_irq(dev, keypad->irq, ma35d1_keypad_irq, + IRQF_NO_AUTOEN, dev_name(dev), keypad); + if (ret) + return dev_err_probe(dev, ret, "failed to request IRQ\n"); + + ret = input_register_device(input); + if (ret) + return dev_err_probe(dev, ret, "failed to register input device\n"); + + return 0; +} + +static const struct of_device_id ma35d1_keypad_of_match[] = { + { .compatible = "nuvoton,ma35d1-keypad" }, + { } +}; +MODULE_DEVICE_TABLE(of, ma35d1_keypad_of_match); + +static struct platform_driver ma35d1_keypad_driver = { + .probe = ma35d1_keypad_probe, + .driver = { + .name = "ma35d1-keypad", + .of_match_table = ma35d1_keypad_of_match, + .pm = pm_sleep_ptr(&ma35d1_keypad_pm_ops), + }, +}; +module_platform_driver(ma35d1_keypad_driver); + +MODULE_DESCRIPTION("Nuvoton MA35D1 hardware matrix keypad controller"); +MODULE_LICENSE("GPL"); -- 2.43.0