From: Joonhoe Kim <26rote@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: sashiko-bot@kernel.org, Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: kaanapali: Mark the USB controller as a Type-C mode switch
Date: Thu, 12 Nov 2026 20:40:04 +0900 [thread overview]
Message-ID: <20261112114004.182-1-26rote@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-195550@kernel.org>
On Tue, 03 Nov 2026 15:05:12 +0000, sashiko-bot@kernel.org wrote:
> [Severity: Medium]
> Can enabling mode-switch on the Kaanapali USB controller trigger a race
> between dwc3_qcom_mux_set() and system suspend/resume in
> drivers/usb/dwc3/dwc3-qcom.c?
[...]
Yes. This is the same race as in your review of patch 2, and the fix
is in the driver. In v3 the mux callback no longer resumes the glue.
From the start of a runtime or system suspend until the core has
resumed, it only records the state. dwc3_qcom_resume() applies it
before the core resumes. v3 also compares with the clock selected in
QSCRATCH instead of a cached value, so a selection lost with QSCRATCH
in system suspend is restored on resume.
As Krzysztof asked, the DTS patch is now sent on its own:
https://lore.kernel.org/all/20261112113921.1143-1-26rote@gmail.com/
Thanks,
Joonhoe Kim
next prev parent reply other threads:[~2026-11-12 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 13:50 [PATCH v2 0/3] usb: dwc3: qcom: Keep USB 2.0 working in DisplayPort-only modes Joonhoe Kim
2026-11-03 13:50 ` [PATCH v2 1/3] dt-bindings: usb: qcom,snps-dwc3: Add mode-switch Joonhoe Kim
2026-11-04 13:13 ` Krzysztof Kozlowski
2026-11-07 2:12 ` Joonhoe Kim
2026-11-03 13:50 ` [PATCH v2 2/3] usb: dwc3: qcom: Use the UTMI clock as PIPE clock in DisplayPort-only modes Joonhoe Kim
2026-11-03 14:35 ` sashiko-bot
2026-11-12 11:39 ` Joonhoe Kim
2026-11-03 13:50 ` [PATCH v2 3/3] arm64: dts: qcom: kaanapali: Mark the USB controller as a Type-C mode switch Joonhoe Kim
2026-11-03 15:05 ` sashiko-bot
2026-11-12 11:40 ` Joonhoe Kim [this message]
2026-11-04 8:12 ` Krzysztof Kozlowski
2026-11-12 1:23 ` [PATCH v2 0/3] usb: dwc3: qcom: Keep USB 2.0 working in DisplayPort-only modes Thinh Nguyen
2026-11-12 11:40 ` Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112114004.182-1-26rote@gmail.com \
--to=26rote@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox