Re: [PATCH v8 1/5] dt-bindings: crypto: add Rambus CryptoManager Hub

[Rob Herring <robh@kernel.org>]

On Tue, Nov 10, 2026 at 05:20:21PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Medium] dt-bindings: crypto: rambus,cmh-v1030: invalid unit suffix
>   and $ref on rambus,slot-stride-bytes
> --
> 
> commit fe48437ab6a40e215371f9ad1c5f69cf88124d19
> Author: Alex Ousherovitch <aousherovitch@rambus.com>
> 
> dt-bindings: crypto: add Rambus CryptoManager Hub
> 
> This commit adds the device tree binding schema for the Rambus
> CryptoManager Hub hardware crypto accelerator and registers the rambus
> vendor prefix.
> 
> > diff --git a/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml b/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml
> > new file mode 100644
> > index 0000000000000..eef82c2d71794
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml
> > @@ -0,0 +1,145 @@
> 
> [ ... ]
> 
> > +      rambus,slot-stride-bytes:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        enum: [512, 1024]
> > +        default: 512
> > +        description:
> > +          Stride in bytes between consecutive VCQ ring slots for this
> > +          mailbox's command queue.  Like rambus,num-slots this is a
> > +          per-board host-memory ring geometry, not derived from the
> > +          compatible.  A slot must hold a complete command sequence,
> > +          which needs at least 512 bytes.
> 
> [Severity: Medium]
> Does rambus,slot-stride-bytes cause make dt_binding_check to fail?
> 
> In dtschema (meta-schemas/vendor-props.yaml), the -bytes unit suffix is
> deprecated and disallowed on vendor properties, and properties using a
> standard unit suffix already have their uint32 type assigned by the core
> schema and must not specify $ref: /schemas/types.yaml#/definitions/uint32.

That's got to be the worst hallucination I've seen from sashiko. There 
is no -bytes suffix.

Rob