Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support

[Yixun Lan <dlan@kernel.org>]

Hi Sandie,

On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
> 
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> ---
>  .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> index bcd533484a73..051046fe90b2 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> @@ -177,6 +177,28 @@ &combophy {
>  	status = "okay";
>  };
>  
..
> +/*
> + * Onboard SD card slot:
> + * Please insert or remove the SD card while the device is powered off.
> + * It works as a boot media. so set it to non-removable.
> + */
Is there any public schematic available for FML13V05? I guess there is
no CD pin (Card Detect pin)? as no "cd-gpios" property seen here

The above comment isn't really useful or even correct, I'd suggest
drop it.

> +&sdhci0 {
> +	pinctrl-names = "default","uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;
> +	bus-width = <4>;
..
> +	non-removable;
"no-removable" property usually used for emmc chip soldered on board,
 so there is no way it can be physically removed.. check 
Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml

For cases that no CD pin (or no GPIO CD pin) designed for SD card from
hardware schematic perspective, using "broken-cd" is a more proper way,
it will fallback to use poll mechanism to detect the card, please check

> +	no-mmc;
> +	no-sdio;
> +	disable-wp;
> +	cap-sd-highspeed;
> +	vqmmc-supply = <&aldo1>;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_0_cfg>;
> -- 
> 2.43.0

-- 
Yixun Lan (dlan)