Devicetree
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v7 2/2] scsi: ufs: spacemit: k3: Add UFS Host Controller driver
Date: Mon, 16 Nov 2026 03:33:11 +0000	[thread overview]
Message-ID: <20261116033311-GKD100523@kernel.org> (raw)
In-Reply-To: <20261002091428.35D671F0089B@smtp.kernel.org>

hi all,

On 09:14 Fri 02 Oct     , sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [Medium] scsi: ufs: spacemit: 100ms timeout on 1-lane UFS devices during hibern8
> - [Medium] scsi: ufs: spacemit: bRefClkGatingWaitTime violation after hibern8 enter
> - [Medium] scsi: ufs: spacemit: simultaneous ref clock enable and reset de-assertion
> --
> 
> commit efcda2c96a818b5a53e91fa2558654c937a9ba68
> Author: Yixun Lan <dlan@kernel.org>
> 
> scsi: ufs: spacemit: k3: Add UFS Host Controller driver
> 
> This commit introduces the UFS Host Controller driver for the SpacemiT K3
> SoC. It implements support for features compatible with JEDEC UFS 2.2, MIPI
> UniPro v1.61, and the M-PHY v3.0 standard.
> 
> > diff --git a/drivers/ufs/host/ufs-spacemit.c b/drivers/ufs/host/ufs-spacemit.c
> > new file mode 100644
> > --- /dev/null
> > +++ b/drivers/ufs/host/ufs-spacemit.c
> 
> [ ... ]
> 
> > +static int ufs_spacemit_check_hibern8(struct ufs_hba *hba)
> > +{
> > +	u32 tx_fsm_val_0 = 0;
> > +	u32 tx_fsm_val_1 = 0;
> > +	int retries = DIV_ROUND_UP(HBRN8_POLL_TOUT_MS * 1000, 100);
> > +	int err = 0;
> > +
> > +	do {
> > +		err = ufshcd_dme_get(hba,
> > +				     UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE,
> > +						     UIC_ARG_MPHY_TX_GEN_SEL_INDEX(0)),
> > +				     &tx_fsm_val_0);
> > +		if (err)
> > +			break;
> > +
> > +		err = ufshcd_dme_get(hba,
> > +				     UIC_ARG_MIB_SEL(MPHY_TX_FSM_STATE,
> > +						     UIC_ARG_MPHY_TX_GEN_SEL_INDEX(1)),
> > +				     &tx_fsm_val_1);
> > +		if (err || (tx_fsm_val_0 == TX_FSM_HIBERN8 &&
> > +			    tx_fsm_val_1 == TX_FSM_HIBERN8))
> > +			break;
> 
> [Severity: Medium]
> Will this loop always hit its 100ms timeout on 1-lane UFS devices?
> 
> It appears that on a 1-lane device, the state for lane 1 will not reach
> TX_FSM_HIBERN8, causing the do-while condition to wait until retries run out
> before proceeding.
> 
Currently, we have not seen any use case with 1-lane device,
it seems a false report, or even people do have concern? then I
would still prefer to address it in a separate patch..

> 
> > +static int ufs_spacemit_device_reset(struct ufs_hba *hba)
> > +{
> > +	/* Disable reference clock & asserted ufs device reset */
> > +	ufshcd_writel(hba, 0x000, UFS_PHY_MNG_BASE + UFS_DEVICE_IO_CTRL);
> > +	usleep_range(10, 15);
> > +
> > +	/* Enable reference clock & deassert ufs device reset */
> > +	ufshcd_writel(hba, MPHY_DEVICE_REFCLK_OE | MPHY_DEVICE_HW_RESET,
> > +		      UFS_PHY_MNG_BASE + UFS_DEVICE_IO_CTRL);
> 
> [Severity: Medium]
> Could toggling the reference clock output enable and device reset
> de-assertion in a single MMIO write cause device initialization failures?
> 
> The UFS specification (e.g., JESD220C 5.3.1.2) typically requires the
> reference clock to be valid and stable before RST_n is de-asserted. Writing
> MPHY_DEVICE_REFCLK_OE and MPHY_DEVICE_HW_RESET simultaneously might violate
> this sequential stability requirement.
> 
From the testing, It works so far, but I'd add a delay for safe..

> [ ... ]
> 
> > +static void ufs_spacemit_post_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd)
> > +{
> 
> [ ... ]
> 
> > +	if (cmd == UIC_CMD_DME_HIBER_ENTER) {
> > +		err = ufs_spacemit_check_hibern8(hba);
> > +		if (err)
> > +			dev_err(hba->dev, "ufs_spacemit_check_hibern8 error\n");
> > +
> > +		ufs_spacemit_dme_set(hba, setup_attrs, ARRAY_SIZE(setup_attrs));
> > +
> > +		/* Power down M-PHY */
> > +		ufshcd_writel(hba, 0x0, UFS_PHY_MNG_BASE + UFS_MPHY_PU_CTRL);
> > +
> > +		/* Disable reference clock, keep device reset deasserted */
> > +		ufshcd_writel(hba, MPHY_DEVICE_HW_RESET,
> > +			      UFS_PHY_MNG_BASE + UFS_DEVICE_IO_CTRL);
> > +	}
> > +}
> 
> [Severity: Medium]
> Does disabling the reference clock immediately after confirming HIBERN8
> enter violate the device's clock gating wait time?
> 
> By not waiting for hba->dev_info.clk_gating_wait_us (bRefClkGatingWaitTime)
> before disabling the clock, this could potentially cause strict UFS devices
> to hang or fail internal state transitions during hibernation.
> 
bRefClkGatingWaitTime is a feature introduced after UFS 3.0, while it's
UFS 2.2 device used in K3 platform, but I agree to add a delay.

-- 
Yixun Lan (dlan)

  reply	other threads:[~2026-11-16  3:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  3:10 [PATCH v7 0/2] Add UFS Host driver support for SpacemiT K3 SoC Yixun Lan
2026-10-02  3:10 ` [PATCH v7 1/2] scsi: ufs: spacemit: dt-bindings: Add UFS controller for " Yixun Lan
2026-10-02  3:10 ` [PATCH v7 2/2] scsi: ufs: spacemit: k3: Add UFS Host Controller driver Yixun Lan
2026-10-02  9:14   ` sashiko-bot
2026-11-16  3:33     ` Yixun Lan [this message]
2026-11-02 14:22   ` Trevor Gamblin
2026-10-30 17:19 ` [PATCH v7 0/2] Add UFS Host driver support for SpacemiT K3 SoC Trevor Gamblin
2026-11-02  7:43   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116033311-GKD100523@kernel.org \
    --to=dlan@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox