From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=46.4.11.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794851347; b=dPB4wdeB3Q/kyKr4sm8NblRT3cpYTMT2c/d3YtSDcA+pmHCGrqDRPCKHp8kRrPhdpSm2 BydULFoxovgRzc56nbcS5jQTHyySQ4MWPXRvAP/St7AL8ts4xsoyTr17kbrLFpzMHFdyL J2N/W/Qkaz7Nmi8DCT4er42GT0VnyjQE+o9D1jTg1l/vgUz4pyGHC4uWIEgOgM5gVwwbv L0hUreZ+PoeDG6JRS1SIdKOx7OSuu9zlwdU6xtto8ibFnAeP8nrEY7EDlDvKnFB3tDo7A A6BNAfmttRRgn5emokx1tEZ/PL7w8S9eoGxGfCzGT+/sq8ytUicTLHTcWPkylqHquIA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794851347; h=DMARC-Filter:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=VnTvx0GHqprjV0jATOCw+lQO2w4dk7eCKRn9t+F+QuY=; b=IKopKyVqKEGYowwtCHk9RCf3UPh18UCaMQL+HPWz4ryTfoxESkE0fOYDY6Q3iPRv/KBt 0XTZTIPJayx5e5VX4GxcT0fN3hBRC4AoxbLaN3tG09b76oEWRnU5ZLyVNwRsNC6aml6Al 8aPxW3CQzgN7hfMYfXe5QIMyKOK1adeuWseJQn5laNVUiFObjJlQglfHJVCTC/PQtvMrF 5UFX8MVrXoLRLmZgAyBxLYm6ypqfbWr4bi6arjPaBVvFvs4vNVYa5835rBzANY5h1dhef 5vVvxqR4anMoarYhAclwwwpyhtEZ6i8YmMUoS4MCi9OkqidywTj4J/Ge5jCgtKA1k1Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=phrozen.org; spf=pass smtp.mailfrom=phrozen.org; arc=none smtp.remote-ip=46.4.11.11 Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7846D606A31C; Mon, 16 Nov 2026 17:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7846D606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=phrozen.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=phrozen.org Received: from [2a04:4540:1403:e6fc:5f71:2c1e:7d62:945f] (helo=bertha10..) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT0pC-004GcH-1C; Mon, 16 Nov 2026 18:49:02 +0100 From: John Crispin To: Lorenzo Bianconi , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski Cc: Ahmed Naseef , Benjamin Larsson , Christian Marangi , devicetree@vger.kernel.org, lei.dong@airoha.com, Linqi.zhang@airoha.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, mfd@lists.linux.dev, Mikhail Kshevetskiy , Rajeev.kumar@airoha.com, upstream@airoha.com, Weifeng.xu@airoha.com, zhengping.zhang@airoha.com Subject: [PATCH v3 3/9] pinctrl: airoha: make the chip SCU optional Date: Mon, 16 Nov 2026 18:48:48 +0100 Message-Id: <20261116174854.342912-4-john@phrozen.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261116174854.342912-1-john@phrozen.org> References: <20261116174854.342912-1-john@phrozen.org> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A SoC that muxes every pin through the IOMUX block and describes no pin configuration has no use for the chip SCU. Skip the lookup when the match data names no chip SCU compatible, instead of handing a NULL compatible to syscon_regmap_lookup_by_compatible(). No functional change for the existing SoCs, which all name one. Reviewed-by: Lorenzo Bianconi Signed-off-by: John Crispin --- Changes in v3: - Add the Reviewed-by of Lorenzo. Changes in v2: - Look up the airoha,chip-scu phandle before the check for a chip SCU compatible (Lorenzo). drivers/pinctrl/airoha/pinctrl-airoha.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c index f9ae4020b764..5ae0c49e491a 100644 --- a/drivers/pinctrl/airoha/pinctrl-airoha.c +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c @@ -833,6 +833,22 @@ static const struct pinctrl_ops airoha_pctlops = { .dt_free_map = pinconf_generic_dt_free_map, }; +static struct regmap * +airoha_pinctrl_chip_scu(struct device *dev, + const struct airoha_pinctrl_match_data *data) +{ + struct regmap *map; + + map = syscon_regmap_lookup_by_phandle(dev->of_node, "airoha,chip-scu"); + if (!IS_ERR_OR_NULL(map)) + return map; + + if (!data->chip_scu_compatible) + return NULL; + + return syscon_regmap_lookup_by_compatible(data->chip_scu_compatible); +} + int airoha_pinctrl_probe(struct platform_device *pdev) { const struct airoha_pinctrl_match_data *data; @@ -853,12 +869,9 @@ int airoha_pinctrl_probe(struct platform_device *pdev) if (IS_ERR(pinctrl->regmap)) return PTR_ERR(pinctrl->regmap); - map = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "airoha,chip-scu"); - if (IS_ERR_OR_NULL(map)) { - map = syscon_regmap_lookup_by_compatible(data->chip_scu_compatible); - if (IS_ERR(map)) - return PTR_ERR(map); - } + map = airoha_pinctrl_chip_scu(dev, data); + if (IS_ERR(map)) + return PTR_ERR(map); pinctrl->chip_scu = map; -- 2.34.1