On Tue, Nov 17, 2026 at 12:27:35PM +0530, Ajay Neeli wrote: > > > On 11/11/2026 11:43 PM, Conor Dooley wrote: > > On Wed, Nov 11, 2026 at 10:08:40AM +0530, Ajay Neeli wrote: > > > Add ref_clk clock property to specify the reference clock frequency > > > supplied to the UFS device. > > > > > > The AMD Versal2 UFS controller operates with a 26 MHz reference clock. > > > UFS 3.x devices default their bRefClkFreq attribute to 26 MHz, matching > > > the controller, so no explicit configuration is needed. However, UFS 4.0 > > > and later devices default bRefClkFreq to 52 MHz, expecting a 52 MHz > > > reference clock. This mismatch causes timing violations and link > > > instability. > > > > > > Adding the ref_clk property allows the UFS driver to read the actual > > > reference clock frequency from the devicetree and program the device > > > bRefClkFreq attribute accordingly during initialization. > > > > > > Signed-off-by: Ajay Neeli > > > --- > > > .../devicetree/bindings/ufs/amd,versal2-ufs.yaml | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml b/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml > > > index c00ec342d574..e294c0f1b0ce 100644 > > > --- a/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml > > > +++ b/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml > > > @@ -20,11 +20,12 @@ properties: > > > maxItems: 1 > > > clocks: > > > - maxItems: 1 > > > + maxItems: 2 > > > > Please add an items list here. > > > > Sure, will add it in v2. > > > > clock-names: > > > items: > > > - const: core > > > + - const: ref_clk > > > > its a clock by nature, don't restate that in the name. > > pw-bot: changes-requested > > The generic UFS platform code currently identifies the reference clock > by the "ref_clk" clock name in ufshcd_parse_clock_info(). > > Would you prefer that the common UFS code be changed to use "ref" as > well, or should this binding retain "ref_clk" for consistency with the > existing UFS core convention? I'd like the core to be changed so that every new ufs device is not forced to propagate the pattern.