From: Jonathan Cameron <jic23@kernel.org>
To: "Sabau, Radu bogdan" <Radu.Sabau@analog.com>
Cc: Radu Sabau via B4 Relay
<devnull+radu.sabau.analog.com@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
"Budai, Robert" <Robert.Budai@analog.com>,
"Gradinariu, Ramona" <Ramona.Gradinariu@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux <linux@analog.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 0/8] iio: imu: Add support for the ADI ADIS16607
Date: Tue, 17 Nov 2026 03:15:09 +0000 [thread overview]
Message-ID: <20261117031509.2dfbc85d@jic23-hlaptop> (raw)
In-Reply-To: <LV9PR03MB84141F84CA155F8CDD2587FAF77C2@LV9PR03MB8414.namprd03.prod.outlook.com>
On Mon, 16 Nov 2026 12:18:27 +0000
"Sabau, Radu bogdan" <Radu.Sabau@analog.com> wrote:
> > -----Original Message-----
> > From: Sabau, Radu bogdan
> > Sent: Monday, November 16, 2026 10:55 AM
>
> ...
>
> > > >
> > > > > This series adds support for the Analog Devices ADIS16607, a precision
> > > > > MEMS IMU with triaxial gyroscope, triaxial accelerometer, and
> > > > > temperature sensor, communicating over a non-standard SPI Half-Duplex
> > > > > protocol.
> > > >
> > > > Applied 1-5 to the testing branch of iio.git.
> > > >
> > > > I 'think' the proposed changes for the fifo handling shouldn't affect
> > > > those and I don't fancy reviewing a mega series with library changes
> > > > and the new device support. So build on the base of these first 5 patches.
> > > >
> > > > You will need to provide a base commit for dependency list though
> > > > or sashiko may get confused.
> > > >
> > > Change of plan. Dropped it over channel type issues in patch 5.
> >
> > Thank you guys again for the review, and sorry about patch 5. I'll move the
> > scan_index/scan_type and the timestamp channel into the FIFO patch and
> > resend.
> >
> > On the FIFO side: adis16475's has_fifo variants register an IIO trigger
> > today and are used through trigger/current_trigger. Converting them to a
> > trigger-less kfifo buffer, as discussed for the library, would remove
> > that attribute on the six ADIS1657x variants, so it is an ABI change on
> > existing devices. Is that acceptable to you?
The ABI change is not. That's not to say you can't bypass it under
the hood. So have the whole current_trigger registered but ignore
whatever it is set to. We have another driver that does that
(for same reason). IIRC you can do it using one of the less
obvious trigger modes.
> >
> > If not, the alternative is a smaller fix in adislib: iio_trigger_poll_nested()
> > for the has_fifo path, plus a prep patch taking the sample timestamp in
> > the handlers instead of pf->timestamp (the nested path does not run the
> > pollfunc top half). That keeps the ABI as is, and the adis16607 would
> > then use the adislib trigger path again.
>
> Thinking about how to split this: sync and calibration bias do not depend
> on the FIFO, so I could resend the series as the adislib patches, the
> binding, the base driver (raw reads only), external clock sync and
> calibration bias, with no FIFO. Then a follow-up series with the FIFO.
> Would that work for you?
>
> For that follow-up I would still like to know which way you prefer to
> go for the adislib FIFO handling:
>
> - kfifo helper: a trigger-less kfifo buffer with its own threaded IRQ,
> used by the adis16607 and the adis16475 FIFO variants. It removes the
> trigger/current_trigger attribute on those variants, so it is an ABI
> change.
This but without the visible ABI change. We just make the ABI do
nothing. :)
> - iio_trigger_poll_nested(): a smaller fix in adislib for the has_fifo
> path, plus a prep patch taking the sample timestamp in the handlers.
> It keeps the ABI, and the adis16607 would use the trigger path again.
> It is only two or three patches, so if you think it is the better
> alternative it could also be done in this series.
>
prev parent reply other threads:[~2026-11-17 3:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 12:33 [PATCH v6 0/8] iio: imu: Add support for the ADI ADIS16607 Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 1/8] iio: imu: adis: Fix custom reset dispatch in adislib Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 2/8] iio: imu: adis: Add optional self_test callback Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 3/8] iio: imu: adis: Add optional init callback Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 4/8] dt-bindings: iio: imu: Add bindings for ADI ADIS16607 Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 5/8] iio: imu: Add driver for the " Radu Sabau via B4 Relay
2026-11-14 0:52 ` Jonathan Cameron
2026-11-13 12:33 ` [PATCH v6 6/8] iio: imu: adis16607: Add FIFO-based buffered capture Radu Sabau via B4 Relay
2026-11-13 12:51 ` sashiko-bot
2026-11-13 14:48 ` Sabau, Radu bogdan
2026-11-14 0:57 ` Jonathan Cameron
2026-11-13 12:33 ` [PATCH v6 7/8] iio: imu: adis16607: Add external clock sync support Radu Sabau via B4 Relay
2026-11-13 12:33 ` [PATCH v6 8/8] iio: imu: adis16607: Add calibration bias support for gyro/accel Radu Sabau via B4 Relay
2026-11-13 12:41 ` [PATCH v6 0/8] iio: imu: Add support for the ADI ADIS16607 Sabau, Radu bogdan
2026-11-13 14:09 ` Andy Shevchenko
2026-11-14 0:21 ` Jonathan Cameron
2026-11-14 0:25 ` Jonathan Cameron
2026-11-14 0:49 ` Jonathan Cameron
2026-11-16 8:54 ` Sabau, Radu bogdan
2026-11-16 12:18 ` Sabau, Radu bogdan
2026-11-17 3:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117031509.2dfbc85d@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Antoniu.Miclaus@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Radu.Sabau@analog.com \
--cc=Ramona.Gradinariu@analog.com \
--cc=Robert.Budai@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=devnull+radu.sabau.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox