From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794919211; b=f03TkHk/09+2uAP9iqnYbQ3+LdZaQ4terra3RL4VQ29CPKNlWG8trX4FTfwNouzBYNaN heOM3xDW6QkAGEm5rSaxsHHvozCtUMfYgATILe/Xyendqd/pEEXxYY47bsFx/mfRVFaXM znxJ7Z5if/tMOLhm9zfcT532s2K3MFeOU3IJhb7YVzJkQZ4QCiiwS1gcvcN2A0mJF/zxC 3SLwasE8qHIn4ZXKnvKKBMoyGLYoAOz4Co0r0cNTAecDHilp2rWnTejXZfusotUVeOCqT zhBopVC36IbFrQ/3mP2xlEaQvarCqsId0E24WdadwB9bjQkTKYqyGX+L6yZdN1JL5Yg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794919211; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=mECM5EXejN2phHfDWaxMihjK3BWjNz9g8yW5s9/u9KnrcwDIY5RSzHRBFlo6njYpBfbP rPaouG6I88MLmS9l36EYQstLHIXO6COAl0rJIH6eDtRr0ACtnQfFcuRQ8+5xQSOSwKD9Z U5jihy0fwL3yE7ugQNw9uE5TpZ2Z2c+lgqk8fTA0j5ik8MOeqfCwdbLqlglk/q2lwc+TW zpx3q+JGwuxja+DIOE5jSmu9LdQNb3dM2iizgG4ih05KPH6x9PMeH31VM1tQKgyaI5zMr R4BnEIezPWeosRUMNLHFnzT3kZbvMUCxHKhHJD3uuwOnBdNTPSwX7gmm/Drd2XEyucw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jMyWs6M3; arc=none smtp.remote-ip=209.85.128.48 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7D460A3807 for ; Tue, 17 Nov 2026 12:40:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9A7D460A3807 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jMyWs6M3 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4bb68c197c7so33277765e9.1 for ; Tue, 17 Nov 2026 04:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794919210; x=1795524010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=jMyWs6M3HAp/JBLBUeMtu/fMax2mlkF8tJ3C2dxahv//OkxZ0P5ZXLTorHIDJJ9qr4 WNL7e0OzWViTCRcsA4kwyeIYPlju+NX6Iq3odWCMbZHojlmTPWt128tI7XpDIL8npQnj okcXI7b/NWyZJRRjjsOgVdutTOuQWWDov1HPgBwdn+TLqg5bIDBwScw2/QGSj3G3UijY T5E+DzRaIqSvuM02/yXX/JaVA49YDHQbjTWUoj2Ek0fuVLq3kL0XuczRElby+xiTEI7W dREsx78dGWW5v0uJ0nsAZ77r5VYFhX3ngpDsmL2iinXbOdlMSCRKUeA0j4Dc/1uSSjbj aYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794919210; x=1795524010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=iqXUKOcy9qCieLizcJg3vkRsvwt8JgXWNmMSevngILY=; b=dF9e64bRomSpT9KGQDS4p7nA7Rw4fBlAsxF4mpxUv89zXBiQIutizKtynDRU3pa/nc Ey6WU2HB8Ra4l949Rl55YLVg4/DpqAxUCjxts4/OYoegzy0t5jbl6zGdnTxvLHbq3YH1 ncHm36YM6i2an8R7QFm7gNoeAC46PELb53ifWM6DPaNHJJGt/RbQf/lO26K+Ux3j1gsZ Z1yKApe/J+q2JCUfOXSj4WbN91qjDdq53XLCf6k64HuqnLy4jri+sziIg20NyTAef1l7 nrXvGc/rQhWNiymwtSAB2nTso69OL3eirspoiXZxB8wCgiBV9I2lDlt8MRMTRtdSQpGF 6obQ== X-Forwarded-Encrypted: i=1; AL+hErHwOm/Z69ez3gHbzNY3JVuhMZ3k4LMEbi6iE4qdT6ujy2kI9jyxMv38682fLAaLAdjxj3X/1ACKeSzX@vger.kernel.org X-Gm-Message-State: APuU4Z932jg41ceIepQHUOcbTJPQjj247g/qmgHI7B4bRsw4/JGzVcyU +BSZYNMkT17o9tuIM7GGFyrkeHLf7UTCWQmKjOdFuNovWxnFJ9r7bNM7 X-Gm-Gg: AYBFou3uVgpmDkQpz0cmTvx2IsBaQA8G374vcgGuISUDMS+vXqeJ/hft6dXDVKjOsMJ YR1PxOWjwFUCyfk4xH7oyVDUwu+JqCD85WApOEXNzVCMeSrqRHni3De7wDq4o15I1zl/kKs6NP3 GO9zHL7rCaPxwdLyrOGr7e1CmVSZjB/Cg9dVtpj/3XcS3jpydft8pAPu2HDMlE1ZJQbzJdX0TvG W8tN0cPx5m5thB/4cHLwvFJlasOeazRXSr069kKS+53wmotzMXgZs2qFwLz1vbf4aBZAzusuivW mNAzhw5QRZxNSXB9nIy7+tC62fZEfbKEt0yYMOmSLrt7lxCPdhPEWqeqksZNGh5Poc8UxMexVQh csjwIIgwmYOG8bZ5Q8kHHTH0c5O/q+CpxYDkVGxPZ/u76/29YUittgYXeNC+s6GKGCh/3s1Svh/ i+kOwhXsFeXjZ1qHOCaHJGUX3kmAT/v5AtSp1FiPysakaYzlUzJgZTd3/9yIYj61LFPgREg3Coz nYDzF9QJXjN0A5kEF/uqx9pPgORsm+xJLHacisAp2hAV02SH2fndKRZWl0TWRex6nWVDw5J0HFe +ZGkkZWd3BkjUZBaVnaBOE9J357AlnXByRJRW1cLxq+JDI2x9xMElWJGUXYnHWksO9J7p2/tXPn ZR09U4uqdcEpALWNYZi5HjbOZTFRaV+MBDg== X-Received: by 2002:a05:600c:474f:b0:4bb:76d6:1f5d with SMTP id 5b1f17b1804b1-4bb76d61fb0mr87328795e9.2.1794919209827; Tue, 17 Nov 2026 04:40:09 -0800 (PST) Received: from Ansuel-XPS24.localdomain (93-34-92-103.ip49.fastwebnet.it. [93.34.92.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4bb78386902sm73367065e9.1.2026.11.17.04.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 04:40:09 -0800 (PST) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Maxime Chevallier , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Russell King (Oracle)" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v22 01/15] net: phylink: make PCS phylink instance access RCU protected Date: Tue, 17 Nov 2026 13:39:41 +0100 Message-ID: <20261117123956.11981-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261117123956.11981-1-ansuelsmth@gmail.com> References: <20261117123956.11981-1-ansuelsmth@gmail.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the context of phylink_pcs_change(), phylink instance is dereferenced from the pcs pointer present in the phylink_pcs struct. There is currently a fragility where this pcs pointer is never set NULL in phylink_destroy() and would reference invalid memory after phylink instance is freed. In this scenario, if a PCS driver calls phylink_pcs_change(), invalid memory can be dereferenced and phylink_link_changed() is called on freed memory. To address this, make the phylink instance saved in phylink_pcs struct RCU protected and access it under RCU lock. Also correctly reset the phylink instance pointer on phylink_destroy() and syncronyze RCU to catch an execution of phylink_pcs_change(). Fixes: 24699cc1ff3e ("net: phylink: add support for PCS link change notifications") Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 17 ++++++++++++++--- include/linux/phylink.h | 2 +- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index e7734e45376c..d9d0ace2042e 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -1295,10 +1296,10 @@ static void phylink_major_config(struct phylink *pl, bool restart, phylink_pcs_disable(pl->pcs); if (pl->pcs) - pl->pcs->phylink = NULL; + rcu_assign_pointer(pl->pcs->phylink, NULL); if (pcs) - pcs->phylink = pl; + rcu_assign_pointer(pcs->phylink, pl); pl->pcs = pcs; } @@ -2137,6 +2138,11 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + if (pl->pcs) { + rcu_assign_pointer(pl->pcs->phylink, NULL); + synchronize_rcu(); + } + cancel_work_sync(&pl->resolve); kfree(pl); } @@ -2601,10 +2607,15 @@ EXPORT_SYMBOL_GPL(phylink_mac_change); */ void phylink_pcs_change(struct phylink_pcs *pcs, bool up) { - struct phylink *pl = pcs->phylink; + struct phylink *pl; + + rcu_read_lock(); + pl = rcu_dereference(pcs->phylink); if (pl) phylink_link_changed(pl, up, "pcs"); + + rcu_read_unlock(); } EXPORT_SYMBOL_GPL(phylink_pcs_change); diff --git a/include/linux/phylink.h b/include/linux/phylink.h index 3a88a69882a6..4a0dc6fa8010 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -494,7 +494,7 @@ struct phylink_pcs_ops; struct phylink_pcs { DECLARE_PHY_INTERFACE_MASK(supported_interfaces); const struct phylink_pcs_ops *ops; - struct phylink *phylink; + struct phylink __rcu *phylink; bool poll; bool rxc_always_on; }; -- 2.55.0