Devicetree
 help / color / mirror / Atom feed
From: Enzo Adriano <enzo.adriano.code@gmail.com>
To: alex@sverdlin.org
Cc: andre.przywara@arm.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, wens@kernel.org, jernej.skrabec@gmail.com,
	samuel@sholland.org, Maxime Ripard <mripard@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Junhui Liu <junhui.liu@pigmoral.tech>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Pablo Mazzini <pmazzini@gmail.com>,
	Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>,
	Jun Yan <jerrysteve1101@gmail.com>,
	Lukas Schmid <lukas.schmid@netcube.li>
Subject: Re: [PATCH v3 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board
Date: Thu, 19 Nov 2026 13:08:36 -0500	[thread overview]
Message-ID: <20261118-a733-dt-v3-3-reply@gmail.com> (raw)
In-Reply-To: <2105df7b92b20c5268a9a32c202e1cd6c24a6b27.camel@sverdlin.org>

Hi Alexander,

> Should the history be moved below "---"?

Yes, in v4.

> Should two regulators and the clock have been sorted in the reverse order?

Yes. osc32k-clk sorts before the two regulator nodes; I will fix the
order in v4.

> Should "status" have been last (preceded by a blank line)? (dts-coding-style.rst)

Yes. In v4 I will put status last in r_i2c0, after its properties and
before the PMIC child node, with a blank line before each. mmc0 and
uart0 already put status last; I will add the preceding blank lines
there too.

Thanks,
Enzo

  reply	other threads:[~2026-11-19 18:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  4:45 [PATCH v3 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano
2026-11-10  4:45 ` [PATCH v3 1/3] dt-bindings: arm: sunxi: document Radxa Cubie A7S Enzo Adriano
2026-11-17 23:24   ` Alexander Sverdlin
2026-11-10  4:45 ` [PATCH v3 2/3] arm64: dts: allwinner: add A733 SoC description Enzo Adriano
2026-11-10 23:45   ` sashiko-bot
2026-11-11 12:02   ` Vinicius Pedrosa
2026-11-18 16:47   ` Alexander Sverdlin
2026-11-19 18:06     ` Enzo Adriano
2026-11-10  4:45 ` [PATCH v3 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board Enzo Adriano
2026-11-11  0:00   ` sashiko-bot
2026-11-18 18:03   ` Alexander Sverdlin
2026-11-19 18:08     ` Enzo Adriano [this message]
2026-11-11 12:09 ` [PATCH v3 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118-a733-dt-v3-3-reply@gmail.com \
    --to=enzo.adriano.code@gmail.com \
    --cc=alex@sverdlin.org \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jerrysteve1101@gmail.com \
    --cc=junhui.liu@pigmoral.tech \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=lukas.schmid@netcube.li \
    --cc=mripard@kernel.org \
    --cc=pmazzini@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=vinicius.eduardo.pedrosa@gmail.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox