Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: linux-iio@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	devicetree@vger.kernel.org,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	"Joshua Crofts" <crofts@kernel.org>
Subject: Re: [PATCH v3 0/5] iio: light: gp2ap020a00f: Add VCC supply and GP2AP030A00F support
Date: Thu, 19 Nov 2026 01:36:07 +0000	[thread overview]
Message-ID: <20261119013607.2f763ff3@jic23-hlaptop> (raw)
In-Reply-To: <20261118-gp2ap030-v3-0-c8df93460110@kernel.org>

On Wed, 18 Nov 2026 14:46:07 +0100
Linus Walleij <linusw@kernel.org> wrote:

> Describe and enable the optional VCC supply for the GP2AP020A00F and
> GP2AP030A00F. Preserve compatibility with existing device trees that only
> describe the LED supply.
> 
> Extend the existing binding and driver to support the GP2AP030A00F. It
> shares the register layout, but has different proximity resolution
> encodings and no automatic lux calculation. Select model-specific
> initialization, keep reserved bits clear and expose fixed-range raw
> clear and infrared counts. Keep generic supply handling in separate
> patches from the model-specific binding and driver additions.
> 
> Assisted by LLM.
> 
> Signed-off-by: Linus Walleij <linusw@kernel.org>
Applied. Thanks,

J
> ---
> Changes in v3:
> - Return -ENODATA when chip match data is missing.
> - Use four-line initializers for I2C device IDs.
> - Document the 1 ms power-on delay and use USEC_PER_MSEC.
> - Align family descriptions and list supported parts in Kconfig help.
> - Pack GP2AP030A00F samples as 16-bit values and omit zero shifts.
> - Link to v2: https://patch.msgid.link/20261108-gp2ap030-v2-0-24eaa1b9fe59@kernel.org
> 
> Changes in v2:
> - Replace vdd/vio with one optional vcc supply, matching the VCC pin.
> - Use devm_regulator_get_enable() for VCC, allowing dummy regulators.
> - Move the VLED description into the generic supply binding patch.
> - Split variant infrastructure from GP2AP030A00F support.
> - Use "GP2AP020A00F and similar" in family descriptions.
> - Use reverse Christmas tree ordering for local declarations.
> - Explicitly select MANUAL_CALC when automatic ALS calculation is absent.
> - Reject missing chip match data before accessing the device.
> - Use fsleep() for the GP2AP030A00F startup delay.
> - Select static channel arrays and counts through chip_info.
> - Link to v1: https://patch.msgid.link/20261108-gp2ap030-v1-0-55314eb7055b@kernel.org
> 
> ---
> Linus Walleij (5):
>       dt-bindings: iio: light: sharp,gp2ap020a00f: Add VCC supply
>       dt-bindings: iio: light: sharp,gp2ap020a00f: Add GP2AP030A00F
>       iio: light: gp2ap020a00f: Enable the VCC supply
>       iio: light: gp2ap020a00f: Prepare for chip variants
>       iio: light: gp2ap020a00f: Add GP2AP030A00F support
> 
>  .../bindings/iio/light/sharp,gp2ap020a00f.yaml     |  17 ++-
>  drivers/iio/light/Kconfig                          |   6 +-
>  drivers/iio/light/gp2ap020a00f.c                   | 147 +++++++++++++++++++--
>  3 files changed, 151 insertions(+), 19 deletions(-)
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261107-gp2ap030-99504c2dc038
> 
> Best regards,
> --  
> Linus Walleij <linusw@kernel.org>
> 


      parent reply	other threads:[~2026-11-19  1:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:46 [PATCH v3 0/5] iio: light: gp2ap020a00f: Add VCC supply and GP2AP030A00F support Linus Walleij
2026-11-18 13:46 ` [PATCH v3 1/5] dt-bindings: iio: light: sharp,gp2ap020a00f: Add VCC supply Linus Walleij
2026-11-18 13:46 ` [PATCH v3 2/5] dt-bindings: iio: light: sharp,gp2ap020a00f: Add GP2AP030A00F Linus Walleij
2026-11-18 13:46 ` [PATCH v3 3/5] iio: light: gp2ap020a00f: Enable the VCC supply Linus Walleij
2026-11-18 13:46 ` [PATCH v3 4/5] iio: light: gp2ap020a00f: Prepare for chip variants Linus Walleij
2026-11-18 13:46 ` [PATCH v3 5/5] iio: light: gp2ap020a00f: Add GP2AP030A00F support Linus Walleij
2026-11-19  1:36 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119013607.2f763ff3@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crofts@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox