From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795088318; b=jBQoSxwKQf8Jc/4l1G1nkkk53ZHhk6tE+zHsWnD60APDjxIn7WAfpYxylSrifkUUw4Ql zx2ghVCRJEhq2Q9+byGaiuftwD0NCtcHwnSoNJempiZS+77y2RiIdCrGwDGfPemlS8CMD 9aFLqL5d2mlLRYVXrV90cnmrNTcLOF6IltVn2vfjisJlsXQspUmbwku0WSlwhS0OaAfME 9a/WrcH34V6GMwNhQ7m40NNmZi6vg4HWfuaYN8OCPWV3iAN/HsqQS5PRAKsYveQCx8Fsm 1XgQQHn0sJKvf5WUkBEhZxCScBCXGAXne3BhHLjfM8mMVeCy7nGYKajQY7oz+Z0FBXQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795088318; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=L1YcTl/uYfFtLb4iHc/VuFExeEr6pRbLZWly8UMoO5U=; b=AA/wpUv9+CoaM39p264ZKW8+Wf2FZ6yDuMqrqAx+0I9hAJ9ThLJ2i4dYVWSXPzYHO4Lt E/yZJ8PHHOX/GCINOKCBTX783QCJjGCu9vMnLPEg248hc4o4tkaUkkzu/IcRKguwTKoN5 hcE/boKbdOIju9Lbp1eULXi5+kJmm3f21ax0scm3/GoVRXUgve7ShwB98v/FqXLQCfIkw po70c8iLXm+lrQrJVEUnDuABuI3fA88L8Tq0ETxHg9IRhh7hL0FLsabznnWtJ/YQ77Tuv SvThLi2dfy+Kcfaz+jY9AVdCX4/PZdmBvx0oXqR1tKRYXvXEyZehTyzMSYPT3e+uOGg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=GjGO65NN; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADBB606A332 for ; Thu, 19 Nov 2026 11:38:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1ADBB606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=GjGO65NN Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id BEE8D4E41665; Thu, 19 Nov 2026 11:38:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8AF8C60237; Thu, 19 Nov 2026 11:38:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BD25A11BC1249; Thu, 19 Nov 2026 12:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795088311; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=L1YcTl/uYfFtLb4iHc/VuFExeEr6pRbLZWly8UMoO5U=; b=GjGO65NNOSB8ZEHNPWdX+QLZsp0hZ4Zz5l6LH58sZhhekddhSKLcZtO6Eex5P+uASB5uqs noI88Ek4b6WI+9qE8JCCXfCapMCJPynJJ0rCjute/GeoQqDetQq+UsbBJwQSIG4P7dWsqg VdD2hwj4h3akOVu9hme8a8O67I6CpqBzjZZ/thquyJzUVKfcaKRJNIB4L3ybgwoLbp602M VYZ1CqGM86fe4Cdff798vqdKasVkoGFq+nCI2wz6/vMRcoZoSaE7RqhweuhFepV3CLKLbB w1JA0ycEe6u6hSq0zDsYTBmK17aDHY8W6v4Dgq7PPed5S5gvhtfBprQZb2hrBQ== From: Herve Codina To: Andrew Lunn , Rob Herring , Saravana Kannan , Geert Uytterhoeven , Kalle Niemi , Matti Vaittinen , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Johan Hovold Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Daniel Machon , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni , Herve Codina Subject: [PATCH v11 3/5] bus: simple-pm-bus: Remove child devices when the bus is unbound Date: Thu, 19 Nov 2026 12:37:54 +0100 Message-ID: <20261119113758.603074-4-herve.codina@bootlin.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261119113758.603074-1-herve.codina@bootlin.com> References: <20261119113758.603074-1-herve.codina@bootlin.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 During its probe, the simple-pm-bus driver (simple-pm-bus compatible variant) populates its child devices but it doesn't touch them during its removal. This leads to bus child devices present and bound to drivers whereas the bus itself is unbound. Be consistent and remove child devices when the bus itself is unbound. Signed-off-by: Herve Codina --- drivers/bus/simple-pm-bus.c | 45 +++++++++++++++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c index e45700156732..23ac18551fd9 100644 --- a/drivers/bus/simple-pm-bus.c +++ b/drivers/bus/simple-pm-bus.c @@ -22,6 +22,46 @@ struct simple_pm_bus { int num_clks; }; +static void simple_pm_bus_depopulate(void *data) +{ + struct device *dev = data; + + /* + * Bus stays on for children + * This ensure that the bus will not be put in idle asynchronously when + * all its children are removed. + */ + pm_runtime_get_sync(dev); + + /* Let remove children */ + of_platform_depopulate(dev); + + /* + * Lets runtime_suspend() calls simple_pm_bus_runtime_suspend() in a + * synchronous way before disabling runtime pm. + * + * This guarantee that clocks are disabled and unprepared before the + * bus is removed in all cases. + */ + pm_runtime_put_sync(dev); +} + +static int simple_pm_bus_populate(struct device *dev, + const struct of_dev_auxdata *lookup) +{ + struct device_node *np = dev->of_node; + int ret; + + if (!np) + return 0; + + ret = of_platform_populate(np, NULL, lookup, dev); + if (ret) + return ret; + + return devm_add_action_or_reset(dev, simple_pm_bus_depopulate, dev); +} + static int simple_pm_bus_probe(struct platform_device *pdev) { const struct device *dev = &pdev->dev; @@ -71,8 +111,9 @@ static int simple_pm_bus_probe(struct platform_device *pdev) if (ret) return dev_err_probe(&pdev->dev, ret, "failed enable pm_runtime\n"); - if (np) - of_platform_populate(np, NULL, lookup, &pdev->dev); + ret = simple_pm_bus_populate(&pdev->dev, lookup); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to populate\n"); return 0; } -- 2.56.0