Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
	devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
	conor+dt@kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: serial: 8250: Add dedicated Loongson-2K3000 UART compatible
Date: Thu, 19 Nov 2026 15:45:32 -0600	[thread overview]
Message-ID: <20261119214532.GA757146-robh@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-196836@kernel.org>

On Wed, Nov 04, 2026 at 07:52:04AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: serial: 8250: duplicate ns16550a fallback block for ls2k3000
> --
> 
> commit 71974153fe22bc00d365059be9198364c9cfaa86
> Author: Binbin Zhou <zhoubinbin@loongson.cn>
> 
> dt-bindings: serial: 8250: Add dedicated Loongson-2K3000 UART compatible
> 
> This commit documents the loongson,ls2k3000-uart compatible string with
> ns16550a as a fallback so the driver can distinguish the Loongson-2K3000 UART
> from earlier Loongson UARTs that require MCR/MSR signal inversion.
> 
> > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> > index 01abd39509a7a..33c13c48ed56e 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> > @@ -196,6 +196,9 @@ properties:
> >                - loongson,ls2k2000-uart
> >            - const: loongson,ls2k1500-uart
> >            - const: ns16550a
> > +      - items:
> > +          - const: loongson,ls2k3000-uart
> > +          - const: ns16550a
> 
> [Severity: Low]
> This isn't a bug, but properties:compatible in
> Documentation/devicetree/bindings/serial/8250.yaml already has a two-item
> block with const: ns16550a as the fallback that includes the other base
> Loongson UART compatibles:
> 
>       - items:
>           - enum:
>               ...
>               - loongson,ls2k0500-uart
>               - loongson,ls2k1500-uart
>           - const: ns16550a
> 
> Could loongson,ls2k3000-uart be added to that existing enum instead of adding
> a separate two-item block?

Sashiko is correct. Please address this comment.

And please answer sashiko comments before the maintainers have to.

Rob

  reply	other threads:[~2026-11-19 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  7:45 [PATCH 0/3] serial: 8250: Add Loongson-2K0300 and Loongson-2K3000 UART support Binbin Zhou
2026-11-04  7:45 ` [PATCH 1/3] dt-bindings: serial: 8250: Document Loongson-2K0300 UART compatible Binbin Zhou
2026-11-19 21:43   ` Rob Herring (Arm)
2026-11-04  7:45 ` [PATCH 2/3] dt-bindings: serial: 8250: Add dedicated Loongson-2K3000 " Binbin Zhou
2026-11-04  7:52   ` sashiko-bot
2026-11-19 21:45     ` Rob Herring [this message]
2026-11-04  7:45 ` [PATCH 3/3] serial: 8250_loongson: Add Loongson-2K3000 UART support Binbin Zhou
2026-11-04  7:58 ` [PATCH 0/3] serial: 8250: Add Loongson-2K0300 and " Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119214532.GA757146-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox