From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795174871; b=qgVk4oN8mnCYi4rZ8Te1dqPI8SB02jugF/kiHv3fPiCQgGdybcHcVGlpmtXP7YKDFKwP AadnxetXe6sCSRCisfwKhbTpuC2YpnWN1ZsCl+YPCFjhdT2JdlpC3wAnDmo3YabrpmiJx lf0xMsnnOO06nAv0Rz1WSzICplIggdcIRnmaFSbghW8YHtAHNJtI9gucBqIX6cWzye4RX lOCRUCEeYuo4uyDgRLNCTZ7hCuzBkhXWhGEEVoy2W7MSsNQv4cPv9vcoEDq9UmD09XPCO DTKUnwGhRbHROY/TsWXHstFCsPBprgTfXRZxxcsxTUxB10IAZTspwCukD/2Vnojzhbw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795174871; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=FRDowpMlxsSqGbMH8/hR7UxeXY/jVu9wL78Xe7fTNcM=; b=jbeorc2sgbWP1slp1zOYsSkTbVu+b+JFuSrTOuqkPYaxu4dUWdDzU9jivDwes07hcftf 0Skt/mnmfXNbKc9Rxn7E7tDnNIW7+u5xpAzheONKaTTpu0aPAHbf7NJJVOtrVELbcyyAE E6CVglhJRmx+Rz5nFCx0yD3oVlTMd+4TAqS7lwwUw++TSZVKYZ/kjMQ12tAa8EXK8g01S AlEBD0iO+ynkTFLqBnWjcQMzVEXsINfeI2+tVYhFtoX4gfonWndsrq7ftIQtKf3z55N0a zbhIKWML1hG+eSVPX2Err5wUIBdl6HKJxJCTrPZ37JWB/b1O1/jnw0Vul48ew8pczhg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=qWuJxCkP; arc=none smtp.remote-ip=209.85.221.42 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39F82606A33E for ; Fri, 20 Nov 2026 11:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39F82606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=qWuJxCkP Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4ad6219f7d8so176816f8f.0 for ; Fri, 20 Nov 2026 03:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795174868; x=1795779668; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FRDowpMlxsSqGbMH8/hR7UxeXY/jVu9wL78Xe7fTNcM=; b=qWuJxCkPBVay44C53gnGY3OUn49m+4YS8owwqGcIdfgGAEU8rj2AkdN1REXOmU6pj1 Q1P99GAoDLkjWTukfZEeVORlqKmPFoOb1vKuhhrejXneCniNfG6VZsChN+j6ihREa097 aoWLwMf2jiqbVhtfkeoth7l83SffoQOIa5VWNNc4lku9BF2uuCwXnNbVOO01gG6nt/5+ mYHBEkGA2t6yi8Bbugnbzy0gr/4lSJt/Bin39rfSE5pWKalQjxjLeOaYC4GwAdh20J+O G19iOuw3bz7smf6JYnzltJNHLvs3QfCTCnee5Mzr8XuBmXszxcKKbhuEg/E4dtLqZNiT t8lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795174868; x=1795779668; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FRDowpMlxsSqGbMH8/hR7UxeXY/jVu9wL78Xe7fTNcM=; b=i3DBg4k/i1IjzBfytjwXVsdUiD8rALpKonmFeKkP4K1Gk/YxbRw75bVZ+36VmBIJ1Z gZR42i9cHJ/jeiuqvjRKIssyuoTZk89HODqdWQAyZ3vTCVRy+0V0MCfR6N75Hc8iCrHl LEdcUPW5/6hPBPrtSPhZBy1zK/Vyh78oLLSi3zzEfEkArOOv/cneft/xWGxE2SprhfjA TesfjKMl9AnE02er9yBMwWx0a01hco08ycveKh8WsfYkIGZA0HGAgPqvGKMN89K8on9E ASNbh0LAji85wtjTd+976x9jOh7W8hHkIXcktw2Qw9fhsYYEEz0qImQMRWg0W8Y/fWsR dXSQ== X-Forwarded-Encrypted: i=1; AL+hErGXNGVJq9PrjjNPIBEWFWkUL3pA6ilTMScZyenHI4FIoCoCF0VKbu7c6Cx7WDnXnj8+7s0WC4ldX/KL@vger.kernel.org X-Gm-Message-State: APuU4Z+V8gHkyTKnrZ8tKP1K0LB0fLiXQuIuTHqWRvcFG5bSjyZqwqjG guAOBZ1T9ZlfXHpYFBuf9qAEa8tn9WU7UxGPinijA24+fGLQjR4yYHVI X-Gm-Gg: AYBFou3is4DtA3huP7/TEyHO+ivGLXkX8EFgyBJcWyqKv1/+5rnuZs2vRL7xiS5U3kN w6PfE/nVHSVwx4RpaWXQ9FNYaK68mgTQRpmfZ8KpVBccHsFsQ3ze2A7W6+FPd55BH1dpQs8RkYA /8j2OChMCA2SY6W7N2H9WSBfVuPNHyKe1/+j6fYoLWp3vpSO0+BW0Fu4KLquqZAaF/IfQEIVyjt RemIr+4cRaXgsadjgo0THtBCTwt0R4v4mJirKVqpmY5Xh6Rs0otwDuFIpk/s2S6h4wsxyRccARG f28Hf7LqGX/1LMBHcqEGIlI7pmv54zGWnEaK3zecccSSbb80FGkz9y7Kktbw5PBr8mx5/8735t7 A69XTZ5KzfgYAsn5aZ71Na4CGBHS6I8+Pu3rMOlXaNvF4tnJGE1KR+dxCg1IIEY7HDulwR4yAMy DlV1RumXaxgGDef+DHdN1qWbFXoXbagPkvvFJa3p4FZWjoazp6Axpdl48Ao1lU7KTxWHmFSz6LA iub9bzN90paTRG48dMJO0IIa33Rd85j5jDs2Fbm8sobSKvL1DOvFL7bldfmfVfsK3HEM9accVwP CuuZnxtHtqjMDqbKXrWVPTC1+dfBMjY7N3DQ01PLLvEnKHU= X-Received: by 2002:a05:600c:1c0e:b0:4a1:ddaa:571e with SMTP id 5b1f17b1804b1-4bb88824f38mr70578725e9.15.1795174868275; Fri, 20 Nov 2026 03:41:08 -0800 (PST) Received: from dl360p ([130.61.107.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb8d4f9aa8sm27419345e9.4.2026.11.20.03.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 03:41:07 -0800 (PST) From: =?UTF-8?q?Adil=20H=C3=BCsrev=20Tepe?= To: neil.armstrong@linaro.org, jesszhan0024@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, u.kleine-koenig@baylibre.com, =?UTF-8?q?Adil=20H=C3=BCsrev=20Tepe?= Subject: [PATCH v4 2/2] drm/panel: add Novatek NT36525 panel driver Date: Fri, 20 Nov 2026 14:41:00 +0300 Message-ID: <20261120114100.978148-3-tadilhusrev@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261120114100.978148-1-tadilhusrev@gmail.com> References: <20261116070212.314228-1-tadilhusrev@gmail.com> <20261120114100.978148-1-tadilhusrev@gmail.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a DRM panel driver for MIPI-DSI video-mode panels based on the Novatek NT36525 controller, as fitted on the Samsung Galaxy XCover5 (SM-G525F): 720x1480, active-low reset (RESX), and a DCS init sequence that mirrors the stock Samsung bring-up. Backlight is handled through the common drm_panel_of_backlight() path. Tested on a Samsung Galaxy XCover5 running 7.4-rc3 plus this driver and the matching DTS/binding: debugfs reports the reset gpio as ACTIVE LOW, and the DSI panel connector probes and reports "connected", with /sys/class/backlight/ present and readable (re-confirmed 2026-11-20, kernel 7.4.0-rc3-00023-gdcb8b91fb779+ #32, after rebasing our local tree from 7.4.0-rc1 to the real 7.4-rc3 tag). Signed-off-by: Adil Hüsrev Tepe --- v3 -> v4 (addressing Uwe Kleine-König's review of v3, https://lore.kernel.org/all/20261117173319.1852638-3-tadilhusrev@gmail.com/): - Drop (pulled in transitively; of_device_id and MODULE_DEVICE_TABLE(of, ...) still build clean without it). v2 -> v3: no functional change. v2 was mistakenly sent as a diff on top of v1's own (unmerged) patch instead of a complete, standalone patch against mainline, which Krzysztof Kozlowski correctly flagged as a git-management mistake on my part (see the cover letter). This resends the full driver as a single patch, folding in every v1 -> v2 fix below, and fixes a Kconfig help-text typo ("active-high" -> "active-low") left over from v1 that v2 never corrected. v1 -> v2 (addressing Sashiko AI's review of v1, https://sashiko.dev/#/patchset/20261116070212.314228-1-tadilhusrev@gmail.com?part=2): - Set prepare_prev_first = true before drm_panel_add(). Without it, drm_atomic_bridge_chain_pre_enable()/post_disable() call this panel's prepare()/unprepare() on the wrong side of the DSI host bridge's own enable/disable, which host_transfer() rejects on bridge-based hosts (e.g. samsung-dsim). - Fix the reset_gpio polarity: the driver drove the physical level directly instead of using gpiod logical values, which inverts under the GPIO_ACTIVE_LOW DT flag added in the matching binding patch. RESX is active-low (the 1-0-1 physical pulse the vendor sequence describes); switch the DT flag and all gpiod_set_value_cansleep()/ devm_gpiod_get() calls to logical values with the same physical outcome. - Request the "vpos" and "vneg" regulators the driver already needed (matching the binding fix) so dtbs_check and probe agree. - Use drm_connector_helper_get_modes_fixed() in nt36525_get_modes() instead of open-coding drm_mode_duplicate() + drm_mode_set_name() + manual display_info updates and returning -ENOMEM on failure (which drm_helper_probe_get_modes() logs as an error; the helper returns 0 instead). - Rename the compatible string to novatek,nt36525-xcover5, matching the fixed binding; the old samsung,xcover5-nt36525 never matched this driver's of_match_table. --- drivers/gpu/drm/panel/Kconfig | 13 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-novatek-nt36525.c | 490 +++++++++++++++++++++ 3 files changed, 504 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36525.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 7a520b4d6..bfcac173f 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -676,6 +676,19 @@ config DRM_PANEL_NOVATEK_NT36523 around the Novatek NT36523 display controller, such as some Boe panels used in Xiaomi Mi Pad 5 and 5 Pro tablets. +config DRM_PANEL_NOVATEK_NT36525 + tristate "Novatek NT36525 DSI panel for Samsung Galaxy XCover5" + depends on GPIOLIB + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the Novatek NT36525 + 720x1480 MIPI-DSI video-mode panel, such as the one fitted on the + Samsung Galaxy XCover5 (SM-G525F). The panel uses an active-low + reset (RESX) and a DCS initialisation sequence that mirrors the stock + Samsung bring-up. + config DRM_PANEL_NOVATEK_NT36532 tristate "Novatek NT36532-based MIPI-DSI panels" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index da5175909..46de72db7 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -65,6 +65,7 @@ obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35532) += panel-novatek-nt35532.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36523) += panel-novatek-nt36523.o +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36525) += panel-novatek-nt36525.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36532) += panel-novatek-nt36532.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36536) += panel-novatek-nt36536.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT36672A) += panel-novatek-nt36672a.o diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36525.c b/drivers/gpu/drm/panel/panel-novatek-nt36525.c new file mode 100644 index 000000000..9f6f60a04 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-novatek-nt36525.c @@ -0,0 +1,490 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Novatek NT36525 MIPI DSI panel driver for the Samsung Galaxy XCover5 + * + * Panel timing and the DCS initialisation sequence are taken from the + * Samsung GPL kernel release for the SM-G525F + * (drivers/video/fbdev/exynos/panel/nt36525/nt36525_xcover5_panel.h). + */ + +#include +#include +#include +#include + +#include