Devicetree
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Arun Iyengar via B4 Relay <devnull+aiyengar1990.gmail.com@kernel.org>
Cc: aiyengar1990@gmail.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label
Date: Fri, 20 Nov 2026 18:10:10 +0100	[thread overview]
Message-ID: <20261120181010.59d5f7c0@ryzen.lan> (raw)
In-Reply-To: <20261120-zero2-spi-nor-dual-read-v3-1-1cbb0caaed91@gmail.com>

On Fri, 20 Nov 2026 06:30:08 +0000
Arun Iyengar via B4 Relay <devnull+aiyengar1990.gmail.com@kernel.org>
wrote:

Hi Arun,

> From: Arun Iyengar <aiyengar1990@gmail.com>
> 
> Label the flash node in the shared dtsi, so each board sets its supply
> through the label. The Zero2 keeps reg_aldo1. On the Zero3 the flash VDD
> is on the 3.3V rail from the AXP313A DLDO1 pin (schematic v1.2), so it
> gets reg_dldo1.
> 
> Suggested-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>

> ---
> Andre: reg_dldo1 instead of reg_aldo1 on the Zero3. Schematic v1.2
> sheet 4 labels the 3.3V net "ALDO1", but it comes from AXP313A pin 12
> (DLDO1, VCC33-DLDO); pin 15 (ALDO1) is the 1.8V VCC18-ALDO. The flash
> VDD (U61 pin 8, net DCDCE) is on that 3.3V net. Not tested, no Zero3
> here.

Ah yeah, indeed, the schematic is super confusing in this respect. The
flash chip uses DCDCE(!) as the supply label, which then goes on to
connect to some unused label "ALDO1", but also to VCC33-DLDO, which is
the actual PMIC connection. And the chip needs definitely more than
2.3V for its operation, according to its datasheet, so 3.3V is the right
voltage.

So my bad, and thanks for checking this thoroughly.

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi | 2 +-
>  arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts | 6 ++----
>  arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts | 4 ++++
>  3 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> index 0d3e761f6466..cd1f67ad7c2b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> @@ -104,7 +104,7 @@ &spi0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
>  
> -	flash@0 {
> +	spi_flash: flash@0 {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		compatible = "jedec,spi-nor";
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> index 90c25e12e189..2f8a16d1c9aa 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> @@ -148,8 +148,6 @@ &pio {
>  	vcc-pi-supply = <&reg_aldo1>;
>  };
>  
> -&spi0 {
> -	flash@0 {
> -		vcc-supply = <&reg_aldo1>;
> -	};
> +&spi_flash {
> +	vcc-supply = <&reg_aldo1>;
>  };
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
> index c51d4d9120de..afa753dead30 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
> @@ -103,3 +103,7 @@ &pio {
>  	vcc-ph-supply = <&reg_dldo1>;
>  	vcc-pi-supply = <&reg_dldo1>;
>  };
> +
> +&spi_flash {
> +	vcc-supply = <&reg_dldo1>;
> +};
> 


  reply	other threads:[~2026-11-20 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:30 [PATCH v3 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
2026-11-20  6:30 ` [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label Arun Iyengar via B4 Relay
2026-11-20 17:10   ` Andre Przywara [this message]
2026-11-20  6:30 ` [PATCH v3 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120181010.59d5f7c0@ryzen.lan \
    --to=andre.przywara@arm.com \
    --cc=aiyengar1990@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+aiyengar1990.gmail.com@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox