Devicetree
 help / color / mirror / Atom feed
From: Majid Hajiheidari <majidhhdri@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Vsevolod Nevorotov <sevanevorotov29@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Frieder Hannenheim <git@fhannenheim.net>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: synaptics_tcm_i2c - add Synaptics TouchComm I2C touchscreen driver
Date: Sat, 21 Nov 2026 00:57:12 +0100	[thread overview]
Message-ID: <20261120235713.4038162-1-majidhhdri@gmail.com> (raw)
In-Reply-To: <20260910091405.354058-3-sevanevorotov29@gmail.com>

Hi Vsevolod,

On Thu, 10 Sep 2026 16:14:05 +0700, Vsevolod Nevorotov wrote:
> Add input touchscreen driver for Synaptics TouchComm (TCM) generation-1
> controllers connected over I2C that boot into application mode out of
> their own flash (such as the Synaptics S3908 fitted to the OnePlus 9RT).

I tested v2 on a OnePlus 11 (SM8550), which has the same S3908, on top of
next-20261120 with an out-of-tree device tree.

  synaptics-tcm-i2c 1-004b: TouchComm v1, mode 0x01, part s3908-15.0.0
  synaptics-tcm-i2c 1-004b: 5760x12864, 10 touch objects

Touch works under Phosh, including multi-touch. With wakeup-source set,
the double-tap gesture is reported (KEY_WAKEUP) while the device is
suspended, and touch works again after resume. I could only exercise this
with /sys/power/pm_test = devices, because a full system suspend does not
work on this platform yet.

One question on patch 1/2: the binding describes vdd as the core/digital
supply and avdd as the analog one, but its example connects vdd to a 3.0 V
and avdd to a 1.8 V regulator. Which is intended?

Tested-by: Majid Hajiheidari <majidhhdri@gmail.com> # OnePlus 11

Thanks,
Majid

  parent reply	other threads:[~2026-11-20 23:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  9:14 [PATCH v2 0/2] Input: add Synaptics TouchComm I2C touchscreen driver and bindings Vsevolod Nevorotov
2026-09-10  9:14 ` [PATCH v2 1/2] dt-bindings: input: touchscreen: add Synaptics S3908 controller Vsevolod Nevorotov
2026-09-18 18:33   ` Rob Herring (Arm)
2026-09-10  9:14 ` [PATCH v2 2/2] Input: synaptics_tcm_i2c - add Synaptics TouchComm I2C touchscreen driver Vsevolod Nevorotov
2026-09-11 19:00   ` Uwe Kleine-König
2026-11-20 23:57   ` Majid Hajiheidari [this message]
2026-11-21 14:23 ` [PATCH v2 0/2] Input: add Synaptics TouchComm I2C touchscreen driver and bindings Barnabás Czémán

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120235713.4038162-1-majidhhdri@gmail.com \
    --to=majidhhdri@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=git@fhannenheim.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=sevanevorotov29@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox