From: Krzysztof Kozlowski <krzk@kernel.org>
To: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
Cc: Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 1/3] dt-bindings: usb: snps,dwc3: describe two connectors on one HS data bus
Date: Sat, 21 Nov 2026 10:11:00 +0100 [thread overview]
Message-ID: <20261121-icy-bright-partridge-afe8de@quoll> (raw)
In-Reply-To: <20261121022104.1507987-2-xiaqinghuan@mail.ustc.edu.cn>
On Sat, Nov 21, 2026 at 10:21:02AM +0800, Qianhui Xu wrote:
> Some designs route two USB Type-C receptacles through one High Speed D+/D-
> pair with a GPIO multiplexer, so only one connector drives the controller
> at a time. Each connector needs to be described: which role-switch input
> belongs to it and which mux state selects it, because the role switch is
> registered per connector and the driver must know the state to program
> when that connector asks for a role.
>
> Describe the two connectors as the two endpoints of the High Speed port,
> which is what a mux'ed data stream is in the OF graph: port@0 of "ports"
> carries endpoint@0 and endpoint@1 under "mux-controls", each with
> "usb-role-switch" and the "mux-state" that reaches it. The mux
> controller is referenced with "mux-controls", so an existing "gpio-mux"
> controller can be used as is.
>
> The High Speed port definition itself stays optional: a single-connector
> controller keeps describing one plain "endpoint", and requiring the two
> endpoints together with the rule that their mux states differ only
> applies when "mux-controls" is present. The two states must be opposite,
> and the driver rejects a device tree where two connectors claim the same
> one.
>
> *** AI-assistance disclosure ***
> This patch was prepared with the help of an LLM coding assistant. The
> author reviewed every line and ran the gates quoted in the series notes.
This does not go to commit msg, but changelog.
You keep sending multiple revisions, this one even threaded to other
posting and still not really responding to feedbacks.
Feedback was waiting for three days and then you send the same. That's
just wasting our time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-21 9:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:21 [PATCH v9 0/3] usb: dwc3: support two connectors sharing one HS data bus Qianhui Xu
2026-11-17 5:21 ` [PATCH v9 1/3] dt-bindings: usb: snps,dwc3: two connectors are two endpoints of one port Qianhui Xu
2026-11-17 5:40 ` sashiko-bot
2026-11-18 15:34 ` Rob Herring
2026-11-17 5:21 ` [PATCH v9 2/3] usb: roles: look up role switches attached to a graph endpoint Qianhui Xu
2026-11-17 5:21 ` [PATCH v9 3/3] usb: dwc3: select the shared HS data bus with a mux controller Qianhui Xu
2026-11-17 5:37 ` sashiko-bot
2026-11-18 15:27 ` Rob Herring
2026-11-21 2:21 ` [PATCH v10 0/3] usb: dwc3: support two connectors sharing one HS data bus Qianhui Xu
2026-11-21 2:21 ` [PATCH v10 1/3] dt-bindings: usb: snps,dwc3: describe two connectors on " Qianhui Xu
2026-11-21 2:40 ` sashiko-bot
2026-11-21 9:11 ` Krzysztof Kozlowski [this message]
2026-11-21 2:21 ` [PATCH v10 2/3] usb: roles: look up role switches attached to a graph endpoint Qianhui Xu
2026-11-21 2:21 ` [PATCH v10 3/3] usb: dwc3: select the shared HS data bus with a mux controller Qianhui Xu
2026-11-21 2:33 ` sashiko-bot
2026-11-21 13:20 ` [PATCH v11 0/3] usb: dwc3: support two connectors sharing one HS data bus Qianhui Xu
2026-11-21 13:20 ` [PATCH v11 1/3] dt-bindings: usb: snps,dwc3: describe two connectors on " Qianhui Xu
2026-11-21 13:31 ` sashiko-bot
2026-11-21 13:20 ` [PATCH v11 2/3] usb: roles: look up role switches attached to a graph endpoint Qianhui Xu
2026-11-21 13:20 ` [PATCH v11 3/3] usb: dwc3: select the shared HS data bus with a mux controller Qianhui Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121-icy-bright-partridge-afe8de@quoll \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox